You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "neilconway (via GitHub)" <gi...@apache.org> on 2026/05/30 13:05:59 UTC

[PR] chore: Add primary key constraints for TPC-H, TPC-DS [datafusion]

neilconway opened a new pull request, #22646:
URL: https://github.com/apache/datafusion/pull/22646

   ## Which issue does this PR close?
   
   - Closes #22595.
   
   ## Rationale for this change
   
   The TPC-DS and TPC-H specifications define primary keys, but we previously did not include those constraints when defining the TPC-DS and TPC-H schemas. Including the constraints enables the query optimizer to generate better plans (e.g., by leveraging FDs); it also makes the benchmark setup closer to a realistic TPC-DS/H benchmark run.
   
   ## What changes are included in this PR?
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Add primary key constraints for TPC-H, TPC-DS [datafusion]

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan merged PR #22646:
URL: https://github.com/apache/datafusion/pull/22646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org