You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/01 11:01:11 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #9312:
[FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests
JingsongLi commented on a change in pull request #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests
URL: https://github.com/apache/flink/pull/9312#discussion_r309639887
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -45,8 +45,8 @@
// ------------------------------------------------------------------------
public static final ConfigOption<Integer> TABLE_EXEC_SORT_DEFAULT_LIMIT =
key("table.exec.sort.default-limit")
- .defaultValue(200)
- .withDescription("Default limit when user don't set a limit after order by.");
+ .defaultValue(-1)
Review comment:
+1 for this change. The previous default value is just for stability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services