[GitHub] ivankelly opened a new pull request #1221: Refactored ReadResponse ref count handling

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #1221: Refactored ReadResponse ref count handling
URL: https://github.com/apache/bookkeeper/pull/1221
 
 
   This contains a number of changes.
   
   - V2 bookie protocol
     - Add retain and release methods to all responses. For read response
       it handles the data buffer.
     - ReadResponses always have a buffer now, even if empty.
   
   - Server side
     - In the v2 read handler, releasing of the buffer in the case of
       error is left to the very end.
   
   - Client side
     - Per channel bookie clients own the buffer for read responses.
       If a ReadCallback want it to live past the lifetime of the call
       it must call retain.
   
   This change was originally e8643140 in the yahoo-4.3 branch.
   
   Descriptions of the changes in this PR:
   
   (PR description content here)...
   
   Master Issue: #<master-issue-number>
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   >     `<BP-#>: Description of bookkeeper proposal`
   >     `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   >     `<Issue #>: Description of pull request`
   >     `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
   > - [ ] Replace `<Issue #>` in the title with the actual Issue number.
   > 
   > ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services