You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/30 03:10:42 UTC
[GitHub] [geode] kohlmu-pivotal opened a new pull request #6223: GEODE-9065 - Introduce ClasspathService.
kohlmu-pivotal opened a new pull request #6223:
URL: https://github.com/apache/geode/pull/6223
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] yozaner1324 commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
yozaner1324 commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r606318648
##########
File path: geode-core/build.gradle
##########
@@ -320,6 +320,10 @@ dependencies {
implementation(project(':geode-serialization'))
implementation(project(':geode-tcp-server'))
+ runtimeOnly(project(':geode-deployment:geode-deployment-legacy')) {
+ ext.optional = true
+ }
+
Review comment:
Removed the duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r607319126
##########
File path: geode-deployment/build.gradle
##########
@@ -13,4 +13,4 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- */
Review comment:
This appears to be an empty project that builds nothing. Shouldn't it pull in our `${rootDir}/gradle/java.gradle` project configuration or something?
##########
File path: boms/geode-all-bom/src/test/resources/expected-pom.xml
##########
@@ -1045,6 +1039,12 @@
<version>${version}</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.geode</groupId>
+ <artifactId>geode-deployment-legacy</artifactId>
+ <version>${version}</version>
+ <scope>compile</scope>
Review comment:
I see that we decided to leave this module as non-optional. Can you explain the reasoning there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r607358536
##########
File path: boms/geode-all-bom/src/test/resources/expected-pom.xml
##########
@@ -1045,6 +1039,12 @@
<version>${version}</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.geode</groupId>
+ <artifactId>geode-deployment-legacy</artifactId>
+ <version>${version}</version>
+ <scope>compile</scope>
Review comment:
ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal merged pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal merged pull request #6223:
URL: https://github.com/apache/geode/pull/6223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r607358426
##########
File path: geode-deployment/build.gradle
##########
@@ -13,4 +13,4 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- */
Review comment:
If it serves no purpose other than directory organization, then drop the `build.gradle` file, and remove its entry from `rootDir/settings.gradle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r607324586
##########
File path: geode-deployment/build.gradle
##########
@@ -13,4 +13,4 @@
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
- */
Review comment:
This module is really just a logical abstraction to keep all the deployment related projects together. I don't think there is anything in this project that we need to build, etc... If you believe that we need to add some extra behavior here, please let me us know, but this project is essentially a contextual module rather than a module that provides parent behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r605970632
##########
File path: geode-core/build.gradle
##########
@@ -320,6 +320,10 @@ dependencies {
implementation(project(':geode-serialization'))
implementation(project(':geode-tcp-server'))
+ runtimeOnly(project(':geode-deployment:geode-deployment-legacy')) {
+ ext.optional = true
+ }
+
Review comment:
This declaration already exists on line 236, as a non-optional. With both in place, the result is a non-optional runtime dependency. Which is it?
If we chose optional, we'll also need to modify `test/resources/expected-pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on pull request #6223:
URL: https://github.com/apache/geode/pull/6223#issuecomment-816311580
> This PR touches a number of files that don't currently have anyone assigned to them in CODEOWNERS. Would it make sense to add the authors as codeowners of those files as part of this PR?
@DonalEvans, given that this PR is really just an abstraction exercise, and class moving, I think that there must be codeowners to cover said classes.
Let me see if I can find the corresponding owners and add them to the CODEOWNERS list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on a change in pull request #6223:
URL: https://github.com/apache/geode/pull/6223#discussion_r607325602
##########
File path: boms/geode-all-bom/src/test/resources/expected-pom.xml
##########
@@ -1045,6 +1039,12 @@
<version>${version}</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.geode</groupId>
+ <artifactId>geode-deployment-legacy</artifactId>
+ <version>${version}</version>
+ <scope>compile</scope>
Review comment:
The reason why it was decided to mark it as "required" in this PR is because this PR is the pre-cursor to GEODE-8705. In GEODE-8705 this would become "optional" but for now this project is required at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #6223: GEODE-9065 - Introduce ClasspathService.
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #6223:
URL: https://github.com/apache/geode/pull/6223#issuecomment-816310354
This PR touches a number of files that don't currently have anyone assigned to them in CODEOWNERS. Would it make sense to add the authors as codeowners of those files as part of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org