[GitHub] [storm] Ethanlm commented on a change in pull request #3385: STORM-3759 Additonal Trident Kafka Spout Metrics

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3385:
URL: https://github.com/apache/storm/pull/3385#discussion_r600709138



##########
File path: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/trident/KafkaTridentSpoutEmitter.java
##########
@@ -60,6 +65,14 @@
     private static final long serialVersionUID = -7343927794834130435L;
     private static final Logger LOG = LoggerFactory.getLogger(KafkaTridentSpoutEmitter.class);
 
+    // Metrics
+    public static final String UNDERSCORE = "_";
+    public static final String INTERNAL_KAFKA_RECORDS_LAG_MAX_METRIC = "records-lag-max";
+    public static final String KAFKA_CLIENT_MAX_LAG_METRIC_NAME = "kafkaClientMaxLag";
+    protected transient Gauge<Double> kafkaClientMaxLag;
+    public static final String EVENT_EMIT_METRIC_NAME = "eventEmitRate";
+    protected transient Meter eventEmitRate;

Review comment:
       With the recent change on metrics in storm (converting to v2 metrics),  stream name will be appended to the metric name. 
   
   ```
   The tuple counting metric names contain "${stream_name}" or "${upstream_component}:${stream_name}". The former is used for all spout metrics and for outgoing bolt metrics (__emit-count and __transfer-count). The latter is used for bolt metrics that deal with incoming tuples.
   ```
   
   
   [DimensionalReporter](https://github.com/apache/storm/blob/master/storm-client/src/jvm/org/apache/storm/metrics2/DimensionalReporter.java) can be used to separate dimensions (stream_name, componentId, etc) from metrics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org