You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/31 15:25:04 UTC
[GitHub] [superset] EugeneTorap opened a new issue, #21271: Dataset creation issue in SQL Lab
EugeneTorap opened a new issue, #21271:
URL: https://github.com/apache/superset/issues/21271
I found 2 interesting bugs when we want to create a dataset in SQL Lab:
1. When we create a dataset and provide some name and then want to do it again with the same name. In second dataset creation we got `Untitled Query 7 08/31/2022 17:58:02` name but input has `qwe1` name
2. When we reload page and create a duplicate name of dataset for example name=`qwe1` then modal window is disappeared and don't handle error from server.
### Expected results
We handle server error response and show "Dataset [qwe1] already exists" on UI side to user.
### Actual results
Server error response is not handled.
#### Screenshots
https://user-images.githubusercontent.com/29536522/187712014-c11971cb-1634-4287-a540-163eba57b83a.mov
https://user-images.githubusercontent.com/29536522/187713956-c98bf383-b42f-49b4-b82e-5684272f4a7a.mov
### Environment
(please complete the following information):
- browser type and version:
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
@michael-s-molina @kgabryje @villebro @lyndsiWilliams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #21271: Dataset creating issues in SQL Lab
URL: https://github.com/apache/superset/issues/21271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233736291
> I believe #21244 fixes the second issue mentioned
Yes, I check it out the second issue. It's fixed after this merged PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233473376
I believe https://github.com/apache/superset/pull/21244 fixes #2 issue mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1234487481
@EugeneTorap sure i can look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233332754
@diegomedina248 Can you take a look at these issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
yousoph commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233491976
For the first issue - looks like it happens if you use the same tab to try to save the dataset. If you refresh the SQL Lab tab, the error message appears properly. I think the modal shouldn't keep the previous name when it's closed and reopened - I think that might fix the problem? Would you be up to opening a PR for a fix @EugeneTorap ? (Thanks for the find, btw!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233736710
@AAfghahi Can you take a look at first issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #21271: Dataset creating issues in SQL Lab
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #21271:
URL: https://github.com/apache/superset/issues/21271#issuecomment-1233103707
@yousoph Should this get prioritized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org