You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/16 06:27:15 UTC

[GitHub] [arrow-datafusion] jorgecarleitao opened a new issue #1583: Object store's `sync_reader` should buffer

jorgecarleitao opened a new issue #1583:
URL: https://github.com/apache/arrow-datafusion/issues/1583


   Both https://github.com/apache/arrow-datafusion/issues/1363 and https://github.com/apache/arrow-datafusion/pull/1556 's performance regressions are/were driven by `sync_reader` returning `File` instead of `BufReader<File>`, suggesting that it is a confusing API. I also think that there is no practical reason to not buffer a file within Datafusion - my understanding is that not buffering is mostly useful in systems without `alloc`.
   
   Note that @Igosuki has a fix for #1556, here https://github.com/houqp/arrow-datafusion/pull/19/files#diff-45af7ea371f36434653f767a522a50aabf41bf34e4e11117103532363305793dL84, it is mostly a matter of porting it master.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org