[jira] [Commented] (ACCUMULO-3988) License / notice errors

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738946#comment-14738946 ] 

Josh Elser commented on ACCUMULO-3988:
--------------------------------------

bq. Hadoop (see note in Value.java. Hadoop's NOTICE file isn't properly formed, so could skip)

Perhaps I'm interpreting it differently than you, but the comment in Value reads to me that the "style" of the class is based on Hadoop's BytesWritable, not that the code was directly copied.

bq. problems with missing references still exist

"bin" meaning "binary tarball"? And "still exist" referring to the items you referenced for the "source tarball"?

bq. missing Thrift entry in NOTICE file expands from one file to java libthrift

I don't understand what "expands from one file to java libthrift" means.

bq. missing NOTICE for thrift class inclusion

Do you have the reference handy for this? It's a modification based on ASLv2 code. I thought code that is already ASLv2 doesn't require anything addt'l in the NOTICE.

> License / notice errors
> -----------------------
>
>                 Key: ACCUMULO-3988
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3988
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.5.4
>            Reporter: Sean Busbey
>            Assignee: Christopher Tubbs
>            Priority: Blocker
>
> latest 1.5.4 RC contains licensing errors. these might also be present in newer versions.
> source tarball
> * LICENSE refs bundled works that are not present: jline
> * LICENSE incorrectly cites bundled work: jquery and flot (no copyright, no text of license), bloom filters (no copyright, no text of license)
> * LICENSE misses some bundled works: 
> ** sizzle.js (see jquery.js file header)
> * NOTICE refs bundled works that are not present: jcommander
> * NOTICE misses some bundled works:
> ** Hadoop (see note in Value.java. Hadoop's NOTICE file isn't properly formed, so could skip)
> ** Thrift (see note in TNonblockingServerSocket. Thrift 0.9 has a NOTICE file.)
> bin
> * problems with missing references still exist
> * missing Thrift entry in NOTICE file expands from one file to java libthrift
> * nit: JCommander should say that it's ASLv2 licensed
> * LICENSE and NOTICE files not updated for commons-math inclusion
> * NOTICE file not updated for commons-vfs2 inclusion
> * LICENSE and NOTICE files not updated for jetty inclusion
> accumulo-server jar / source-jar
> * missing LICENSE reference for jquery/flot/sizle
> * missing NOTICE for hadoop inclusion (but see not above about maybe skipping)
> * missing NOTICE for thrift class inclusion
> accumulo-core jar / source-jar
> * missing LICENSE reference for bloom filters	
> all jars
> * nit: jars contain NOTICE file that doesn't state the full name of the aggregate work (e.g. "Core" rather than "Apache Accumulo Core" or some such)
> * jars contain NOTICE file that incorrectly states the aggregate work is copyright the Accumulo project instead of the ASF



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)