You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by zi...@apache.org on 2026/04/09 12:25:58 UTC
(dolphinscheduler) branch dev updated: [Improvement-18151] Simplify the code with lombok annotations (#18152)
This is an automated email from the ASF dual-hosted git repository.
zihaoxiang pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 01856e0ad3 [Improvement-18151] Simplify the code with lombok annotations (#18152)
01856e0ad3 is described below
commit 01856e0ad3a1764b9b1abd9b5b8804ec8e390821
Author: xiangzihao <46...@qq.com>
AuthorDate: Thu Apr 9 20:25:51 2026 +0800
[Improvement-18151] Simplify the code with lombok annotations (#18152)
---
.../plugin/alert/voice/VoiceParam.java | 35 +----
.../alert/voice/VoiceAlertChannelFactoryTest.java | 3 -
.../plugin/alert/voice/VoiceSenderTest.java | 3 -
.../alert/api/AlertChannelFactory.java | 3 -
.../dolphinscheduler/alert/api/AlertData.java | 3 -
.../dolphinscheduler/alert/api/AlertResult.java | 3 -
.../plugin/alert/script/ProcessUtilsTest.java | 3 -
.../script/ScriptAlertChannelFactoryTest.java | 3 -
.../plugin/alert/script/ScriptSenderTest.java | 3 -
.../plugin/alert/wechat/WechatAppChatMessage.java | 6 +-
.../plugin/alert/wechat/WechatAppMessage.java | 6 +-
.../wechat/WeChatAlertChannelFactoryTest.java | 3 -
.../plugin/alert/wechat/WeChatSenderTest.java | 3 -
.../dolphinscheduler/api/test/utils/JSONUtils.java | 6 -
.../api/audit/OperatorLogAspect.java | 6 +-
.../DynamicTaskTypeConfiguration.java | 6 +-
.../api/configuration/OAuth2Configuration.java | 9 +-
.../api/configuration/TaskTypeConfiguration.java | 6 +-
.../api/controller/AccessTokenController.java | 3 -
.../api/controller/AlertGroupController.java | 3 -
.../controller/AlertPluginInstanceController.java | 3 -
.../api/controller/BaseController.java | 3 -
.../api/controller/CloudController.java | 3 -
.../api/controller/ClusterController.java | 3 -
.../api/controller/DataAnalysisController.java | 3 -
.../api/controller/DataSourceController.java | 3 -
.../api/controller/DynamicTaskTypeController.java | 3 -
.../api/controller/EnvironmentController.java | 3 -
.../api/controller/ExecutorController.java | 3 -
.../api/controller/K8sNamespaceController.java | 3 -
.../api/controller/LoggerController.java | 3 -
.../api/controller/LoginController.java | 3 -
.../api/controller/MonitorController.java | 3 -
.../api/controller/ProjectController.java | 3 -
.../api/controller/QueueController.java | 3 -
.../api/controller/SchedulerController.java | 3 -
.../api/controller/TaskDefinitionController.java | 3 -
.../api/controller/TaskGroupController.java | 3 -
.../api/controller/TaskInstanceController.java | 3 -
.../api/controller/TenantController.java | 3 -
.../api/controller/UsersController.java | 3 -
.../controller/WorkflowDefinitionController.java | 3 -
.../api/controller/WorkflowInstanceController.java | 3 -
.../api/controller/WorkflowLineageController.java | 3 -
.../apache/dolphinscheduler/api/dto/AuditDto.java | 6 +-
.../api/dto/CommandStateCount.java | 57 +------
.../dolphinscheduler/api/dto/FavTaskDto.java | 6 +-
.../dolphinscheduler/api/dto/PageQueryDto.java | 3 -
.../dolphinscheduler/api/dto/ProductInfoDto.java | 3 -
.../dolphinscheduler/api/dto/ScheduleParam.java | 35 +----
.../dolphinscheduler/api/dto/gantt/Task.java | 72 +--------
.../api/dto/resources/Directory.java | 3 -
.../api/dto/resources/FileLeaf.java | 3 -
.../api/dto/resources/ResourceComponent.java | 21 ---
.../dto/resources/visitor/ResourceTreeVisitor.java | 6 -
.../api/dto/resources/visitor/Visitor.java | 3 -
.../api/dto/taskType/DynamicTaskInfo.java | 6 +-
.../api/dto/treeview/TreeViewDto.java | 61 +-------
.../dolphinscheduler/api/enums/ExecuteType.java | 3 -
.../api/permission/PermissionCheck.java | 32 +---
.../api/security/AuthenticationType.java | 3 -
.../api/security/LdapUserNotExistActionType.java | 3 -
.../api/service/AccessTokenService.java | 3 -
.../api/service/AlertGroupService.java | 3 -
.../api/service/AlertPluginInstanceService.java | 3 -
.../dolphinscheduler/api/service/BaseService.java | 3 -
.../api/service/ClusterService.java | 3 -
.../api/service/DataAnalysisService.java | 3 -
.../api/service/DataSourceService.java | 3 -
.../api/service/EnvironmentService.java | 3 -
.../EnvironmentWorkerGroupRelationService.java | 3 -
.../api/service/LoggerService.java | 3 -
.../api/service/MonitorService.java | 3 -
.../dolphinscheduler/api/service/QueueService.java | 3 -
.../api/service/TaskDefinitionService.java | 3 -
.../api/service/TaskGroupService.java | 3 -
.../api/service/UiPluginService.java | 3 -
.../dolphinscheduler/api/service/UsersService.java | 3 -
.../api/service/impl/AccessTokenServiceImpl.java | 3 -
.../api/service/impl/AlertGroupServiceImpl.java | 3 -
.../impl/AlertPluginInstanceServiceImpl.java | 3 -
.../api/service/impl/BaseServiceImpl.java | 3 -
.../api/service/impl/DataAnalysisServiceImpl.java | 3 -
.../api/service/impl/DataSourceServiceImpl.java | 3 -
.../api/service/impl/LoggerServiceImpl.java | 3 -
.../api/service/impl/MonitorServiceImpl.java | 3 -
.../api/service/impl/QueueServiceImpl.java | 3 -
.../service/impl/TaskDefinitionServiceImpl.java | 3 -
.../api/service/impl/TaskGroupServiceImpl.java | 3 -
.../api/service/impl/UiPluginServiceImpl.java | 3 -
.../api/service/impl/UsersServiceImpl.java | 3 -
.../dolphinscheduler/api/utils/CheckUtils.java | 3 -
.../dolphinscheduler/api/utils/PageInfo.java | 18 ---
.../apache/dolphinscheduler/api/utils/Result.java | 33 +---
.../api/vo/AlertPluginInstanceVO.java | 18 ---
.../api/controller/AbstractControllerTest.java | 3 -
.../api/controller/AccessTokenControllerTest.java | 3 -
.../api/controller/AlertGroupControllerTest.java | 3 -
.../AlertPluginInstanceControllerTest.java | 3 -
.../api/controller/AuditLogControllerTest.java | 3 -
.../api/controller/DataSourceControllerTest.java | 3 -
.../api/controller/K8sNamespaceControllerTest.java | 3 -
.../api/controller/LoggerControllerTest.java | 3 -
.../api/controller/LoginControllerTest.java | 3 -
.../api/controller/MonitorControllerTest.java | 3 -
.../api/controller/ProjectControllerTest.java | 3 -
.../api/controller/QueueControllerTest.java | 3 -
.../api/controller/UiPluginControllerTest.java | 3 -
.../api/controller/UsersControllerTest.java | 3 -
.../api/controller/WorkerGroupControllerTest.java | 3 -
.../resources/visitor/ResourceTreeVisitorTest.java | 3 -
.../api/service/AccessTokenServiceTest.java | 3 -
.../api/service/AlertGroupServiceTest.java | 3 -
.../service/AlertPluginInstanceServiceTest.java | 3 -
.../api/service/AuditServiceTest.java | 3 -
.../api/service/BaseServiceTest.java | 3 -
.../api/service/DataAnalysisServiceTest.java | 3 -
.../api/service/DataSourceServiceTest.java | 3 -
.../api/service/MonitorServiceTest.java | 3 -
.../api/service/QueueServiceTest.java | 3 -
.../api/service/SchedulerServiceTest.java | 3 -
.../api/service/SessionServiceTest.java | 3 -
.../api/service/TaskInstanceServiceTest.java | 3 -
.../api/service/UiPluginServiceTest.java | 3 -
.../api/service/UsersServiceTest.java | 3 -
.../api/service/impl/ClusterServiceTest.java | 3 -
.../api/service/impl/EnvironmentServiceTest.java | 3 -
.../ActuatorAuthenticationAutoConfiguration.java | 6 +-
.../common/constants/Constants.java | 117 --------------
.../common/enums/AuditModelType.java | 3 -
.../common/enums/AuditOperationType.java | 3 -
.../common/enums/ConditionType.java | 3 -
.../dolphinscheduler/common/enums/PluginType.java | 3 -
.../common/enums/TaskExecuteType.java | 3 -
.../dolphinscheduler/common/enums/TimeoutFlag.java | 3 -
.../dolphinscheduler/common/enums/UserType.java | 3 -
.../common/utils/EncryptionUtils.java | 3 -
.../dolphinscheduler/common/utils/JSONUtils.java | 6 -
.../common/utils/KerberosHttpClient.java | 3 -
.../utils/placeholder/BusinessTimeUtils.java | 3 -
.../org/apache/dolphinscheduler/dao/AlertDao.java | 27 +---
.../dolphinscheduler/dao/entity/AccessToken.java | 15 --
.../dolphinscheduler/dao/entity/AlertGroup.java | 15 --
.../dao/entity/AlertPluginInstance.java | 15 --
.../dao/entity/AlertSendStatus.java | 12 --
.../dolphinscheduler/dao/entity/AuditLog.java | 18 ---
.../dolphinscheduler/dao/entity/Command.java | 3 -
.../dolphinscheduler/dao/entity/CommandCount.java | 52 +------
.../dolphinscheduler/dao/entity/DataSource.java | 21 ---
.../dao/entity/DatasourceUser.java | 15 --
.../dao/entity/DependentSimplifyDefinition.java | 27 +---
.../dao/entity/EnvironmentWorkerGroupRelation.java | 3 -
.../dolphinscheduler/dao/entity/FavTask.java | 6 +-
.../dolphinscheduler/dao/entity/K8sNamespace.java | 12 --
.../dao/entity/K8sNamespaceUser.java | 15 --
.../dolphinscheduler/dao/entity/PluginDefine.java | 18 ---
.../dolphinscheduler/dao/entity/Project.java | 15 --
.../dolphinscheduler/dao/entity/ProjectUser.java | 12 --
.../dao/entity/ProjectWorkerGroup.java | 15 --
.../apache/dolphinscheduler/dao/entity/Queue.java | 12 --
.../dao/entity/RelationSubWorkflow.java | 3 -
.../dao/entity/TaskDefinition.java | 63 --------
.../dao/entity/TaskDefinitionLog.java | 6 -
.../dolphinscheduler/dao/entity/TaskMainInfo.java | 36 -----
.../apache/dolphinscheduler/dao/entity/Tenant.java | 24 ---
.../dolphinscheduler/dao/mapper/AlertMapper.java | 3 -
.../dolphinscheduler/dao/mapper/ClusterMapper.java | 3 -
.../dolphinscheduler/dao/mapper/CommandMapper.java | 3 -
.../dao/mapper/EnvironmentMapper.java | 3 -
.../EnvironmentWorkerGroupRelationMapper.java | 3 -
.../dao/mapper/ErrorCommandMapper.java | 3 -
.../dolphinscheduler/dao/mapper/ProjectMapper.java | 3 -
.../dao/mapper/ProjectUserMapper.java | 3 -
.../dolphinscheduler/dao/mapper/QueueMapper.java | 3 -
.../dao/mapper/TaskDefinitionLogMapper.java | 3 -
.../dao/mapper/TaskInstanceMapper.java | 3 -
.../dolphinscheduler/dao/mapper/TenantMapper.java | 3 -
.../dolphinscheduler/dao/mapper/UserMapper.java | 3 -
.../dao/mapper/WorkflowDefinitionLogMapper.java | 4 -
.../dao/mapper/WorkflowDefinitionMapper.java | 3 -
.../dao/mapper/WorkflowInstanceMapper.java | 3 -
.../dao/mapper/WorkflowTaskRelationMapper.java | 3 -
.../dao/repository/TaskDefinitionLogDao.java | 3 -
.../dao/repository/TaskInstanceDao.java | 3 -
.../dolphinscheduler/dao/utils/WorkflowUtils.java | 3 -
.../dao/mapper/AccessTokenMapperTest.java | 3 -
.../dao/mapper/AlertGroupMapperTest.java | 3 -
.../dao/mapper/AlertMapperTest.java | 3 -
.../dao/mapper/AlertSendStatusMapperTest.java | 3 -
.../dao/mapper/CommandMapperTest.java | 3 -
.../dao/mapper/DataSourceMapperTest.java | 6 -
.../api/constants/DataSourceConstants.java | 15 --
.../api/datasource/BaseDataSourceParamDTO.java | 75 +--------
.../api/datasource/BaseHDFSConnectionParam.java | 36 +----
.../api/datasource/BaseHDFSDataSourceParamDTO.java | 36 +----
.../plugin/datasource/api/utils/CommonUtils.java | 3 -
.../athena/param/AthenaConnectionParam.java | 13 +-
.../azuresql/param/AzureSQLConnectionParam.java | 8 +-
.../azuresql/param/AzureSQLDataSourceParamDTO.java | 8 +-
.../oracle/param/OracleConnectionParam.java | 13 +-
.../oracle/param/OracleDataSourceParamDTO.java | 13 +-
.../redshift/param/RedshiftConnectionParam.java | 8 +-
.../redshift/param/RedshiftDataSourceParamDTO.java | 8 +-
.../extract/base/config/NettyClientConfig.java | 9 --
.../extract/base/config/NettyServerConfig.java | 9 --
.../extract/base/future/InvokeCallback.java | 3 -
.../extract/base/future/ReleaseSemaphore.java | 3 -
.../extract/base/utils/ChannelUtils.java | 3 -
.../extract/base/utils/Constants.java | 9 --
.../extract/base/utils/NettyUtils.java | 3 -
.../extract/master/dto/WorkflowExecuteDto.java | 21 +--
.../task/runnable/TaskExecutionContextBuilder.java | 4 -
.../server/master/utils/DependentExecute.java | 15 --
.../service/command/CommandService.java | 3 -
.../service/cron/CycleFactory.java | 15 --
.../dolphinscheduler/service/model/TaskNode.java | 18 ---
.../service/cron/CronUtilsTest.java | 3 -
.../service/process/ProcessServiceTest.java | 3 -
.../dolphinscheduler/spi/enums/ResourceType.java | 3 -
.../spi/params/base/PluginParams.java | 3 -
.../spi/params/input/InputParamProps.java | 170 +--------------------
.../params/input/number/InputNumberParamProps.java | 66 +-------
.../spi/params/radio/RadioParamProps.java | 18 +--
.../spi/params/select/SelectParamProps.java | 132 +---------------
.../storage/api/constants/StorageConstants.java | 3 -
.../plugin/task/api/AbstractCommandExecutor.java | 3 -
.../plugin/task/api/K8sTaskExecutionContext.java | 3 -
.../plugin/task/api/SQLTaskExecutionContext.java | 39 +----
.../plugin/task/api/TaskConstants.java | 105 -------------
.../task/api/am/YarnApplicationManagerContext.java | 6 -
.../plugin/task/api/enums/TaskTimeoutStrategy.java | 3 -
.../plugin/task/api/enums/dp/ConnectorType.java | 3 -
.../plugin/task/api/enums/dp/ExecuteSqlType.java | 3 -
.../plugin/task/api/enums/dp/OperatorType.java | 3 -
.../plugin/task/api/enums/dp/RuleType.java | 3 -
.../plugin/task/api/log/TaskLogDiscriminator.java | 3 -
.../plugin/task/api/model/DateInterval.java | 41 +----
.../plugin/task/api/model/Property.java | 3 -
.../plugin/task/api/model/TaskAlertInfo.java | 27 +---
.../plugin/task/api/model/TaskResponse.java | 6 -
.../plugin/task/api/parameters/SqlParameters.java | 147 +-----------------
.../task/api/parameters/TaskTimeoutParameter.java | 3 -
.../plugin/task/api/parser/PlaceholderUtils.java | 3 -
.../task/api/parser/TimePlaceholderUtils.java | 3 -
.../plugin/task/api/utils/PropertyUtils.java | 3 -
.../plugin/task/chunjun/ChunJunConstants.java | 3 -
.../plugin/task/chunjun/ChunJunParameters.java | 15 +-
.../plugin/task/chunjun/ChunJunTask.java | 3 -
.../task/chunjun/ChunJunTaskChannelFactory.java | 3 -
.../task/datafactory/DatafactoryParameters.java | 6 +-
.../plugin/task/datasync/DatasyncParameters.java | 18 +--
.../plugin/task/datax/DataxParameters.java | 146 +-----------------
.../plugin/task/datax/DataxTask.java | 6 -
.../task/datax/DataxTaskExecutionContext.java | 69 +--------
.../plugin/task/dinky/DinkyParameters.java | 27 +---
.../dolphinscheduler/plugin/task/dms/DmsTask.java | 3 -
.../plugin/task/flink/FlinkStreamParameters.java | 3 -
.../plugin/task/flink/FlinkArgsUtils.java | 3 -
.../plugin/task/flink/FlinkDeployMode.java | 3 -
.../plugin/task/flink/FlinkParameters.java | 157 +------------------
.../plugin/task/flink/FlinkTask.java | 6 -
.../plugin/task/grpc/protobufjs/mapping/Field.java | 4 -
.../plugin/task/http/HttpCheckCondition.java | 3 -
.../plugin/task/http/HttpParametersType.java | 3 -
.../plugin/task/java/JavaParameters.java | 3 -
.../plugin/task/jupyter/JupyterConstants.java | 12 --
.../plugin/task/linkis/LinkisParameters.java | 5 +-
.../plugin/task/mr/MapReduceArgsUtils.java | 3 -
.../plugin/task/mr/MapReduceParameters.java | 76 +--------
.../plugin/task/openmldb/OpenmldbParameters.java | 35 +----
.../procedure/ProcedureTaskExecutionContext.java | 14 +-
.../plugin/task/python/PythonParameters.java | 22 +--
.../plugin/task/remoteshell/RemoteShellTask.java | 3 -
.../plugin/task/sagemaker/SagemakerParameters.java | 6 +-
.../sagemaker/SagemakerTaskExecutionContext.java | 14 +-
.../plugin/task/seatunnel/SeatunnelParameters.java | 9 +-
.../seatunnel/flink/SeatunnelFlinkParameters.java | 5 +-
.../seatunnel/self/SeatunnelEngineParameters.java | 8 +-
.../seatunnel/spark/SeatunnelSparkParameters.java | 7 +-
.../plugin/task/shell/ShellParameters.java | 6 +-
.../plugin/task/spark/SparkConstants.java | 9 --
.../plugin/task/spark/SparkParameters.java | 9 --
.../task/sqoop/SqoopTaskExecutionContext.java | 51 +------
.../generator/sources/HanaSourceGenerator.java | 3 -
.../generator/sources/MySQLSourceGenerator.java | 3 -
.../generator/sources/OracleSourceGenerator.java | 3 -
.../sources/SqlServerSourceGenerator.java | 3 -
.../generator/targets/HanaTargetGenerator.java | 3 -
.../generator/targets/HdfsTargetGenerator.java | 3 -
.../generator/targets/HiveTargetGenerator.java | 3 -
.../generator/targets/MySQLTargetGenerator.java | 3 -
.../generator/targets/OracleTargetGenerator.java | 3 -
.../targets/SqlServerTargetGenerator.java | 3 -
.../sqoop/parameter/SourceCommonParameter.java | 17 +--
.../task/sqoop/parameter/SqoopParameters.java | 123 +--------------
.../sqoop/parameter/TargetCommonParameter.java | 17 +--
.../parameter/sources/SourceHanaParameter.java | 95 +-----------
.../parameter/sources/SourceHdfsParameter.java | 18 +--
.../parameter/sources/SourceHiveParameter.java | 51 +------
.../parameter/sources/SourceMysqlParameter.java | 95 +-----------
.../parameter/sources/SourceOracleParameter.java | 95 +-----------
.../sources/SourceSqlServerParameter.java | 95 +-----------
.../parameter/targets/TargetHanaParameter.java | 27 ----
.../parameter/targets/TargetHdfsParameter.java | 71 +--------
.../parameter/targets/TargetHiveParameter.java | 106 +------------
.../parameter/targets/TargetMysqlParameter.java | 27 ----
.../parameter/targets/TargetOracleParameter.java | 27 ----
.../targets/TargetSqlServerParameter.java | 27 ----
.../plugin/task/sqoop/EntityTestUtils.java | 3 -
.../task/sqoop/SqoopParameterEntityTest.java | 3 -
.../plugin/task/zeppelin/ZeppelinParameters.java | 6 +-
.../zeppelin/ZeppelinTaskExecutionContext.java | 14 +-
312 files changed, 244 insertions(+), 4113 deletions(-)
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceParam.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceParam.java
index 2e07f54fd8..15eeebb843 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceParam.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/main/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceParam.java
@@ -22,53 +22,24 @@ import lombok.Data;
@Data
public class VoiceParam {
- /**
- * called Number
- */
private String calledNumber;
- /**
- * called Show Number
- */
+
private String calledShowNumber;
- /**
- * tts code
- */
+
private String ttsCode;
- /**
- * tts param
- */
+
private String ttsParam;
- /**
- * connection info
- */
private Connection connection;
- /**
- * outId
- */
private String outId;
@Data
public static class Connection {
- /**
- * address
- */
private String address;
-
- /**
- * accessKeyId
- */
private String accessKeyId;
- /**
- * accessKeySecret
- */
private String accessKeySecret;
-
- /**
- * tts Code
- */
private String ttsCode;
}
}
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertChannelFactoryTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertChannelFactoryTest.java
index 31df2cf70f..6eeffa2618 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertChannelFactoryTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceAlertChannelFactoryTest.java
@@ -26,9 +26,6 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-/**
- * VoiceAlertChannelFactoryTest
- */
class VoiceAlertChannelFactoryTest {
@Test
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceSenderTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceSenderTest.java
index ce8a8471f8..a28f91cc21 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceSenderTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-aliyunVoice/src/test/java/org/apache/dolphinscheduler/plugin/alert/voice/VoiceSenderTest.java
@@ -23,9 +23,6 @@ import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-/**
- * VoiceSenderTest
- */
class VoiceSenderTest {
private static VoiceParam voiceParam = new VoiceParam();
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertChannelFactory.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertChannelFactory.java
index 9a294f5770..4177999bcd 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertChannelFactory.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertChannelFactory.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.spi.plugin.SPIIdentify;
import java.util.List;
-/**
- * alert channel factory
- */
public interface AlertChannelFactory extends PrioritySPI {
/**
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java
index 1b218f8173..4058ac30c7 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java
@@ -22,9 +22,6 @@ import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;
-/**
- * alert data
- */
@AllArgsConstructor
@Builder
@Data
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertResult.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertResult.java
index aa4a0af4b0..ebd11cb04b 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertResult.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertResult.java
@@ -22,9 +22,6 @@ import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;
-/**
- * alert result
- */
@Builder
@AllArgsConstructor
@Data
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java
index 3d85d5d638..2f4e20b7ad 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ProcessUtilsTest.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.plugin.alert.script;
import org.junit.jupiter.api.Test;
-/**
- * ProcessUtilsTest
- */
public class ProcessUtilsTest {
private static final String rootPath = System.getProperty("user.dir");
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactoryTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactoryTest.java
index f9b7e338f6..9a16d3b4c8 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactoryTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptAlertChannelFactoryTest.java
@@ -25,9 +25,6 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-/**
- * ScriptAlertChannelFactoryTest
- */
public class ScriptAlertChannelFactoryTest {
@Test
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java
index c392b6f758..271aae2e6d 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-script/src/test/java/org/apache/dolphinscheduler/plugin/alert/script/ScriptSenderTest.java
@@ -28,9 +28,6 @@ import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-/**
- * ScriptSenderTest
- */
public class ScriptSenderTest {
private static final String rootPath = System.getProperty("user.dir");
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppChatMessage.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppChatMessage.java
index 349069ca4a..43332e0d71 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppChatMessage.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppChatMessage.java
@@ -21,12 +21,10 @@ import org.apache.dolphinscheduler.alert.api.ShowType;
import java.util.Map;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@Data
@NoArgsConstructor
public class WechatAppChatMessage {
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppMessage.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppMessage.java
index 5295167007..8440152cfa 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppMessage.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/main/java/org/apache/dolphinscheduler/plugin/alert/wechat/WechatAppMessage.java
@@ -21,12 +21,10 @@ import org.apache.dolphinscheduler.alert.api.ShowType;
import java.util.Map;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@Data
@NoArgsConstructor
public class WechatAppMessage {
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatAlertChannelFactoryTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatAlertChannelFactoryTest.java
index ab04a16a5c..53fb02015e 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatAlertChannelFactoryTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatAlertChannelFactoryTest.java
@@ -26,9 +26,6 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-/**
- * WeChatAlertChannelFactoryTest
- */
public class WeChatAlertChannelFactoryTest {
@Test
diff --git a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSenderTest.java b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSenderTest.java
index 6e4c318d13..9944a4afeb 100644
--- a/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSenderTest.java
+++ b/dolphinscheduler-alert/dolphinscheduler-alert-plugins/dolphinscheduler-alert-wechat/src/test/java/org/apache/dolphinscheduler/plugin/alert/wechat/WeChatSenderTest.java
@@ -28,9 +28,6 @@ import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-/**
- * WeChatSenderTest
- */
public class WeChatSenderTest {
private static Map<String, String> weChatConfig = new HashMap<>();
diff --git a/dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api/test/utils/JSONUtils.java b/dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api/test/utils/JSONUtils.java
index 3a25c927ff..b0d95a0845 100644
--- a/dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api/test/utils/JSONUtils.java
+++ b/dolphinscheduler-api-test/dolphinscheduler-api-test-case/src/test/java/org/apache/dolphinscheduler/api/test/utils/JSONUtils.java
@@ -56,9 +56,6 @@ import com.fasterxml.jackson.databind.node.ObjectNode;
import com.fasterxml.jackson.databind.node.TextNode;
import com.fasterxml.jackson.databind.type.CollectionType;
-/**
- * json utils
- */
public class JSONUtils {
private static final Logger logger = LoggerFactory.getLogger(JSONUtils.class);
@@ -364,9 +361,6 @@ public class JSONUtils {
}
- /**
- * json data deserializer
- */
public static class JsonDataDeserializer extends JsonDeserializer<String> {
@Override
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java
index aaf35d5b66..b212c10601 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java
@@ -28,8 +28,7 @@ import java.util.List;
import java.util.Map;
import lombok.AllArgsConstructor;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.extern.slf4j.Slf4j;
import org.aspectj.lang.JoinPoint;
@@ -107,8 +106,7 @@ public class OperatorLogAspect {
auditThreadLocal.remove();
}
- @Getter
- @Setter
+ @Data
@AllArgsConstructor
public static class AuditContext {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/DynamicTaskTypeConfiguration.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/DynamicTaskTypeConfiguration.java
index c151c3230c..0787468243 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/DynamicTaskTypeConfiguration.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/DynamicTaskTypeConfiguration.java
@@ -25,8 +25,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.extern.slf4j.Slf4j;
import org.springframework.boot.context.properties.ConfigurationProperties;
@@ -38,8 +37,7 @@ import org.springframework.stereotype.Component;
@EnableConfigurationProperties
@PropertySource(value = {"classpath:dynamic-task-type-config.yaml"}, factory = YamlPropertySourceFactory.class)
@ConfigurationProperties(prefix = "dynamic-task")
-@Getter
-@Setter
+@Data
@Slf4j
public class DynamicTaskTypeConfiguration {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/OAuth2Configuration.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/OAuth2Configuration.java
index 2e4394d8cc..632f0e49b2 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/OAuth2Configuration.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/OAuth2Configuration.java
@@ -20,15 +20,13 @@ package org.apache.dolphinscheduler.api.configuration;
import java.util.HashMap;
import java.util.Map;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.context.annotation.Configuration;
-@Getter
-@Setter
+@Data
@Configuration
@ConditionalOnProperty(prefix = "security.authentication.oauth2", name = "enable", havingValue = "true")
@ConfigurationProperties(prefix = "security.authentication.oauth2")
@@ -36,8 +34,7 @@ public class OAuth2Configuration {
private Map<String, OAuth2ClientProperties> provider = new HashMap<>();
- @Getter
- @Setter
+ @Data
public static class OAuth2ClientProperties {
private String authorizationUri;
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TaskTypeConfiguration.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TaskTypeConfiguration.java
index 09b5576f42..4d35172d7d 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TaskTypeConfiguration.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/configuration/TaskTypeConfiguration.java
@@ -26,8 +26,7 @@ import org.apache.commons.collections4.CollectionUtils;
import java.util.ArrayList;
import java.util.List;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.extern.slf4j.Slf4j;
import org.springframework.boot.context.properties.ConfigurationProperties;
@@ -39,8 +38,7 @@ import org.springframework.stereotype.Component;
@EnableConfigurationProperties
@PropertySource(value = {"classpath:task-type-config.yaml"}, factory = YamlPropertySourceFactory.class)
@ConfigurationProperties(prefix = "task")
-@Getter
-@Setter
+@Data
@Slf4j
public class TaskTypeConfiguration {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AccessTokenController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AccessTokenController.java
index 3e594dadbc..07a0763164 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AccessTokenController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AccessTokenController.java
@@ -56,9 +56,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * access token controller
- */
@Tag(name = "ACCESS_TOKEN_TAG")
@RestController
@RequestMapping("/access-tokens")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertGroupController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertGroupController.java
index 946fa7467c..b4319a4216 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertGroupController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertGroupController.java
@@ -59,9 +59,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * alert group controller
- */
@Tag(name = "ALERT_GROUP_TAG")
@RestController
@RequestMapping("/alert-groups")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceController.java
index faf56682f0..133791533e 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceController.java
@@ -61,9 +61,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * alert plugin instance controller
- */
@Tag(name = "ALERT_PLUGIN_INSTANCE_TAG")
@RestController
@RequestMapping("alert-plugin-instances")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
index 07807d8cbf..b025f5b7f7 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/BaseController.java
@@ -35,9 +35,6 @@ import java.util.Map;
import javax.servlet.http.HttpServletRequest;
-/**
- * base controller
- */
public class BaseController {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/CloudController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/CloudController.java
index 0dd8f0c037..9c0fe7b575 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/CloudController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/CloudController.java
@@ -44,9 +44,6 @@ import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * cloud controller
- */
@Tag(name = "CLOUD_TAG")
@RestController
@RequestMapping("/cloud")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ClusterController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ClusterController.java
index 3cae7afbda..d1236bc736 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ClusterController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ClusterController.java
@@ -54,9 +54,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * cluster controller
- */
@Tag(name = "CLUSTER_TAG")
@RestController
@RequestMapping("cluster")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java
index ee263b865f..b5b0ad8e3d 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataAnalysisController.java
@@ -55,9 +55,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * data analysis controller
- */
@Tag(name = "DATA_ANALYSIS_TAG")
@RestController
@RequestMapping("projects/analysis")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
index 6f643ab4b6..0b9187285f 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DataSourceController.java
@@ -72,9 +72,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * data source controller
- */
@Tag(name = "DATA_SOURCE_TAG")
@RestController
@RequestMapping("datasources")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DynamicTaskTypeController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DynamicTaskTypeController.java
index 128967a140..9aa350d8ea 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DynamicTaskTypeController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/DynamicTaskTypeController.java
@@ -43,9 +43,6 @@ import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * dynamic task type controller
- */
@Tag(name = "DYNAMIC_TASK_TYPE")
@RestController
@RequestMapping("/dynamic")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/EnvironmentController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/EnvironmentController.java
index 0520f5d075..810f511d8a 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/EnvironmentController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/EnvironmentController.java
@@ -52,9 +52,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * environment controller
- */
@Tag(name = "ENVIRONMENT_TAG")
@RestController
@RequestMapping("environment")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
index 2c1137878c..8106732343 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java
@@ -72,9 +72,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * executor controller
- */
@Tag(name = "EXECUTOR_TAG")
@RestController
@RequestMapping("projects/{projectCode}/executors")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java
index dbc48a9601..162a8aec20 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java
@@ -54,9 +54,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * k8s namespace controller
- */
@Tag(name = "K8S_NAMESPACE_TAG")
@RestController
@RequestMapping("/k8s-namespace")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoggerController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoggerController.java
index 4f6f732c66..f5ac4020c7 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoggerController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoggerController.java
@@ -45,9 +45,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * logger controller
- */
@Tag(name = "LOGGER_TAG")
@RestController
@RequestMapping("/log")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoginController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoginController.java
index 6bcd4834d6..059a696b1e 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoginController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/LoginController.java
@@ -79,9 +79,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * login controller
- */
@Tag(name = "LOGIN_TAG")
@RestController
@RequestMapping("")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/MonitorController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/MonitorController.java
index be714032cc..3ae1c78a20 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/MonitorController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/MonitorController.java
@@ -44,9 +44,6 @@ import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * monitor controller
- */
@Tag(name = "MONITOR_TAG")
@RestController
@RequestMapping("/monitor")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectController.java
index ecec69622a..719bbdb427 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProjectController.java
@@ -58,9 +58,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * project controller
- */
@Tag(name = "PROJECT_TAG")
@RestController
@RequestMapping("projects")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/QueueController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/QueueController.java
index 4e69dede6f..8af9310d53 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/QueueController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/QueueController.java
@@ -55,9 +55,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * queue controller
- */
@Tag(name = "QUEUE_TAG")
@RestController
@RequestMapping("/queues")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java
index 30c489d216..ec5ce9f15c 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java
@@ -60,9 +60,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * scheduler controller
- */
@Tag(name = "SCHEDULE_TAG")
@RestController
@RequestMapping("/projects/{projectCode}/schedules")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskDefinitionController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskDefinitionController.java
index f21ed57a1d..563ff11722 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskDefinitionController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskDefinitionController.java
@@ -55,9 +55,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * task definition controller
- */
@Tag(name = "TASK_DEFINITION_TAG")
@RestController
@RequestMapping("projects/{projectCode}/task-definition")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
index 3fb5ec4e01..9a4c16b8f1 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskGroupController.java
@@ -51,9 +51,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * task group controller
- */
@Tag(name = "TASK_GROUP_TAG")
@RestController
@RequestMapping("/task-group")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
index d5f41c6aa1..6ca1d7b349 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TaskInstanceController.java
@@ -50,9 +50,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * task instance controller
- */
@Tag(name = "TASK_INSTANCE_TAG")
@RestController
@RequestMapping("/projects/{projectCode}/task-instances")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
index 4528024d10..2a390224a3 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/TenantController.java
@@ -56,9 +56,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * tenant controller
- */
@Tag(name = "TENANT_TAG")
@RestController
@RequestMapping("/tenants")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UsersController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UsersController.java
index 546ec675c9..391ece2a66 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UsersController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/UsersController.java
@@ -64,9 +64,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * users controller
- */
@Tag(name = "USERS_TAG")
@RestController
@RequestMapping("/users")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowDefinitionController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowDefinitionController.java
index d41ce9e12f..0506289111 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowDefinitionController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowDefinitionController.java
@@ -72,9 +72,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * workflow definition controller
- */
@Tag(name = "WORKFLOW_DEFINITION_TAG")
@RestController
@RequestMapping("projects/{projectCode}/workflow-definition")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceController.java
index bd7fb4619b..76101f4657 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceController.java
@@ -62,9 +62,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * workflow instance controller
- */
@Tag(name = "WORKFLOW_INSTANCE_TAG")
@RestController
@RequestMapping("/projects/{projectCode}/workflow-instances")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowLineageController.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowLineageController.java
index 58bb10e05b..c5e87baa4e 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowLineageController.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowLineageController.java
@@ -57,9 +57,6 @@ import io.swagger.v3.oas.annotations.Parameters;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.tags.Tag;
-/**
- * work flow lineage controller
- */
@Tag(name = "WORK_FLOW_LINEAGE_TAG")
@RestController
@RequestMapping("projects/{projectCode}/lineages")
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/AuditDto.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/AuditDto.java
index 0b36325b44..b1a918e991 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/AuditDto.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/AuditDto.java
@@ -19,11 +19,9 @@ package org.apache.dolphinscheduler.api.dto;
import java.util.Date;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
-@Getter
-@Setter
+@Data
public class AuditDto {
private String userName;
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/CommandStateCount.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/CommandStateCount.java
index b1b0eb66c9..bfbea85361 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/CommandStateCount.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/CommandStateCount.java
@@ -19,9 +19,9 @@ package org.apache.dolphinscheduler.api.dto;
import org.apache.dolphinscheduler.common.enums.CommandType;
-/**
- * command state count
- */
+import lombok.Data;
+
+@Data
public class CommandStateCount {
private int errorCount;
@@ -37,55 +37,4 @@ public class CommandStateCount {
this.commandState = commandState;
}
- public int getErrorCount() {
- return errorCount;
- }
-
- public void setErrorCount(int errorCount) {
- this.errorCount = errorCount;
- }
-
- public int getNormalCount() {
- return normalCount;
- }
-
- public void setNormalCount(int normalCount) {
- this.normalCount = normalCount;
- }
-
- public CommandType getCommandState() {
- return commandState;
- }
-
- public void setCommandState(CommandType commandState) {
- this.commandState = commandState;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
-
- CommandStateCount that = (CommandStateCount) o;
-
- if (errorCount != that.errorCount) {
- return false;
- }
- if (normalCount != that.normalCount) {
- return false;
- }
- return commandState == that.commandState;
- }
-
- @Override
- public int hashCode() {
- int result = errorCount;
- result = 31 * result + normalCount;
- result = 31 * result + (commandState != null ? commandState.hashCode() : 0);
- return result;
- }
}
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/FavTaskDto.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/FavTaskDto.java
index 9c88225e6e..9057e89fd0 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/FavTaskDto.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/FavTaskDto.java
@@ -18,13 +18,11 @@
package org.apache.dolphinscheduler.api.dto;
import lombok.AllArgsConstructor;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
@NoArgsConstructor
-@Getter
-@Setter
+@Data
@AllArgsConstructor
public class FavTaskDto implements Cloneable {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/PageQueryDto.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/PageQueryDto.java
index 149bf0548f..eaf4415097 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/PageQueryDto.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/PageQueryDto.java
@@ -20,9 +20,6 @@ package org.apache.dolphinscheduler.api.dto;
import lombok.Data;
import io.swagger.v3.oas.annotations.media.Schema;
-/**
- * page query dto
- */
@Schema(name = "QUERY-PAGE-INFO")
@Data
public class PageQueryDto {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ProductInfoDto.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ProductInfoDto.java
index e79d721e92..985a507a87 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ProductInfoDto.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ProductInfoDto.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.api.dto;
import lombok.Data;
-/**
- * ProductInfoDto
- */
@Data
public class ProductInfoDto {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java
index a3c4f08d8a..88fd4ea966 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/ScheduleParam.java
@@ -19,9 +19,12 @@ package org.apache.dolphinscheduler.api.dto;
import java.util.Date;
+import lombok.Data;
+
/**
* schedule parameters
*/
+@Data
public class ScheduleParam {
private Date startTime;
@@ -39,38 +42,6 @@ public class ScheduleParam {
this.crontab = crontab;
}
- public Date getStartTime() {
- return startTime;
- }
-
- public void setStartTime(Date startTime) {
- this.startTime = startTime;
- }
-
- public Date getEndTime() {
- return endTime;
- }
-
- public void setEndTime(Date endTime) {
- this.endTime = endTime;
- }
-
- public String getCrontab() {
- return crontab;
- }
-
- public void setCrontab(String crontab) {
- this.crontab = crontab;
- }
-
- public String getTimezoneId() {
- return timezoneId;
- }
-
- public void setTimezoneId(String timezoneId) {
- this.timezoneId = timezoneId;
- }
-
@Override
public String toString() {
return "ScheduleParam{"
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
index 5370f61e8a..147ff038fd 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/gantt/Task.java
@@ -21,14 +21,11 @@ import java.util.Date;
import java.util.LinkedList;
import java.util.List;
-/**
- * Task
- */
+import lombok.Data;
+
+@Data
public class Task {
- /**
- * task name
- */
private String taskName;
/**
@@ -65,67 +62,4 @@ public class Task {
*/
private String duration;
- public String getTaskName() {
- return taskName;
- }
-
- public void setTaskName(String taskName) {
- this.taskName = taskName;
- }
-
- public List<Long> getStartDate() {
- return startDate;
- }
-
- public void setStartDate(List<Long> startDate) {
- this.startDate = startDate;
- }
-
- public List<Long> getEndDate() {
- return endDate;
- }
-
- public void setEndDate(List<Long> endDate) {
- this.endDate = endDate;
- }
-
- public Date getExecutionDate() {
- return executionDate;
- }
-
- public void setExecutionDate(Date executionDate) {
- this.executionDate = executionDate;
- }
-
- public Date getIsoStart() {
- return isoStart;
- }
-
- public void setIsoStart(Date isoStart) {
- this.isoStart = isoStart;
- }
-
- public Date getIsoEnd() {
- return isoEnd;
- }
-
- public void setIsoEnd(Date isoEnd) {
- this.isoEnd = isoEnd;
- }
-
- public String getStatus() {
- return status;
- }
-
- public void setStatus(String status) {
- this.status = status;
- }
-
- public String getDuration() {
- return duration;
- }
-
- public void setDuration(String duration) {
- this.duration = duration;
- }
}
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/Directory.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/Directory.java
index c6147696ec..87f61a106d 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/Directory.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/Directory.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.api.dto.resources;
-/**
- * directory
- */
public class Directory extends ResourceComponent {
@Override
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/FileLeaf.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/FileLeaf.java
index 6fe0fe471d..5b04fee6f5 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/FileLeaf.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/FileLeaf.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.api.dto.resources;
-/**
- * file leaf
- */
public class FileLeaf extends ResourceComponent {
}
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/ResourceComponent.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/ResourceComponent.java
index 2aa11a6ce9..defdc58fa8 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/ResourceComponent.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/ResourceComponent.java
@@ -25,41 +25,20 @@ import java.util.List;
import lombok.Data;
import lombok.NoArgsConstructor;
-/**
- * resource component
- */
@Data
@NoArgsConstructor
public abstract class ResourceComponent {
- /**
- * name
- */
protected String name;
- /**
- * current directory
- */
protected String currentDir;
- /**
- * full name
- */
protected String fullName;
- /**
- * description
- */
protected String description;
- /**
- * is directory
- */
protected boolean isDirctory;
/**
* resoruce type
*/
protected ResourceType type;
- /**
- * children
- */
protected List<ResourceComponent> children = new ArrayList<>();
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java
index f7f93e780d..98d1cb1c22 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitor.java
@@ -26,14 +26,8 @@ import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
-/**
- * resource tree visitor
- */
public class ResourceTreeVisitor implements Visitor {
- /**
- * resource list
- */
private List<StorageEntity> resourceList;
public ResourceTreeVisitor() {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/Visitor.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/Visitor.java
index 1792b2769c..21ba4acf73 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/Visitor.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/visitor/Visitor.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.api.dto.resources.visitor;
import org.apache.dolphinscheduler.api.dto.resources.ResourceComponent;
-/**
- * Visitor
- */
public interface Visitor {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/taskType/DynamicTaskInfo.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/taskType/DynamicTaskInfo.java
index 22a652e8a7..a7943aa29c 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/taskType/DynamicTaskInfo.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/taskType/DynamicTaskInfo.java
@@ -18,13 +18,11 @@
package org.apache.dolphinscheduler.api.dto.taskType;
import lombok.AllArgsConstructor;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
@NoArgsConstructor
-@Getter
-@Setter
+@Data
@AllArgsConstructor
public class DynamicTaskInfo {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/treeview/TreeViewDto.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/treeview/TreeViewDto.java
index 8645bf30b6..561c3cbc40 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/treeview/TreeViewDto.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/treeview/TreeViewDto.java
@@ -20,74 +20,19 @@ package org.apache.dolphinscheduler.api.dto.treeview;
import java.util.ArrayList;
import java.util.List;
-/**
- * TreeView
- */
+import lombok.Data;
+
+@Data
public class TreeViewDto {
- /**
- * name
- */
private String name;
- /**
- * type
- */
private String type;
- /**
- * code
- */
private long code;
- /**
- * instances list
- */
-
private List<Instance> instances = new ArrayList<>();
- /**
- * children
- */
private List<TreeViewDto> children = new ArrayList<>();
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getType() {
- return type;
- }
-
- public void setType(String type) {
- this.type = type;
- }
-
- public long getCode() {
- return code;
- }
-
- public void setCode(long code) {
- this.code = code;
- }
-
- public List<Instance> getInstances() {
- return instances;
- }
-
- public void setInstances(List<Instance> instances) {
- this.instances = instances;
- }
-
- public List<TreeViewDto> getChildren() {
- return children;
- }
-
- public void setChildren(List<TreeViewDto> children) {
- this.children = children;
- }
}
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java
index c6f9933d19..cfae637be2 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/ExecuteType.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.api.enums;
-/**
- * execute type
- */
public enum ExecuteType {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/PermissionCheck.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/PermissionCheck.java
index 0699c7df9b..aa428c9095 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/PermissionCheck.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/PermissionCheck.java
@@ -27,23 +27,22 @@ import org.apache.commons.collections4.CollectionUtils;
import java.util.List;
+import lombok.Getter;
+import lombok.Setter;
+
import org.slf4j.Logger;
public class PermissionCheck<T> {
- /**
- * logger
- */
private Logger logger;
- /**
- * Authorization Type
- */
private AuthorizationType authorizationType;
/**
* Authorization Type
*/
+ @Getter
+ @Setter
private ProcessService processService;
/**
@@ -51,9 +50,8 @@ public class PermissionCheck<T> {
*/
private T[] needChecks;
- /**
- * user id
- */
+ @Getter
+ @Setter
private int userId;
public PermissionCheck(AuthorizationType authorizationType, ProcessService processService, T[] needChecks,
@@ -65,22 +63,6 @@ public class PermissionCheck<T> {
this.logger = logger;
}
- public ProcessService getProcessService() {
- return processService;
- }
-
- public void setProcessService(ProcessService processService) {
- this.processService = processService;
- }
-
- public int getUserId() {
- return userId;
- }
-
- public void setUserId(int userId) {
- this.userId = userId;
- }
-
/**
* check permission
*
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/AuthenticationType.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/AuthenticationType.java
index 9fe35b2610..3793d26ce8 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/AuthenticationType.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/AuthenticationType.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.api.security;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * authentication type
- */
public enum AuthenticationType {
PASSWORD(0, "verify via user name and password"),
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/LdapUserNotExistActionType.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/LdapUserNotExistActionType.java
index 1e96ef2954..bd5bbe3f6c 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/LdapUserNotExistActionType.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/LdapUserNotExistActionType.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.api.security;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * ldap user not exist action type
- */
public enum LdapUserNotExistActionType {
CREATE(0, "automatically create user when user not exist"),
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
index 9322163620..8c862b41be 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AccessTokenService.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
-/**
- * access token service
- */
public interface AccessTokenService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertGroupService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertGroupService.java
index 99b577db0b..b55568431c 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertGroupService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertGroupService.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
-/**
- * alert group service
- */
public interface AlertGroupService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceService.java
index b677e5a04c..0297c13acb 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceService.java
@@ -24,9 +24,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
-/**
- * alert plugin instance service
- */
public interface AlertPluginInstanceService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/BaseService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/BaseService.java
index 234e163c99..71c4814a45 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/BaseService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/BaseService.java
@@ -26,9 +26,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.Date;
import java.util.Map;
-/**
- * base service
- */
public interface BaseService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ClusterService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ClusterService.java
index 01d5e1bec1..d8a04df4e8 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ClusterService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ClusterService.java
@@ -24,9 +24,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
-/**
- * cluster service
- */
public interface ClusterService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataAnalysisService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataAnalysisService.java
index 8c6fe1052c..090e7aeb5d 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataAnalysisService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataAnalysisService.java
@@ -29,9 +29,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
import java.util.Map;
-/**
- * data analysis service
- */
public interface DataAnalysisService {
TaskInstanceCountVO getTaskInstanceStateCountByProject(User loginUser,
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
index b7426ce557..5546d91e04 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java
@@ -28,9 +28,6 @@ import org.apache.dolphinscheduler.spi.params.base.ParamsOptions;
import java.util.List;
-/**
- * datasource service
- */
public interface DataSourceService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentService.java
index c2a2511f21..de694f7bd0 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentService.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.Map;
-/**
- * environment service
- */
public interface EnvironmentService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentWorkerGroupRelationService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentWorkerGroupRelationService.java
index 4d22814e5f..bbb70669d6 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentWorkerGroupRelationService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/EnvironmentWorkerGroupRelationService.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.api.service;
import java.util.Map;
-/**
- * environment worker group relation service
- */
public interface EnvironmentWorkerGroupRelationService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/LoggerService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/LoggerService.java
index fe94f7ec43..a31b73eefc 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/LoggerService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/LoggerService.java
@@ -21,9 +21,6 @@ import org.apache.dolphinscheduler.api.utils.Result;
import org.apache.dolphinscheduler.dao.entity.ResponseTaskLog;
import org.apache.dolphinscheduler.dao.entity.User;
-/**
- * logger service
- */
public interface LoggerService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/MonitorService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/MonitorService.java
index f054fafdce..7c0e2d0bf9 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/MonitorService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/MonitorService.java
@@ -24,9 +24,6 @@ import org.apache.dolphinscheduler.registry.api.enums.RegistryNodeType;
import java.util.List;
-/**
- * monitor service
- */
public interface MonitorService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/QueueService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/QueueService.java
index 0cafe70d5e..ff346ee41b 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/QueueService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/QueueService.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.List;
-/**
- * queue service
- */
public interface QueueService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskDefinitionService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskDefinitionService.java
index 05343c736d..f5a3e8aac1 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskDefinitionService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskDefinitionService.java
@@ -24,9 +24,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.Map;
-/**
- * task definition service
- */
public interface TaskDefinitionService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskGroupService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskGroupService.java
index 885e23cf70..d01a527fd1 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskGroupService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/TaskGroupService.java
@@ -21,9 +21,6 @@ import org.apache.dolphinscheduler.dao.entity.User;
import java.util.Map;
-/**
- * task group service
- */
public interface TaskGroupService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UiPluginService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UiPluginService.java
index c959de5ec1..ee6c4c7e2e 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UiPluginService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UiPluginService.java
@@ -22,9 +22,6 @@ import org.apache.dolphinscheduler.common.enums.PluginType;
import java.util.Map;
-/**
- * ui plugin service
- */
public interface UiPluginService {
Map<String, Object> queryUiPluginsByType(PluginType pluginType);
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java
index a3bc375f71..cb048d0ce7 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java
@@ -25,9 +25,6 @@ import java.io.IOException;
import java.util.List;
import java.util.Map;
-/**
- * users service
- */
public interface UsersService {
/**
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AccessTokenServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AccessTokenServiceImpl.java
index ebb151c604..528eb385fe 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AccessTokenServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AccessTokenServiceImpl.java
@@ -46,9 +46,6 @@ import org.springframework.stereotype.Service;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * access token service impl
- */
@Service
@Slf4j
public class AccessTokenServiceImpl extends BaseServiceImpl implements AccessTokenService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertGroupServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertGroupServiceImpl.java
index e01585881c..b547be84c2 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertGroupServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertGroupServiceImpl.java
@@ -52,9 +52,6 @@ import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * alert group service impl
- */
@Service
@Slf4j
public class AlertGroupServiceImpl extends BaseServiceImpl implements AlertGroupService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java
index 1b69c19294..9676931ba7 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/AlertPluginInstanceServiceImpl.java
@@ -66,9 +66,6 @@ import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * alert plugin instance service impl
- */
@Service
@Lazy
@Slf4j
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/BaseServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/BaseServiceImpl.java
index 8c256be6bb..7f09cb0b9a 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/BaseServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/BaseServiceImpl.java
@@ -39,9 +39,6 @@ import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
-/**
- * base service impl
- */
@Slf4j
public class BaseServiceImpl implements BaseService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataAnalysisServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataAnalysisServiceImpl.java
index 5c99eb90e8..066946d458 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataAnalysisServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataAnalysisServiceImpl.java
@@ -65,9 +65,6 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.google.common.collect.Lists;
-/**
- * data analysis service impl
- */
@Service
@Slf4j
public class DataAnalysisServiceImpl extends BaseServiceImpl implements DataAnalysisService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
index fbe01b2bc2..36dc882ea8 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java
@@ -67,9 +67,6 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.fasterxml.jackson.databind.node.ObjectNode;
-/**
- * data source service impl
- */
@Service
@Slf4j
public class DataSourceServiceImpl extends BaseServiceImpl implements DataSourceService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java
index a0b3b35fc1..44a9127507 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java
@@ -47,9 +47,6 @@ import org.springframework.stereotype.Service;
import com.google.common.primitives.Bytes;
-/**
- * logger service impl
- */
@Service
@Slf4j
public class LoggerServiceImpl extends BaseServiceImpl implements LoggerService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/MonitorServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/MonitorServiceImpl.java
index 24bfcc5b25..79912e9398 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/MonitorServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/MonitorServiceImpl.java
@@ -34,9 +34,6 @@ import org.springframework.stereotype.Service;
import com.google.common.collect.Lists;
-/**
- * monitor service impl
- */
@Service
@Slf4j
public class MonitorServiceImpl extends BaseServiceImpl implements MonitorService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java
index 41338e3436..e922eb36b6 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java
@@ -52,9 +52,6 @@ import org.springframework.stereotype.Service;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * queue service impl
- */
@Service
@Slf4j
public class QueueServiceImpl extends BaseServiceImpl implements QueueService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
index 9ee45ee442..9dd86ba32e 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
@@ -84,9 +84,6 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.google.common.collect.Lists;
-/**
- * task definition service impl
- */
@Service
@Slf4j
public class TaskDefinitionServiceImpl extends BaseServiceImpl implements TaskDefinitionService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
index 379c629ea6..9ab8d81ee4 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskGroupServiceImpl.java
@@ -55,9 +55,6 @@ import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * task Group Service
- */
@Service
@Slf4j
public class TaskGroupServiceImpl extends BaseServiceImpl implements TaskGroupService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UiPluginServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UiPluginServiceImpl.java
index 6cd7526cfe..2f897ba3d1 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UiPluginServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UiPluginServiceImpl.java
@@ -40,9 +40,6 @@ import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
-/**
- * ui plugin service impl
- */
@Service
@Slf4j
public class UiPluginServiceImpl extends BaseServiceImpl implements UiPluginService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java
index e706be2a37..ec112ef554 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java
@@ -73,9 +73,6 @@ import org.springframework.transaction.annotation.Transactional;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * users service impl
- */
@Service
@Slf4j
public class UsersServiceImpl extends BaseServiceImpl implements UsersService {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
index 43f6eb8954..4d0be6c4db 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
@@ -30,9 +30,6 @@ import java.util.regex.Pattern;
import org.hibernate.validator.internal.constraintvalidators.bv.EmailValidator;
-/**
- * check utils
- */
public class CheckUtils {
private CheckUtils() {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
index 85e47c96b9..4fce32d874 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java
@@ -32,30 +32,12 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
@AllArgsConstructor
public class PageInfo<T> {
- /**
- * totalList
- */
private List<T> totalList = Collections.emptyList();
- /**
- * total
- */
private Integer total = 0;
- /**
- * total Page
- */
@Setter
private Integer totalPage;
- /**
- * page size
- */
private Integer pageSize = 20;
- /**
- * current page
- */
private Integer currentPage = 0;
- /**
- * pageNo
- */
private Integer pageNo;
public PageInfo() {
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/Result.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/Result.java
index d83ce0771b..d37d7a8333 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/Result.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/Result.java
@@ -21,11 +21,14 @@ import org.apache.dolphinscheduler.api.enums.Status;
import java.text.MessageFormat;
+import lombok.Data;
+
/**
* result
*
* @param <T> T
*/
+@Data
public class Result<T> {
/**
@@ -33,14 +36,8 @@ public class Result<T> {
*/
private Integer code;
- /**
- * message
- */
private String msg;
- /**
- * data
- */
private T data;
public Result() {
@@ -112,30 +109,6 @@ public class Result<T> {
return new Result<>(status.getCode(), MessageFormat.format(status.getMsg(), args));
}
- public Integer getCode() {
- return code;
- }
-
- public void setCode(Integer code) {
- this.code = code;
- }
-
- public String getMsg() {
- return msg;
- }
-
- public void setMsg(String msg) {
- this.msg = msg;
- }
-
- public T getData() {
- return data;
- }
-
- public void setData(T data) {
- this.data = data;
- }
-
@Override
public String toString() {
return "Status{"
diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo/AlertPluginInstanceVO.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo/AlertPluginInstanceVO.java
index 1b533350ab..ad3887659c 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo/AlertPluginInstanceVO.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/vo/AlertPluginInstanceVO.java
@@ -24,14 +24,8 @@ import lombok.Data;
@Data
public class AlertPluginInstanceVO {
- /**
- * id
- */
private int id;
- /**
- * plugin_define_id
- */
private int pluginDefineId;
/**
@@ -49,23 +43,11 @@ public class AlertPluginInstanceVO {
*/
private String warningType;
- /**
- * plugin_instance_params
- */
private String pluginInstanceParams;
- /**
- * create_time
- */
private Date createTime;
- /**
- * update_time
- */
private Date updateTime;
- /**
- * alert plugin name
- */
private String alertPluginName;
}
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AbstractControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AbstractControllerTest.java
index 6fbb890be7..b5b529dccb 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AbstractControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AbstractControllerTest.java
@@ -46,9 +46,6 @@ import org.springframework.context.annotation.Configuration;
import org.springframework.test.annotation.DirtiesContext;
import org.springframework.test.web.servlet.MockMvc;
-/**
- * abstract controller test
- */
@SpringBootTest(classes = {ApiApplicationServer.class, DaoConfiguration.class, RegistryServer.class})
@AutoConfigureMockMvc
@DirtiesContext
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AccessTokenControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AccessTokenControllerTest.java
index 9114daa04f..7f65728264 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AccessTokenControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AccessTokenControllerTest.java
@@ -37,9 +37,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * access token controller test
- */
public class AccessTokenControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(AccessTokenControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertGroupControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertGroupControllerTest.java
index f0bbd09cb6..6aac8c3d8f 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertGroupControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertGroupControllerTest.java
@@ -45,9 +45,6 @@ import org.springframework.util.MultiValueMap;
import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
-/**
- * alert group controller test
- */
public class AlertGroupControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(AlertGroupController.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceControllerTest.java
index 2151e938b7..3cb50c5a31 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AlertPluginInstanceControllerTest.java
@@ -46,9 +46,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * alert plugin instance controller test
- */
public class AlertPluginInstanceControllerTest extends AbstractControllerTest {
private static AlertPluginInstance alertPluginInstance = new AlertPluginInstance();
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AuditLogControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AuditLogControllerTest.java
index c5eb6c9eef..9ab99ed6e9 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AuditLogControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/AuditLogControllerTest.java
@@ -34,9 +34,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * audit log controller test
- */
public class AuditLogControllerTest extends AbstractControllerTest {
private static Logger logger = LoggerFactory.getLogger(AuditLogControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/DataSourceControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/DataSourceControllerTest.java
index dacd61ea76..c301d65505 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/DataSourceControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/DataSourceControllerTest.java
@@ -44,9 +44,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * data source controller test
- */
public class DataSourceControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(DataSourceControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceControllerTest.java
index e744d91407..02b629c368 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceControllerTest.java
@@ -36,9 +36,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * k8s namespace controller test
- */
public class K8sNamespaceControllerTest extends AbstractControllerTest {
private static final String NAMESPACE_CREATE_STRING = "namespace1";
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoggerControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoggerControllerTest.java
index ac699683be..6ee2854aad 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoggerControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoggerControllerTest.java
@@ -35,9 +35,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * logger controller test
- */
@Disabled
public class LoggerControllerTest extends AbstractControllerTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoginControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoginControllerTest.java
index aca9c0d19b..57fb1076df 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoginControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/LoginControllerTest.java
@@ -75,9 +75,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * login controller test
- */
public class LoginControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(LoginControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/MonitorControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/MonitorControllerTest.java
index 93dc48b80c..d74f71af5f 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/MonitorControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/MonitorControllerTest.java
@@ -32,9 +32,6 @@ import org.slf4j.LoggerFactory;
import org.springframework.http.MediaType;
import org.springframework.test.web.servlet.MvcResult;
-/**
- * monitor controller test
- */
public class MonitorControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(MonitorControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java
index e14cd5ac38..147cdd09c1 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java
@@ -39,9 +39,6 @@ import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
-/**
- * project controller test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class ProjectControllerTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/QueueControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/QueueControllerTest.java
index 0ddd7ad84b..526f2dd5c1 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/QueueControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/QueueControllerTest.java
@@ -37,9 +37,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * queue controller test
- */
public class QueueControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(QueueControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UiPluginControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UiPluginControllerTest.java
index 47f9db9955..b1fd7fe222 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UiPluginControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UiPluginControllerTest.java
@@ -44,9 +44,6 @@ import org.springframework.util.MultiValueMap;
import com.google.common.collect.ImmutableMap;
-/**
- * ui plugin controller test
- */
public class UiPluginControllerTest extends AbstractControllerTest {
private static final PluginType pluginType = PluginType.ALERT;
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UsersControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UsersControllerTest.java
index 303d4735bc..5668765a04 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UsersControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/UsersControllerTest.java
@@ -39,9 +39,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * users controller test
- */
public class UsersControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(UsersControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/WorkerGroupControllerTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/WorkerGroupControllerTest.java
index 6153648383..b330d6215f 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/WorkerGroupControllerTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/WorkerGroupControllerTest.java
@@ -46,9 +46,6 @@ import org.springframework.test.web.servlet.MvcResult;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
-/**
- * worker group controller test
- */
public class WorkerGroupControllerTest extends AbstractControllerTest {
private static final Logger logger = LoggerFactory.getLogger(WorkerGroupControllerTest.class);
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitorTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitorTest.java
index 3fe246ff4e..8c2400524f 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitorTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/visitor/ResourceTreeVisitorTest.java
@@ -26,9 +26,6 @@ import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-/**
- * resource tree visitor test
- */
public class ResourceTreeVisitorTest {
@Test
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AccessTokenServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AccessTokenServiceTest.java
index 175394b606..354b5985f9 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AccessTokenServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AccessTokenServiceTest.java
@@ -60,9 +60,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * access token service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class AccessTokenServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java
index 99acaab580..3cdab81a92 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertGroupServiceTest.java
@@ -60,9 +60,6 @@ import org.springframework.dao.DuplicateKeyException;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * alert group service test
- */
@ExtendWith(MockitoExtension.class)
public class AlertGroupServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceServiceTest.java
index c9abca643b..0ebc690a2c 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AlertPluginInstanceServiceTest.java
@@ -62,9 +62,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * alert plugin instance service test
- */
@ExtendWith(MockitoExtension.class)
public class AlertPluginInstanceServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AuditServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AuditServiceTest.java
index e06dfc77db..463ebaf1aa 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AuditServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/AuditServiceTest.java
@@ -42,9 +42,6 @@ import org.mockito.junit.jupiter.MockitoExtension;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * audit service test
- */
@ExtendWith(MockitoExtension.class)
public class AuditServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/BaseServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/BaseServiceTest.java
index 162d82a90a..9d7b83c5c5 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/BaseServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/BaseServiceTest.java
@@ -33,9 +33,6 @@ import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension;
-/**
- * base service test
- */
@ExtendWith(MockitoExtension.class)
public class BaseServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataAnalysisServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataAnalysisServiceTest.java
index 17e7a2f2bf..d2497a43d1 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataAnalysisServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataAnalysisServiceTest.java
@@ -76,9 +76,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * data analysis service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class DataAnalysisServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
index ec0adfef33..784dbae1e8 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java
@@ -76,9 +76,6 @@ import org.springframework.dao.DuplicateKeyException;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * data source service test
- */
@ExtendWith(MockitoExtension.class)
public class DataSourceServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/MonitorServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/MonitorServiceTest.java
index e9eff1ecee..5c7555fb44 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/MonitorServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/MonitorServiceTest.java
@@ -54,9 +54,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.annotation.DbType;
-/**
- * monitor service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class MonitorServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/QueueServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/QueueServiceTest.java
index 8198e2e0c8..ce6aa96582 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/QueueServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/QueueServiceTest.java
@@ -62,9 +62,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * queue service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class QueueServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SchedulerServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SchedulerServiceTest.java
index 33b487340c..4e9460741f 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SchedulerServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SchedulerServiceTest.java
@@ -40,9 +40,6 @@ import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
-/**
- * scheduler service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class SchedulerServiceTest extends BaseServiceTestTool {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SessionServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SessionServiceTest.java
index 97626ae877..6023e218dd 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SessionServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/SessionServiceTest.java
@@ -39,9 +39,6 @@ import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.jupiter.MockitoExtension;
-/**
- * session service test
- */
@ExtendWith(MockitoExtension.class)
public class SessionServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
index 9663b065d1..821e293bea 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/TaskInstanceServiceTest.java
@@ -67,9 +67,6 @@ import org.mockito.quality.Strictness;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * task instance service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class TaskInstanceServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UiPluginServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UiPluginServiceTest.java
index e9ef94fee9..a5ef421556 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UiPluginServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UiPluginServiceTest.java
@@ -38,9 +38,6 @@ import org.mockito.junit.jupiter.MockitoExtension;
import com.fasterxml.jackson.databind.node.ArrayNode;
-/**
- * ui plugin service test
- */
@ExtendWith(MockitoExtension.class)
public class UiPluginServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java
index 26b66a670a..58d301a85e 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java
@@ -67,9 +67,6 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.google.common.collect.Lists;
-/**
- * users service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class UsersServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceTest.java
index e445869bf7..0df81b32b1 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceTest.java
@@ -52,9 +52,6 @@ import org.slf4j.LoggerFactory;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * cluster service test
- */
@ExtendWith(MockitoExtension.class)
public class ClusterServiceTest {
diff --git a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceTest.java b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceTest.java
index ba6ffc6792..2f375052a5 100644
--- a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceTest.java
+++ b/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/EnvironmentServiceTest.java
@@ -71,9 +71,6 @@ import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * environment service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class EnvironmentServiceTest {
diff --git a/dolphinscheduler-authentication/dolphinscheduler-actuator-authentication/src/main/java/org/apache/dolphinscheduler/authentication/actuator/config/ActuatorAuthenticationAutoConfiguration.java b/dolphinscheduler-authentication/dolphinscheduler-actuator-authentication/src/main/java/org/apache/dolphinscheduler/authentication/actuator/config/ActuatorAuthenticationAutoConfiguration.java
index 999321fa8b..bf70c56d04 100644
--- a/dolphinscheduler-authentication/dolphinscheduler-actuator-authentication/src/main/java/org/apache/dolphinscheduler/authentication/actuator/config/ActuatorAuthenticationAutoConfiguration.java
+++ b/dolphinscheduler-authentication/dolphinscheduler-actuator-authentication/src/main/java/org/apache/dolphinscheduler/authentication/actuator/config/ActuatorAuthenticationAutoConfiguration.java
@@ -22,8 +22,7 @@ import org.apache.commons.lang3.StringUtils;
import java.util.ArrayList;
import java.util.List;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
@@ -129,8 +128,7 @@ public class ActuatorAuthenticationAutoConfiguration {
* Properties for Actuator security settings.
* Maps: management.security.*
*/
- @Getter
- @Setter
+ @Data
@ToString(exclude = "password")
@ConfigurationProperties("management.security")
public static class ActuatorSecurityProperties {
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java
index 2861848009..499ed0cd5c 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/constants/Constants.java
@@ -25,9 +25,6 @@ import lombok.experimental.UtilityClass;
@UtilityClass
public final class Constants {
- /**
- * common properties path
- */
public static final String COMMON_PROPERTIES_PATH = "/common.properties";
public static final String REMOTE_LOGGING_YAML_PATH = "/remote-logging.yaml";
@@ -45,9 +42,6 @@ public final class Constants {
*/
public static final String FS_DEFAULT_FS = "resource.hdfs.fs.defaultFS";
- /**
- * data basedir path
- */
public static final String DATA_BASEDIR_PATH = "data.basedir.path";
/**
@@ -58,9 +52,6 @@ public final class Constants {
public static final String RESOURCE_VIEW_SUFFIXES_DEFAULT_VALUE =
"txt,log,sh,bat,conf,cfg,py,java,sql,xml,hql,properties,json,yml,yaml,ini,js";
- /**
- * development.state
- */
public static final String DEVELOPMENT_STATE = "development.state";
/**
@@ -68,64 +59,31 @@ public final class Constants {
*/
public static final String SHELL_KILL_WAIT_TIMEOUT = "shell.kill.wait.timeout";
- /**
- * sudo enable
- */
public static final String SUDO_ENABLE = "sudo.enable";
- /**
- * resource storage type
- */
public static final String RESOURCE_STORAGE_TYPE = "resource.storage.type";
public static final String AWS_S3_BUCKET_NAME = "aws.s3.bucket.name";
- /**
- * comma ,
- */
public static final String COMMA = ",";
- /**
- * COLON :
- */
public static final String COLON = ":";
- /**
- * SPACE " "
- */
public static final String SPACE = " ";
- /**
- * SINGLE_SLASH /
- */
public static final String SINGLE_SLASH = "/";
- /**
- * DOUBLE_SLASH //
- */
public static final String DOUBLE_SLASH = "//";
- /**
- * AT SIGN
- */
public static final String AT_SIGN = "@";
- /**
- * SLASH /
- */
public static final String SLASH = "/";
- /**
- * SEMICOLON ;
- */
public static final String SEMICOLON = ";";
public static final String IMPORT_SUFFIX = "_import_";
public static final String COPY_SUFFIX = "_copy_";
- /**
- * http connect time out
- */
public static final int HTTP_CONNECT_TIMEOUT = 60 * 1000;
/**
@@ -143,14 +101,8 @@ public final class Constants {
*/
public static final String HTTP_HEADER_UNKNOWN = "unKnown";
- /**
- * http X-Forwarded-For
- */
public static final String HTTP_X_FORWARDED_FOR = "X-Forwarded-For";
- /**
- * http X-Real-IP
- */
public static final String HTTP_X_REAL_IP = "X-Real-IP";
/**
@@ -158,34 +110,16 @@ public final class Constants {
*/
public static final Pattern REGEX_USER_NAME = Pattern.compile("^[a-zA-Z0-9._-]{3,39}$");
- /**
- * read permission
- */
public static final int READ_PERMISSION = 2;
- /**
- * write permission
- */
public static final int WRITE_PERMISSION = 2 * 2;
- /**
- * execute permission
- */
public static final int EXECUTE_PERMISSION = 1;
- /**
- * default admin permission
- */
public static final int DEFAULT_ADMIN_PERMISSION = 7;
- /**
- * default hash map size
- */
public static final int DEFAULT_HASH_MAP_SIZE = 16;
- /**
- * all permissions
- */
public static final int ALL_PERMISSIONS = READ_PERMISSION | WRITE_PERMISSION | EXECUTE_PERMISSION;
/**
@@ -218,14 +152,8 @@ public final class Constants {
public static final Duration SERVER_CLOSE_WAIT_TIME = Duration.ofSeconds(3);
- /**
- * exit code success
- */
public static final int EXIT_CODE_SUCCESS = 0;
- /**
- * exit code failure
- */
public static final int EXIT_CODE_FAILURE = -1;
/**
@@ -238,9 +166,6 @@ public final class Constants {
*/
public static final int VERSION_FIRST = 1;
- /**
- * underline "_"
- */
public static final String UNDERLINE = "_";
public static final String GLOBAL_PARAMS = "globalParams";
@@ -258,29 +183,14 @@ public final class Constants {
public static final long DEPENDENT_ALL_TASK_CODE = -1;
public static final long DEPENDENT_WORKFLOW_CODE = 0;
- /**
- * preview schedule execute count
- */
public static final int PREVIEW_SCHEDULE_EXECUTE_COUNT = 5;
- /**
- * kerberos
- */
public static final String KERBEROS = "kerberos";
- /**
- * java.security.krb5.conf
- */
public static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
- /**
- * java.security.krb5.conf.path
- */
public static final String JAVA_SECURITY_KRB5_CONF_PATH = "java.security.krb5.conf.path";
- /**
- * hadoop.security.authentication
- */
public static final String HADOOP_SECURITY_AUTHENTICATION = "hadoop.security.authentication";
/**
@@ -299,24 +209,12 @@ public final class Constants {
*/
public static final String LOGIN_USER_KEY_TAB_PATH = "login.user.keytab.path";
- /**
- * sso.login.user.state
- */
public static final String SSO_LOGIN_USER_STATE = "sso.login.user.state";
- /**
- * status
- */
public static final String STATUS = "status";
- /**
- * message
- */
public static final String MSG = "msg";
- /**
- * page size
- */
public static final String PAGE_SIZE = "pageSize";
/**
@@ -341,9 +239,6 @@ public final class Constants {
public static final long DEPENDENT_ALL_TASK = 0;
- /**
- * session user
- */
public static final String SESSION_USER = "session.user";
public static final String SESSION_ID = "sessionId";
@@ -353,23 +248,14 @@ public final class Constants {
*/
public static final String LOCALE_LANGUAGE = "language";
- /**
- * session timeout
- */
public static final int SESSION_TIME_OUT = 7200;
- /**
- * authorize writable perm
- */
public static final int AUTHORIZE_WRITABLE_PERM = 7;
public static final String START_TIME = "start time";
public static final String END_TIME = "end time";
public static final String START_END_DATE = "startDate,endDate";
- /**
- * system line separator
- */
public static final String SYSTEM_LINE_SEPARATOR = System.getProperty("line.separator");
/**
@@ -384,9 +270,6 @@ public final class Constants {
public static final String CLUSTER = "cluster";
public static final Long K8S_LOCAL_TEST_CLUSTER_CODE = 0L;
- /**
- * schedule timezone
- */
public static final String SCHEDULE_TIMEZONE = "schedule_timezone";
/**
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditModelType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditModelType.java
index ce1f34d2c2..521baeaab6 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditModelType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditModelType.java
@@ -23,9 +23,6 @@ import java.util.List;
import lombok.Getter;
-/**
- * Audit Model type
- */
@Getter
public enum AuditModelType {
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditOperationType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditOperationType.java
index c4ca1b351e..3673f74081 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditOperationType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditOperationType.java
@@ -23,9 +23,6 @@ import java.util.List;
import lombok.Getter;
-/**
- * Audit Operation type
- */
@Getter
public enum AuditOperationType {
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ConditionType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ConditionType.java
index 8f690bc8f8..84c2f71d7d 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ConditionType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ConditionType.java
@@ -22,9 +22,6 @@ import java.util.Map;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * condition type
- */
public enum ConditionType {
/**
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/PluginType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/PluginType.java
index 08e26b3522..a3235b115b 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/PluginType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/PluginType.java
@@ -21,9 +21,6 @@ import java.util.HashMap;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * PluginType
- */
public enum PluginType {
ALERT(1, "alert", true),
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskExecuteType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskExecuteType.java
index c2c7f3a165..506ad66866 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskExecuteType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TaskExecuteType.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.common.enums;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * task execute type
- */
public enum TaskExecuteType {
/**
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TimeoutFlag.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TimeoutFlag.java
index 9088575812..621aa5a027 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TimeoutFlag.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/TimeoutFlag.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.common.enums;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * timeout flag
- */
public enum TimeoutFlag {
/**
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/UserType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/UserType.java
index effc2cfc1e..ffb63de717 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/UserType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/UserType.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.common.enums;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * user type
- */
public enum UserType {
/**
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java
index c00cc473f6..3affeeec32 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/EncryptionUtils.java
@@ -20,9 +20,6 @@ package org.apache.dolphinscheduler.common.utils;
import org.apache.commons.codec.digest.DigestUtils;
import org.apache.commons.lang3.StringUtils;
-/**
- * encryption utils
- */
public class EncryptionUtils {
private EncryptionUtils() {
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
index fb417cb64d..78f38044c4 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/JSONUtils.java
@@ -65,9 +65,6 @@ import com.fasterxml.jackson.databind.type.CollectionType;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import com.google.common.base.Strings;
-/**
- * json utils
- */
@Slf4j
public final class JSONUtils {
@@ -369,9 +366,6 @@ public final class JSONUtils {
}
- /**
- * json data deserializer
- */
public static class JsonDataDeserializer extends JsonDeserializer<String> {
@Override
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java
index fbcc3a9f57..d63d85f409 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java
@@ -42,9 +42,6 @@ import javax.security.auth.login.LoginException;
import lombok.extern.slf4j.Slf4j;
-/**
- * kerberos http client
- */
@Slf4j
public class KerberosHttpClient {
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/placeholder/BusinessTimeUtils.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/placeholder/BusinessTimeUtils.java
index 9d30aa71ca..59ba6d3fb0 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/placeholder/BusinessTimeUtils.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/placeholder/BusinessTimeUtils.java
@@ -29,9 +29,6 @@ import java.util.Date;
import java.util.HashMap;
import java.util.Map;
-/**
- * business time utils
- */
public class BusinessTimeUtils {
private BusinessTimeUtils() {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java
index 3b1c45816a..19ed2d70f2 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java
@@ -49,6 +49,8 @@ import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;
+import lombok.Getter;
+import lombok.Setter;
import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Autowired;
@@ -68,15 +70,20 @@ public class AlertDao {
private static final int ADMIN_ALERT_GROUP_ID = 1;
@Value("${alert.alarm-suppression.crash:60}")
+ @Setter
private Integer crashAlarmSuppression;
@Autowired
private AlertMapper alertMapper;
@Autowired
+ @Getter
+ @Setter
private AlertPluginInstanceMapper alertPluginInstanceMapper;
@Autowired
+ @Getter
+ @Setter
private AlertGroupMapper alertGroupMapper;
@Autowired
@@ -319,26 +326,6 @@ public class AlertDao {
return null;
}
- public AlertPluginInstanceMapper getAlertPluginInstanceMapper() {
- return alertPluginInstanceMapper;
- }
-
- public void setAlertPluginInstanceMapper(AlertPluginInstanceMapper alertPluginInstanceMapper) {
- this.alertPluginInstanceMapper = alertPluginInstanceMapper;
- }
-
- public AlertGroupMapper getAlertGroupMapper() {
- return alertGroupMapper;
- }
-
- public void setAlertGroupMapper(AlertGroupMapper alertGroupMapper) {
- this.alertGroupMapper = alertGroupMapper;
- }
-
- public void setCrashAlarmSuppression(Integer crashAlarmSuppression) {
- this.crashAlarmSuppression = crashAlarmSuppression;
- }
-
public void deleteByWorkflowInstanceId(Integer workflowInstanceId) {
if (workflowInstanceId == null) {
return;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AccessToken.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AccessToken.java
index fd5bbfbbf3..0b197e6ab4 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AccessToken.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AccessToken.java
@@ -36,29 +36,14 @@ public class AccessToken {
*/
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user_id
- */
@TableField(value = "user_id")
private int userId;
- /**
- * token
- */
@TableField(value = "token")
private String token;
- /**
- * expire_time
- */
@TableField(value = "expire_time")
private Date expireTime;
- /**
- * create_time
- */
@TableField(value = "create_time")
private Date createTime;
- /**
- * update_time
- */
@TableField(value = "update_time")
private Date updateTime;
@TableField(exist = false)
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertGroup.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertGroup.java
index fe11537dd6..3b4608595a 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertGroup.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertGroup.java
@@ -36,34 +36,19 @@ public class AlertGroup {
*/
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * group_name
- */
@TableField(value = "group_name")
private String groupName;
@TableField(value = "alert_instance_ids")
private String alertInstanceIds;
- /**
- * description
- */
@TableField(value = "description")
private String description;
- /**
- * create_time
- */
@TableField(value = "create_time")
private Date createTime;
- /**
- * update_time
- */
@TableField(value = "update_time")
private Date updateTime;
- /**
- * create_user_id
- */
@TableField(value = "create_user_id")
private int createUserId;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertPluginInstance.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertPluginInstance.java
index eb82a465ca..86cce32277 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertPluginInstance.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertPluginInstance.java
@@ -31,15 +31,9 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_alert_plugin_instance")
public class AlertPluginInstance {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * plugin_define_id
- */
@TableField(value = "plugin_define_id", updateStrategy = FieldStrategy.NEVER)
private int pluginDefineId;
@@ -49,21 +43,12 @@ public class AlertPluginInstance {
@TableField("instance_name")
private String instanceName;
- /**
- * plugin_instance_params
- */
@TableField("plugin_instance_params")
private String pluginInstanceParams;
- /**
- * create_time
- */
@TableField("create_time")
private Date createTime;
- /**
- * update_time
- */
@TableField("update_time")
private Date updateTime;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java
index 7741803025..7966bfc4fe 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AlertSendStatus.java
@@ -44,15 +44,9 @@ public class AlertSendStatus {
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * alert id
- */
@TableField(value = "alert_id")
private int alertId;
- /**
- * alert plugin instance id
- */
@TableField(value = "alert_plugin_instance_id")
private int alertPluginInstanceId;
@@ -62,15 +56,9 @@ public class AlertSendStatus {
@TableField(value = "send_status")
private AlertStatus sendStatus;
- /**
- * log
- */
@TableField(value = "log")
private String log;
- /**
- * create_time
- */
@TableField("create_time")
private Date createTime;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AuditLog.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AuditLog.java
index 7c6f76e1da..e84e1d74f1 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AuditLog.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/AuditLog.java
@@ -32,35 +32,17 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_audit_log")
public class AuditLog {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user id
- */
private Integer userId;
- /**
- * model type
- */
private String modelType;
- /**
- * operation type
- */
private String operationType;
- /**
- * model id
- */
private Long modelId;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java
index 4ad86cd948..971854decf 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Command.java
@@ -105,9 +105,6 @@ public class Command {
@TableField("worker_group")
private String workerGroup;
- /**
- * tenant code
- */
@Deprecated
private String tenantCode;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/CommandCount.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/CommandCount.java
index 9dc04c6d6a..d0376f4a6a 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/CommandCount.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/CommandCount.java
@@ -19,6 +19,9 @@ package org.apache.dolphinscheduler.dao.entity;
import org.apache.dolphinscheduler.common.enums.CommandType;
+import lombok.Data;
+
+@Data
public class CommandCount {
/**
@@ -30,53 +33,4 @@ public class CommandCount {
* count for state
*/
private int count;
-
- public CommandType getCommandType() {
- return commandType;
- }
-
- public void setCommandType(CommandType commandType) {
- this.commandType = commandType;
- }
-
- public int getCount() {
- return count;
- }
-
- public void setCount(int count) {
- this.count = count;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
-
- CommandCount that = (CommandCount) o;
-
- if (count != that.count) {
- return false;
- }
- return commandType == that.commandType;
-
- }
-
- @Override
- public int hashCode() {
- int result = commandType != null ? commandType.hashCode() : 0;
- result = 31 * result + count;
- return result;
- }
-
- @Override
- public String toString() {
- return "CommandCount{"
- + "commandType=" + commandType
- + ", count=" + count
- + '}';
- }
}
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSource.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSource.java
index da8cb5ad3d..30d16f3100 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSource.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSource.java
@@ -33,20 +33,11 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_datasource")
public class DataSource {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user id
- */
private int userId;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
@@ -55,9 +46,6 @@ public class DataSource {
*/
private String name;
- /**
- * note
- */
private String note;
/**
@@ -65,19 +53,10 @@ public class DataSource {
*/
private DbType type;
- /**
- * connection parameters
- */
private String connectionParams;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
@Override
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DatasourceUser.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DatasourceUser.java
index 336f96538d..13538f7792 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DatasourceUser.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DatasourceUser.java
@@ -29,33 +29,18 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_relation_datasource_user")
public class DatasourceUser {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user id
- */
private int userId;
- /**
- * data source id
- */
private int datasourceId;
/**
* permission
*/
private int perm;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
}
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentSimplifyDefinition.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentSimplifyDefinition.java
index bc33b9d846..2516946ba4 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentSimplifyDefinition.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentSimplifyDefinition.java
@@ -17,9 +17,12 @@
package org.apache.dolphinscheduler.dao.entity;
+import lombok.Data;
+
/**
* dependent node simplify definition
*/
+@Data
public class DependentSimplifyDefinition {
/**
@@ -36,28 +39,4 @@ public class DependentSimplifyDefinition {
* definition version
*/
private Integer version;
-
- public Long getCode() {
- return this.code;
- }
-
- public void setCode(Long code) {
- this.code = code;
- }
-
- public String getName() {
- return this.name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public Integer getVersion() {
- return this.version;
- }
-
- public void setVersion(Integer version) {
- this.version = version;
- }
}
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/EnvironmentWorkerGroupRelation.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/EnvironmentWorkerGroupRelation.java
index 756d9623d1..243edbc67e 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/EnvironmentWorkerGroupRelation.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/EnvironmentWorkerGroupRelation.java
@@ -32,9 +32,6 @@ public class EnvironmentWorkerGroupRelation {
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * environment code
- */
private Long environmentCode;
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/FavTask.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/FavTask.java
index 8bddc05c7d..fcff7d37ba 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/FavTask.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/FavTask.java
@@ -18,17 +18,15 @@
package org.apache.dolphinscheduler.dao.entity;
import lombok.AllArgsConstructor;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
import com.baomidou.mybatisplus.annotation.IdType;
import com.baomidou.mybatisplus.annotation.TableId;
import com.baomidou.mybatisplus.annotation.TableName;
@NoArgsConstructor
-@Getter
-@Setter
+@Data
@AllArgsConstructor
@TableName("t_ds_fav_task")
public class FavTask {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespace.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespace.java
index c1adb0b884..3218a2b5d3 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespace.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespace.java
@@ -50,27 +50,15 @@ public class K8sNamespace {
@TableField(value = "user_id")
private int userId;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
- /**
- * create_time
- */
@TableField("create_time")
private Date createTime;
- /**
- * update_time
- */
@TableField("update_time")
private Date updateTime;
- /**
- * cluster code
- */
@TableField("cluster_code")
private Long clusterCode;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespaceUser.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespaceUser.java
index b7d349f4f7..3da78b957b 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespaceUser.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/K8sNamespaceUser.java
@@ -30,21 +30,12 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_relation_namespace_user")
public class K8sNamespaceUser {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user id
- */
@TableField("user_id")
private int userId;
- /**
- * namespace id
- */
@TableField("namespace_id")
private int namespaceId;
@@ -54,15 +45,9 @@ public class K8sNamespaceUser {
@TableField(exist = false)
private String k8s;
- /**
- * namespace name
- */
@TableField(exist = false)
private String namespaceName;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/PluginDefine.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/PluginDefine.java
index bb2e3c8d23..99051c47bf 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/PluginDefine.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/PluginDefine.java
@@ -30,39 +30,21 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_plugin_define")
public class PluginDefine {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * plugin name
- */
@TableField("plugin_name")
private String pluginName;
- /**
- * plugin_type
- */
@TableField("plugin_type")
private String pluginType;
- /**
- * plugin_params
- */
@TableField("plugin_params")
private String pluginParams;
- /**
- * create_time
- */
@TableField("create_time")
private Date createTime;
- /**
- * update_time
- */
@TableField("update_time")
private Date updateTime;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Project.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Project.java
index ccce0b70e7..fa7cfa279d 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Project.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Project.java
@@ -36,21 +36,12 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_project")
public class Project {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * user id
- */
@TableField("user_id")
private Integer userId;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
@@ -69,14 +60,8 @@ public class Project {
*/
private String description;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectUser.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectUser.java
index e694db5b62..742cf4d32e 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectUser.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectUser.java
@@ -30,9 +30,6 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_relation_project_user")
public class ProjectUser {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
@@ -42,21 +39,12 @@ public class ProjectUser {
@TableField("project_id")
private int projectId;
- /**
- * project code
- */
@TableField(exist = false)
private long projectCode;
- /**
- * project name
- */
@TableField(exist = false)
private String projectName;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectWorkerGroup.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectWorkerGroup.java
index 42bc778b8f..8aa312c9e7 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectWorkerGroup.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProjectWorkerGroup.java
@@ -29,29 +29,14 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_relation_project_worker_group")
public class ProjectWorkerGroup {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * project code
- */
private Long projectCode;
- /**
- * worker group
- */
private String workerGroup;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
}
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Queue.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Queue.java
index 26979c1e7b..e22e8afc97 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Queue.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Queue.java
@@ -30,27 +30,15 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_queue")
public class Queue {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * queue name
- */
private String queueName;
/**
* yarn queue name
*/
private String queue;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
public Queue() {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/RelationSubWorkflow.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/RelationSubWorkflow.java
index bc19a9d130..b8514ed2bd 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/RelationSubWorkflow.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/RelationSubWorkflow.java
@@ -27,9 +27,6 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_relation_sub_workflow")
public class RelationSubWorkflow {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java
index 5205dfc5ae..df0a91f7a8 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java
@@ -55,35 +55,17 @@ import com.google.common.base.Strings;
@TableName("t_ds_task_definition")
public class TaskDefinition {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * code
- */
private long code;
- /**
- * name
- */
private String name;
- /**
- * version
- */
private int version;
- /**
- * description
- */
private String description;
- /**
- * project code
- */
private long projectCode;
/**
@@ -91,9 +73,6 @@ public class TaskDefinition {
*/
private int userId;
- /**
- * task type
- */
private String taskType;
/**
@@ -121,51 +100,24 @@ public class TaskDefinition {
*/
private Flag flag;
- /**
- * task priority
- */
private Priority taskPriority;
- /**
- * user name
- */
@TableField(exist = false)
private String userName;
- /**
- * project name
- */
@TableField(exist = false)
private String projectName;
- /**
- * worker group
- */
private String workerGroup;
- /**
- * environment code
- */
private long environmentCode;
- /**
- * fail retry times
- */
private int failRetryTimes;
- /**
- * fail retry interval
- */
private int failRetryInterval;
- /**
- * timeout flag
- */
private TimeoutFlag timeoutFlag;
- /**
- * timeout notify strategy
- */
@TableField(updateStrategy = FieldStrategy.IGNORED)
private TaskTimeoutStrategy timeoutNotifyStrategy;
@@ -185,14 +137,8 @@ public class TaskDefinition {
@Deprecated
private String resourceIds;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
/**
@@ -201,18 +147,12 @@ public class TaskDefinition {
@TableField(exist = false)
private String modifyBy;
- /**
- * task group id
- */
private int taskGroupId;
/**
* task group priority, todo: we should add this field to task instance when create task instance
*/
private int taskGroupPriority;
- /**
- * cpu quota
- */
private Integer cpuQuota;
/**
@@ -220,9 +160,6 @@ public class TaskDefinition {
*/
private Integer memoryMax;
- /**
- * task execute type
- */
private TaskExecuteType taskExecuteType;
public TaskDefinition(long code, int version) {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java
index 2eca1abcf3..ec47befc7d 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinitionLog.java
@@ -23,9 +23,6 @@ import lombok.Data;
import com.baomidou.mybatisplus.annotation.TableName;
-/**
- * task definition log
- */
@Data
@TableName("t_ds_task_definition_log")
public class TaskDefinitionLog extends TaskDefinition {
@@ -35,9 +32,6 @@ public class TaskDefinitionLog extends TaskDefinition {
*/
private int operator;
- /**
- * operate time
- */
private Date operateTime;
public TaskDefinitionLog() {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskMainInfo.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskMainInfo.java
index 16b5887834..c7d63b9ee9 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskMainInfo.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskMainInfo.java
@@ -24,32 +24,17 @@ import java.util.Map;
import lombok.Data;
-/**
- * task main info
- */
@Data
public class TaskMainInfo {
private long id;
- /**
- * task name
- */
private String taskName;
- /**
- * task code
- */
private long taskCode;
- /**
- * task version
- */
private int taskVersion;
- /**
- * task type
- */
private String taskType;
/**
@@ -62,29 +47,14 @@ public class TaskMainInfo {
*/
private Date taskUpdateTime;
- /**
- * projectCode
- */
private long projectCode;
- /**
- * processDefinitionCode
- */
private long processDefinitionCode;
- /**
- * processDefinitionVersion
- */
private int processDefinitionVersion;
- /**
- * processDefinitionName
- */
private String processDefinitionName;
- /**
- * processReleaseState
- */
private ReleaseState processReleaseState;
/**
@@ -92,13 +62,7 @@ public class TaskMainInfo {
*/
private Map<Long, String> upstreamTaskMap;
- /**
- * upstreamTaskCode
- */
private long upstreamTaskCode;
- /**
- * upstreamTaskName
- */
private String upstreamTaskName;
}
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Tenant.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Tenant.java
index 539ab45223..dbbddf9874 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Tenant.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Tenant.java
@@ -30,46 +30,22 @@ import com.baomidou.mybatisplus.annotation.TableName;
@TableName("t_ds_tenant")
public class Tenant {
- /**
- * id
- */
@TableId(value = "id", type = IdType.AUTO)
private Integer id;
- /**
- * tenant code
- */
private String tenantCode;
- /**
- * description
- */
private String description;
- /**
- * queue id
- */
private int queueId;
- /**
- * queue name
- */
@TableField(exist = false)
private String queueName;
- /**
- * queue
- */
@TableField(exist = false)
private String queue;
- /**
- * create time
- */
private Date createTime;
- /**
- * update time
- */
private Date updateTime;
public Tenant() {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertMapper.java
index aab7b6f5f2..0d60891e55 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/AlertMapper.java
@@ -27,9 +27,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
-/**
- * alert mapper interface
- */
@Mapper
public interface AlertMapper extends BaseMapper<Alert> {
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ClusterMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ClusterMapper.java
index 276dfa77b9..4e37fed895 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ClusterMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ClusterMapper.java
@@ -26,9 +26,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * cluster mapper interface
- */
public interface ClusterMapper extends BaseMapper<Cluster> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java
index ff0f6243ce..6ae1052f4c 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/CommandMapper.java
@@ -29,9 +29,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * command mapper interface
- */
public interface CommandMapper extends BaseMapper<Command> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentMapper.java
index 7688259c4f..964a69f0cb 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentMapper.java
@@ -27,9 +27,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * environment mapper interface
- */
public interface EnvironmentMapper extends BaseMapper<Environment> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentWorkerGroupRelationMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentWorkerGroupRelationMapper.java
index 44375368f2..d7e695f1f4 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentWorkerGroupRelationMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/EnvironmentWorkerGroupRelationMapper.java
@@ -25,9 +25,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
-/**
- * environment worker group relation mapper interface
- */
public interface EnvironmentWorkerGroupRelationMapper extends BaseMapper<EnvironmentWorkerGroupRelation> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java
index 9dee5bbc32..b8e364c82a 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ErrorCommandMapper.java
@@ -29,9 +29,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * error command mapper interface
- */
public interface ErrorCommandMapper extends BaseMapper<ErrorCommand> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.java
index b103c4cfc8..566e1beb7d 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectMapper.java
@@ -28,9 +28,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * project mapper interface
- */
public interface ProjectMapper extends BaseMapper<Project> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectUserMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectUserMapper.java
index 38c4a2b4c9..31acdc1642 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectUserMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProjectUserMapper.java
@@ -23,9 +23,6 @@ import org.apache.ibatis.annotations.Param;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
-/**
- * project user mapper interface
- */
public interface ProjectUserMapper extends BaseMapper<ProjectUser> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/QueueMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/QueueMapper.java
index f0ebfc3e87..d101f4beba 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/QueueMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/QueueMapper.java
@@ -26,9 +26,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * queue mapper interface
- */
public interface QueueMapper extends BaseMapper<Queue> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionLogMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionLogMapper.java
index 718d2824a1..0305cede4c 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionLogMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionLogMapper.java
@@ -30,9 +30,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * task definition log mapper interface
- */
public interface TaskDefinitionLogMapper extends BaseMapper<TaskDefinitionLog> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java
index dc58d342a6..32a05a21ec 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java
@@ -34,9 +34,6 @@ import java.util.Set;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * task instance mapper interface
- */
public interface TaskInstanceMapper extends BaseMapper<TaskInstance> {
List<TaskInstance> findValidTaskListByWorkflowInstanceId(@Param("workflowInstanceId") Integer workflowInstanceId,
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TenantMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TenantMapper.java
index 8907ce2b77..69b904f57d 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TenantMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TenantMapper.java
@@ -27,9 +27,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * tenant mapper interface
- */
public interface TenantMapper extends BaseMapper<Tenant> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UserMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UserMapper.java
index 9d0e60aaa7..0aa97f2a25 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UserMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UserMapper.java
@@ -29,9 +29,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * user mapper interface
- */
public interface UserMapper extends BaseMapper<User> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionLogMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionLogMapper.java
index e050d0fd60..58b4c29d7f 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionLogMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionLogMapper.java
@@ -27,10 +27,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * workflow definition log mapper interface
- */
-
public interface WorkflowDefinitionLogMapper extends BaseMapper<WorkflowDefinitionLog> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.java
index 6651583278..6fa7e6e50f 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowDefinitionMapper.java
@@ -30,9 +30,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * workflow definition mapper interface
- */
public interface WorkflowDefinitionMapper extends BaseMapper<WorkflowDefinition> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
index eae9691d1b..aa88680ae7 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java
@@ -33,9 +33,6 @@ import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * workflow instance mapper interface
- */
public interface WorkflowInstanceMapper extends BaseMapper<WorkflowInstance> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowTaskRelationMapper.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowTaskRelationMapper.java
index 263b70629c..a733aeaff9 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowTaskRelationMapper.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowTaskRelationMapper.java
@@ -27,9 +27,6 @@ import java.util.List;
import com.baomidou.mybatisplus.core.mapper.BaseMapper;
import com.baomidou.mybatisplus.core.metadata.IPage;
-/**
- * workflow task relation mapper interface
- */
public interface WorkflowTaskRelationMapper extends BaseMapper<WorkflowTaskRelation> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskDefinitionLogDao.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskDefinitionLogDao.java
index 96eb374f8e..a75e1c7cae 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskDefinitionLogDao.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskDefinitionLogDao.java
@@ -23,9 +23,6 @@ import org.apache.dolphinscheduler.dao.entity.WorkflowTaskRelation;
import java.util.List;
import java.util.Set;
-/**
- * Task Definition Log DAO
- */
public interface TaskDefinitionLogDao extends IDao<TaskDefinitionLog> {
List<TaskDefinitionLog> queryByWorkflowDefinitionCodeAndVersion(Long workflowDefinitionCode,
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java
index fcee785c59..39b2a073d7 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/TaskInstanceDao.java
@@ -24,9 +24,6 @@ import org.apache.dolphinscheduler.plugin.task.api.enums.TaskExecutionStatus;
import java.util.List;
import java.util.Set;
-/**
- * Task Instance DAO
- */
public interface TaskInstanceDao extends IDao<TaskInstance> {
/**
diff --git a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/WorkflowUtils.java b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/WorkflowUtils.java
index ad07d9e023..aacac6a013 100644
--- a/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/WorkflowUtils.java
+++ b/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/utils/WorkflowUtils.java
@@ -22,9 +22,6 @@ import org.apache.dolphinscheduler.dao.entity.WorkflowInstance;
import java.util.Date;
-/**
- * workflow utils
- */
public class WorkflowUtils {
/**
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java
index b61975988a..6c355c2178 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AccessTokenMapperTest.java
@@ -37,9 +37,6 @@ import org.springframework.beans.factory.annotation.Autowired;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * AccessToken mapper test
- */
public class AccessTokenMapperTest extends BaseDaoTest {
@Autowired
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapperTest.java
index 54b112d8c2..3cd913e504 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertGroupMapperTest.java
@@ -32,9 +32,6 @@ import org.springframework.beans.factory.annotation.Autowired;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * AlertGroup mapper test
- */
public class AlertGroupMapperTest extends BaseDaoTest {
@Autowired
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertMapperTest.java
index 47c5f76e77..346004453f 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertMapperTest.java
@@ -32,9 +32,6 @@ import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
-/**
- * alert mapper test
- */
public class AlertMapperTest extends BaseDaoTest {
@Autowired
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertSendStatusMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertSendStatusMapperTest.java
index 01f147e047..2c0eb49c71 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertSendStatusMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/AlertSendStatusMapperTest.java
@@ -26,9 +26,6 @@ import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
-/**
- * AlertSendStatus mapper test
- */
public class AlertSendStatusMapperTest extends BaseDaoTest {
@Autowired
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/CommandMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/CommandMapperTest.java
index 57a7d9cbfb..59c69c981d 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/CommandMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/CommandMapperTest.java
@@ -47,9 +47,6 @@ import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
import com.google.common.collect.Lists;
-/**
- * command mapper test
- */
public class CommandMapperTest extends BaseDaoTest {
@Autowired
diff --git a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java
index b1a0f6a80c..dcf43b4f68 100644
--- a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java
+++ b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java
@@ -41,14 +41,8 @@ import org.springframework.beans.factory.annotation.Autowired;
import com.baomidou.mybatisplus.core.metadata.IPage;
import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
-/**
- * datasource mapper test
- */
public class DataSourceMapperTest extends BaseDaoTest {
- /**
- * datasource mapper
- */
@Autowired
private DataSourceMapper dataSourceMapper;
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/constants/DataSourceConstants.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/constants/DataSourceConstants.java
index c1e5e08306..46a827a67e 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/constants/DataSourceConstants.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/constants/DataSourceConstants.java
@@ -103,24 +103,12 @@ public class DataSourceConstants {
public static final String DATASOURCE_ENCRYPTION_ENABLE = "datasource.encryption.enable";
public static final String DATASOURCE_ENCRYPTION_SALT = "datasource.encryption.salt";
- /**
- * kerberos
- */
public static final String KERBEROS = "kerberos";
- /**
- * kerberos expire time
- */
public static final String KERBEROS_EXPIRE_TIME = "kerberos.expire.time";
- /**
- * java.security.krb5.conf
- */
public static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
- /**
- * java.security.krb5.conf.path
- */
public static final String JAVA_SECURITY_KRB5_CONF_PATH = "java.security.krb5.conf.path";
/**
@@ -133,9 +121,6 @@ public class DataSourceConstants {
*/
public static final String LOGIN_USER_KEY_TAB_PATH = "login.user.keytab.path";
- /**
- * hadoop.security.authentication
- */
public static final String HADOOP_SECURITY_AUTHENTICATION = "hadoop.security.authentication";
/**
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java
index f0c0a16ae8..b3c1c6da4b 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java
@@ -24,9 +24,12 @@ import java.io.Serializable;
import java.util.ArrayList;
import java.util.Map;
+import lombok.Data;
+
/**
* Basic datasource params submitted to api, each datasource plugin should have implementation.
*/
+@Data
public abstract class BaseDataSourceParamDTO implements Serializable {
protected Integer id;
@@ -47,46 +50,6 @@ public abstract class BaseDataSourceParamDTO implements Serializable {
protected Map<String, String> other;
- public Integer getId() {
- return id;
- }
-
- public void setId(Integer id) {
- this.id = id;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getNote() {
- return note;
- }
-
- public void setNote(String note) {
- this.note = note;
- }
-
- public String getHost() {
- return host;
- }
-
- public void setHost(String host) {
- this.host = host;
- }
-
- public Integer getPort() {
- return port;
- }
-
- public void setPort(Integer port) {
- this.port = port;
- }
-
/**
* extract the host and port from the address,
* then set it
@@ -120,38 +83,6 @@ public abstract class BaseDataSourceParamDTO implements Serializable {
this.port = Integer.parseInt(portString);
}
- public String getDatabase() {
- return database;
- }
-
- public void setDatabase(String database) {
- this.database = database;
- }
-
- public String getUserName() {
- return userName;
- }
-
- public void setUserName(String userName) {
- this.userName = userName;
- }
-
- public String getPassword() {
- return password;
- }
-
- public void setPassword(String password) {
- this.password = password;
- }
-
- public Map<String, String> getOther() {
- return other;
- }
-
- public void setOther(Map<String, String> other) {
- this.other = other;
- }
-
/**
* Get the datasource type
* see{@link DbType}
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSConnectionParam.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSConnectionParam.java
index fd14837dad..6bef9d15ea 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSConnectionParam.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSConnectionParam.java
@@ -19,6 +19,11 @@ package org.apache.dolphinscheduler.plugin.datasource.api.datasource;
import org.apache.dolphinscheduler.spi.datasource.BaseConnectionParam;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class BaseHDFSConnectionParam extends BaseConnectionParam {
protected String principal;
@@ -26,35 +31,4 @@ public class BaseHDFSConnectionParam extends BaseConnectionParam {
protected String loginUserKeytabUsername;
protected String loginUserKeytabPath;
- public String getPrincipal() {
- return principal;
- }
-
- public void setPrincipal(String principal) {
- this.principal = principal;
- }
-
- public String getJavaSecurityKrb5Conf() {
- return javaSecurityKrb5Conf;
- }
-
- public void setJavaSecurityKrb5Conf(String javaSecurityKrb5Conf) {
- this.javaSecurityKrb5Conf = javaSecurityKrb5Conf;
- }
-
- public String getLoginUserKeytabUsername() {
- return loginUserKeytabUsername;
- }
-
- public void setLoginUserKeytabUsername(String loginUserKeytabUsername) {
- this.loginUserKeytabUsername = loginUserKeytabUsername;
- }
-
- public String getLoginUserKeytabPath() {
- return loginUserKeytabPath;
- }
-
- public void setLoginUserKeytabPath(String loginUserKeytabPath) {
- this.loginUserKeytabPath = loginUserKeytabPath;
- }
}
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSDataSourceParamDTO.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSDataSourceParamDTO.java
index adabb7359b..3346d30175 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSDataSourceParamDTO.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseHDFSDataSourceParamDTO.java
@@ -17,6 +17,11 @@
package org.apache.dolphinscheduler.plugin.datasource.api.datasource;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public abstract class BaseHDFSDataSourceParamDTO extends BaseDataSourceParamDTO {
protected String principal;
@@ -27,35 +32,4 @@ public abstract class BaseHDFSDataSourceParamDTO extends BaseDataSourceParamDTO
protected String loginUserKeytabPath;
- public String getPrincipal() {
- return principal;
- }
-
- public void setPrincipal(String principal) {
- this.principal = principal;
- }
-
- public String getLoginUserKeytabUsername() {
- return loginUserKeytabUsername;
- }
-
- public void setLoginUserKeytabUsername(String loginUserKeytabUsername) {
- this.loginUserKeytabUsername = loginUserKeytabUsername;
- }
-
- public String getLoginUserKeytabPath() {
- return loginUserKeytabPath;
- }
-
- public void setLoginUserKeytabPath(String loginUserKeytabPath) {
- this.loginUserKeytabPath = loginUserKeytabPath;
- }
-
- public String getJavaSecurityKrb5Conf() {
- return javaSecurityKrb5Conf;
- }
-
- public void setJavaSecurityKrb5Conf(String javaSecurityKrb5Conf) {
- this.javaSecurityKrb5Conf = javaSecurityKrb5Conf;
- }
}
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/utils/CommonUtils.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/utils/CommonUtils.java
index 4886850d83..f294381410 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/utils/CommonUtils.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/utils/CommonUtils.java
@@ -38,9 +38,6 @@ import java.io.IOException;
import lombok.extern.slf4j.Slf4j;
-/**
- * common utils
- */
@Slf4j
public class CommonUtils {
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-athena/src/main/java/org/apache/dolphinscheduler/plugin/datasource/athena/param/AthenaConnectionParam.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-athena/src/main/java/org/apache/dolphinscheduler/plugin/datasource/athena/param/AthenaConnectionParam.java
index ce56f5d2bf..a8a7163379 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-athena/src/main/java/org/apache/dolphinscheduler/plugin/datasource/athena/param/AthenaConnectionParam.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-athena/src/main/java/org/apache/dolphinscheduler/plugin/datasource/athena/param/AthenaConnectionParam.java
@@ -19,18 +19,15 @@ package org.apache.dolphinscheduler.plugin.datasource.athena.param;
import org.apache.dolphinscheduler.spi.datasource.BaseConnectionParam;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class AthenaConnectionParam extends BaseConnectionParam {
protected String awsRegion;
- public String getAwsRegion() {
- return awsRegion;
- }
-
- public void setAwsRegion(String awsRegion) {
- this.awsRegion = awsRegion;
- }
-
@Override
public String toString() {
return "AthenaConnectionParam{"
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLConnectionParam.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLConnectionParam.java
index b8bd320409..0e55539126 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLConnectionParam.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLConnectionParam.java
@@ -19,13 +19,13 @@ package org.apache.dolphinscheduler.plugin.datasource.azuresql.param;
import org.apache.dolphinscheduler.spi.datasource.BaseConnectionParam;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.ToString;
+@EqualsAndHashCode(callSuper = true)
@ToString
-@Getter
-@Setter
+@Data
public class AzureSQLConnectionParam extends BaseConnectionParam {
protected AzureSQLAuthMode mode;
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLDataSourceParamDTO.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLDataSourceParamDTO.java
index e38d653734..29bd4cb6e8 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLDataSourceParamDTO.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-azure-sql/src/main/java/org/apache/dolphinscheduler/plugin/datasource/azuresql/param/AzureSQLDataSourceParamDTO.java
@@ -20,13 +20,13 @@ package org.apache.dolphinscheduler.plugin.datasource.azuresql.param;
import org.apache.dolphinscheduler.plugin.datasource.api.datasource.BaseDataSourceParamDTO;
import org.apache.dolphinscheduler.spi.enums.DbType;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.ToString;
+@EqualsAndHashCode(callSuper = true)
@ToString
-@Getter
-@Setter
+@Data
public class AzureSQLDataSourceParamDTO extends BaseDataSourceParamDTO {
protected AzureSQLAuthMode mode;
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleConnectionParam.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleConnectionParam.java
index 9babd1ed21..fad3d20c4a 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleConnectionParam.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleConnectionParam.java
@@ -20,18 +20,15 @@ package org.apache.dolphinscheduler.plugin.datasource.oracle.param;
import org.apache.dolphinscheduler.spi.datasource.BaseConnectionParam;
import org.apache.dolphinscheduler.spi.enums.DbConnectType;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class OracleConnectionParam extends BaseConnectionParam {
protected DbConnectType connectType;
- public DbConnectType getConnectType() {
- return connectType;
- }
-
- public void setConnectType(DbConnectType connectType) {
- this.connectType = connectType;
- }
-
@Override
public String toString() {
return "OracleConnectionParam{"
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleDataSourceParamDTO.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleDataSourceParamDTO.java
index 51f9dfae24..8661d7d430 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleDataSourceParamDTO.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oracle/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oracle/param/OracleDataSourceParamDTO.java
@@ -21,18 +21,15 @@ import org.apache.dolphinscheduler.plugin.datasource.api.datasource.BaseDataSour
import org.apache.dolphinscheduler.spi.enums.DbConnectType;
import org.apache.dolphinscheduler.spi.enums.DbType;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class OracleDataSourceParamDTO extends BaseDataSourceParamDTO {
private DbConnectType connectType;
- public DbConnectType getConnectType() {
- return connectType;
- }
-
- public void setConnectType(DbConnectType connectType) {
- this.connectType = connectType;
- }
-
@Override
public String toString() {
return "OracleDataSourceParamDTO{"
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftConnectionParam.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftConnectionParam.java
index f671e026d0..7853649130 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftConnectionParam.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftConnectionParam.java
@@ -19,11 +19,11 @@ package org.apache.dolphinscheduler.plugin.datasource.redshift.param;
import org.apache.dolphinscheduler.spi.datasource.BaseConnectionParam;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
-@Getter
-@Setter
+@EqualsAndHashCode(callSuper = true)
+@Data
public class RedshiftConnectionParam extends BaseConnectionParam {
protected RedshiftAuthMode mode;
diff --git a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftDataSourceParamDTO.java b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftDataSourceParamDTO.java
index 6fbb4b23e3..65b8fb3c35 100644
--- a/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftDataSourceParamDTO.java
+++ b/dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-redshift/src/main/java/org/apache/dolphinscheduler/plugin/datasource/redshift/param/RedshiftDataSourceParamDTO.java
@@ -20,11 +20,11 @@ package org.apache.dolphinscheduler.plugin.datasource.redshift.param;
import org.apache.dolphinscheduler.plugin.datasource.api.datasource.BaseDataSourceParamDTO;
import org.apache.dolphinscheduler.spi.enums.DbType;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
-@Getter
-@Setter
+@EqualsAndHashCode(callSuper = true)
+@Data
public class RedshiftDataSourceParamDTO extends BaseDataSourceParamDTO {
protected RedshiftAuthMode mode;
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java
index a00ff540f4..23042420d5 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyClientConfig.java
@@ -48,21 +48,12 @@ public class NettyClientConfig {
@Builder.Default
private boolean soKeepalive = true;
- /**
- * send buffer size
- */
@Builder.Default
private int sendBufferSize = 65535;
- /**
- * receive buffer size
- */
@Builder.Default
private int receiveBufferSize = 65535;
- /**
- * connect timeout millis
- */
@Builder.Default
private int connectTimeoutMillis = 3000;
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyServerConfig.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyServerConfig.java
index cc0aa04f68..022d371eee 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyServerConfig.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/config/NettyServerConfig.java
@@ -50,15 +50,9 @@ public class NettyServerConfig {
@Builder.Default
private boolean soKeepalive = true;
- /**
- * send buffer size
- */
@Builder.Default
private int sendBufferSize = 65535;
- /**
- * receive buffer size
- */
@Builder.Default
private int receiveBufferSize = 65535;
@@ -74,9 +68,6 @@ public class NettyServerConfig {
@Builder.Default
private long connectionIdleTime = Duration.ofSeconds(60).toMillis();
- /**
- * listen port
- */
private int listenPort;
}
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/InvokeCallback.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/InvokeCallback.java
index ef72212f06..bf12fbe119 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/InvokeCallback.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/InvokeCallback.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.extract.base.future;
-/**
- * invoke callback
- */
public interface InvokeCallback {
/**
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ReleaseSemaphore.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ReleaseSemaphore.java
index 7a9d98dc05..2230a56456 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ReleaseSemaphore.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ReleaseSemaphore.java
@@ -20,9 +20,6 @@ package org.apache.dolphinscheduler.extract.base.future;
import java.util.concurrent.Semaphore;
import java.util.concurrent.atomic.AtomicBoolean;
-/**
- * release semaphore
- */
public class ReleaseSemaphore {
private final Semaphore semaphore;
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/ChannelUtils.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/ChannelUtils.java
index 3643d17e39..f5261ef8ab 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/ChannelUtils.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/ChannelUtils.java
@@ -24,9 +24,6 @@ import java.net.InetSocketAddress;
import lombok.extern.slf4j.Slf4j;
import io.netty.channel.Channel;
-/**
- * channel utils
- */
@Slf4j
public class ChannelUtils {
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/Constants.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/Constants.java
index 94b92b2539..8d0a66333c 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/Constants.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/Constants.java
@@ -40,21 +40,12 @@ public class Constants {
*/
public static final Charset UTF8 = StandardCharsets.UTF_8;
- /**
- * cpus
- */
public static final int CPUS = Runtime.getRuntime().availableProcessors();
public static final String LOCAL_ADDRESS = NetUtils.getHost();
- /**
- * OS Name
- */
public static final String OS_NAME = System.getProperty("os.name");
- /**
- * warm up time
- */
public static final int WARM_UP_TIME = 10 * 60 * 1000;
}
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/NettyUtils.java b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/NettyUtils.java
index ceaef9647f..3ca6d2c3a2 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/NettyUtils.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/utils/NettyUtils.java
@@ -25,9 +25,6 @@ import io.netty.channel.socket.SocketChannel;
import io.netty.channel.socket.nio.NioServerSocketChannel;
import io.netty.channel.socket.nio.NioSocketChannel;
-/**
- * NettyUtils
- */
public class NettyUtils {
private NettyUtils() {
diff --git a/dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/dto/WorkflowExecuteDto.java b/dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/dto/WorkflowExecuteDto.java
index 33b5444701..b4c7978dc8 100644
--- a/dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/dto/WorkflowExecuteDto.java
+++ b/dolphinscheduler-extract/dolphinscheduler-extract-master/src/main/java/org/apache/dolphinscheduler/extract/master/dto/WorkflowExecuteDto.java
@@ -28,11 +28,9 @@ import org.apache.dolphinscheduler.common.enums.WorkflowExecutionStatus;
import java.util.Collection;
import java.util.Date;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
-@Setter
-@Getter
+@Data
public class WorkflowExecuteDto {
private int id;
@@ -74,9 +72,6 @@ public class WorkflowExecuteDto {
*/
private FailureStrategy failureStrategy;
- /**
- * warning type
- */
private WarningType warningType;
private Integer warningGroupId;
@@ -90,24 +85,12 @@ public class WorkflowExecuteDto {
*/
private String globalParams;
- /**
- * executor id
- */
private int executorId;
- /**
- * executor name
- */
private String executorName;
- /**
- * tenant code
- */
private String tenantCode;
- /**
- * queue
- */
private String queue;
/**
diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/runnable/TaskExecutionContextBuilder.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/runnable/TaskExecutionContextBuilder.java
index e688ec9b79..9f331db11d 100644
--- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/runnable/TaskExecutionContextBuilder.java
+++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/runnable/TaskExecutionContextBuilder.java
@@ -35,10 +35,6 @@ import java.util.concurrent.TimeUnit;
import lombok.extern.slf4j.Slf4j;
-/**
- * TaskExecutionContext builder
- */
-
@Slf4j
public class TaskExecutionContextBuilder {
diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
index 601a81a1e2..50ec9a46e4 100644
--- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
+++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
@@ -68,9 +68,6 @@ public class DependentExecute {
private final TaskInstanceDao taskInstanceDao = SpringApplicationContext.getBean(TaskInstanceDao.class);
- /**
- * depend item list
- */
private List<DependentItem> dependItemList;
/**
@@ -82,26 +79,14 @@ public class DependentExecute {
private TaskInstance taskInstance;
- /**
- * depend result map
- */
@Getter
private Map<String, DependResult> dependResultMap = new HashMap<>();
- /**
- * process service
- */
private final ProcessService processService = SpringApplicationContext.getBean(ProcessService.class);
- /**
- * task definition log dao
- */
private final TaskDefinitionLogDao taskDefinitionLogDao =
SpringApplicationContext.getBean(TaskDefinitionLogDao.class);
- /**
- * task definition dao
- */
private final TaskDefinitionDao taskDefinitionDao = SpringApplicationContext.getBean(TaskDefinitionDao.class);
@Getter
diff --git a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
index df78dfc6e4..240b9b0b6d 100644
--- a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
+++ b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/command/CommandService.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.service.command;
import org.apache.dolphinscheduler.dao.entity.Command;
-/**
- * Command Service
- */
public interface CommandService {
/**
diff --git a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CycleFactory.java b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CycleFactory.java
index dd2a012e80..03e6fbafae 100644
--- a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CycleFactory.java
+++ b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/cron/CycleFactory.java
@@ -85,9 +85,6 @@ public class CycleFactory {
return new YearCycle(cron);
}
- /**
- * day cycle
- */
public static class DayCycle extends AbstractCycle {
public DayCycle(Cron cron) {
@@ -126,9 +123,6 @@ public class CycleFactory {
}
}
- /**
- * hour cycle
- */
public static class HourCycle extends AbstractCycle {
public HourCycle(Cron cron) {
@@ -203,9 +197,6 @@ public class CycleFactory {
}
}
- /**
- * month cycle
- */
public static class MonthCycle extends AbstractCycle {
public MonthCycle(Cron cron) {
@@ -249,9 +240,6 @@ public class CycleFactory {
}
}
- /**
- * week cycle
- */
public static class WeekCycle extends AbstractCycle {
public WeekCycle(Cron cron) {
@@ -289,9 +277,6 @@ public class CycleFactory {
}
}
- /**
- * year cycle
- */
public static class YearCycle extends AbstractCycle {
public YearCycle(Cron cron) {
diff --git a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java
index 22ac1b95db..01bb9e8025 100644
--- a/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java
+++ b/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java
@@ -83,9 +83,6 @@ public class TaskNode {
*/
private int retryInterval;
- /**
- * task group id
- */
private int taskGroupId;
/**
* task group id
@@ -118,19 +115,10 @@ public class TaskNode {
*/
private List<Long> depList;
- /**
- * task instance priority
- */
private Priority taskInstancePriority;
- /**
- * worker group
- */
private String workerGroup;
- /**
- * environment code
- */
private Long environmentCode;
/**
@@ -145,9 +133,6 @@ public class TaskNode {
*/
private int delayTime;
- /**
- * cpu quota
- */
private Integer cpuQuota;
/**
@@ -155,9 +140,6 @@ public class TaskNode {
*/
private Integer memoryMax;
- /**
- * task execute type
- */
private TaskExecuteType taskExecuteType;
public String getId() {
diff --git a/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/cron/CronUtilsTest.java b/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/cron/CronUtilsTest.java
index 5aec41f93e..612a0e7feb 100644
--- a/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/cron/CronUtilsTest.java
+++ b/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/cron/CronUtilsTest.java
@@ -48,9 +48,6 @@ import com.cronutils.model.field.expression.Every;
import com.cronutils.model.field.expression.On;
import com.cronutils.model.field.expression.QuestionMark;
-/**
- * CronUtilsTest
- */
public class CronUtilsTest {
private static final Logger logger = LoggerFactory.getLogger(CronUtilsTest.class);
diff --git a/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java b/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java
index 89e0d3c187..777cbb3885 100644
--- a/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java
+++ b/dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java
@@ -57,9 +57,6 @@ import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.junit.jupiter.MockitoSettings;
import org.mockito.quality.Strictness;
-/**
- * process service test
- */
@ExtendWith(MockitoExtension.class)
@MockitoSettings(strictness = Strictness.LENIENT)
public class ProcessServiceTest {
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/ResourceType.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/ResourceType.java
index 8be58ebb15..d0f49b632a 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/ResourceType.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/enums/ResourceType.java
@@ -21,9 +21,6 @@ import lombok.Getter;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * resource type
- */
@Getter
public enum ResourceType {
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/PluginParams.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/PluginParams.java
index 7ba80c2c55..60054fc252 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/PluginParams.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/PluginParams.java
@@ -34,9 +34,6 @@ import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fasterxml.jackson.databind.annotation.JsonPOJOBuilder;
-/**
- * plugin params
- */
@JsonDeserialize(builder = PluginParams.Builder.class)
public class PluginParams {
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/InputParamProps.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/InputParamProps.java
index f352e61c4f..e47992cc74 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/InputParamProps.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/InputParamProps.java
@@ -20,9 +20,12 @@ package org.apache.dolphinscheduler.spi.params.input;
import org.apache.dolphinscheduler.spi.params.base.ParamsProps;
import org.apache.dolphinscheduler.spi.params.base.ResizeType;
+import lombok.Data;
+
/**
* front-end input component props attributes
*/
+@Data
public class InputParamProps extends ParamsProps {
/**
@@ -127,171 +130,4 @@ public class InputParamProps extends ParamsProps {
*/
private Boolean showPassword;
- public String getType() {
- return type;
- }
-
- public void setType(String type) {
- this.type = type;
- }
-
- public Integer getMaxlength() {
- return maxlength;
- }
-
- public void setMaxlength(Integer maxlength) {
- this.maxlength = maxlength;
- }
-
- public Integer getMinlength() {
- return minlength;
- }
-
- public void setMinlength(Integer minlength) {
- this.minlength = minlength;
- }
-
- public Boolean getClearable() {
- return clearable;
- }
-
- public void setClearable(Boolean clearable) {
- this.clearable = clearable;
- }
-
- public String getPrefixIcon() {
- return prefixIcon;
- }
-
- public void setPrefixIcon(String prefixIcon) {
- this.prefixIcon = prefixIcon;
- }
-
- public String getSuffixIcon() {
- return suffixIcon;
- }
-
- public void setSuffixIcon(String suffixIcon) {
- this.suffixIcon = suffixIcon;
- }
-
- public Integer getRows() {
- return rows;
- }
-
- public void setRows(Integer rows) {
- this.rows = rows;
- }
-
- public Object getAutosize() {
- return autosize;
- }
-
- public void setAutosize(Object autosize) {
- this.autosize = autosize;
- }
-
- public String getAutocomplete() {
- return autocomplete;
- }
-
- public void setAutocomplete(String autocomplete) {
- this.autocomplete = autocomplete;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public Boolean getReadonly() {
- return readonly;
- }
-
- public void setReadonly(Boolean readonly) {
- this.readonly = readonly;
- }
-
- public Integer getMax() {
- return max;
- }
-
- public void setMax(Integer max) {
- this.max = max;
- }
-
- public Integer getMin() {
- return min;
- }
-
- public void setMin(Integer min) {
- this.min = min;
- }
-
- public Integer getStep() {
- return step;
- }
-
- public void setStep(Integer step) {
- this.step = step;
- }
-
- public ResizeType getResize() {
- return resize;
- }
-
- public void setResize(ResizeType resize) {
- this.resize = resize;
- }
-
- public Boolean getAutofocus() {
- return autofocus;
- }
-
- public void setAutofocus(Boolean autofocus) {
- this.autofocus = autofocus;
- }
-
- public String getForm() {
- return form;
- }
-
- public void setForm(String form) {
- this.form = form;
- }
-
- public String getLabel() {
- return label;
- }
-
- public void setLabel(String label) {
- this.label = label;
- }
-
- public String getTabindex() {
- return tabindex;
- }
-
- public void setTabindex(String tabindex) {
- this.tabindex = tabindex;
- }
-
- public Boolean getValidateEvent() {
- return validateEvent;
- }
-
- public void setValidateEvent(Boolean validateEvent) {
- this.validateEvent = validateEvent;
- }
-
- public Boolean getShowPassword() {
- return showPassword;
- }
-
- public void setShowPassword(Boolean showPassword) {
- this.showPassword = showPassword;
- }
}
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/number/InputNumberParamProps.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/number/InputNumberParamProps.java
index 1ff9efd6ff..28455757c9 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/number/InputNumberParamProps.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/number/InputNumberParamProps.java
@@ -19,9 +19,12 @@ package org.apache.dolphinscheduler.spi.params.input.number;
import org.apache.dolphinscheduler.spi.params.base.ParamsProps;
+import lombok.Data;
+
/**
* front-end input number component props attributes
*/
+@Data
public class InputNumberParamProps extends ParamsProps {
/**
@@ -64,67 +67,4 @@ public class InputNumberParamProps extends ParamsProps {
*/
private String label;
- public Integer getMin() {
- return min;
- }
-
- public void setMin(Integer min) {
- this.min = min;
- }
-
- public Integer getMax() {
- return max;
- }
-
- public void setMax(Integer max) {
- this.max = max;
- }
-
- public Integer getStep() {
- return step;
- }
-
- public void setStep(Integer step) {
- this.step = step;
- }
-
- public Integer getPrecision() {
- return precision;
- }
-
- public void setPrecision(Integer precision) {
- this.precision = precision;
- }
-
- public Boolean getControls() {
- return controls;
- }
-
- public void setControls(Boolean controls) {
- this.controls = controls;
- }
-
- public String getControlsPosition() {
- return controlsPosition;
- }
-
- public void setControlsPosition(String controlsPosition) {
- this.controlsPosition = controlsPosition;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getLabel() {
- return label;
- }
-
- public void setLabel(String label) {
- this.label = label;
- }
}
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParamProps.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParamProps.java
index f558f7579a..1f95c2de3b 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParamProps.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParamProps.java
@@ -19,9 +19,12 @@ package org.apache.dolphinscheduler.spi.params.radio;
import org.apache.dolphinscheduler.spi.params.base.ParamsProps;
+import lombok.Data;
+
/**
* front-end radio component props attributes
*/
+@Data
public class RadioParamProps extends ParamsProps {
/**
@@ -34,19 +37,4 @@ public class RadioParamProps extends ParamsProps {
*/
private String fill;
- public String getTextColor() {
- return textColor;
- }
-
- public void setTextColor(String textColor) {
- this.textColor = textColor;
- }
-
- public String getFill() {
- return fill;
- }
-
- public void setFill(String fill) {
- this.fill = fill;
- }
}
diff --git a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParamProps.java b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParamProps.java
index a8a68ee631..3932265b4b 100644
--- a/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParamProps.java
+++ b/dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/select/SelectParamProps.java
@@ -19,9 +19,14 @@ package org.apache.dolphinscheduler.spi.params.select;
import org.apache.dolphinscheduler.spi.params.base.ParamsProps;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
/**
* front-end select component props attributes
*/
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SelectParamProps extends ParamsProps {
/**
@@ -109,131 +114,4 @@ public class SelectParamProps extends ParamsProps {
*/
private Boolean automaticDropdown;
- public Boolean getMultiple() {
- return multiple;
- }
-
- public void setMultiple(Boolean multiple) {
- this.multiple = multiple;
- }
-
- public String getValueKey() {
- return valueKey;
- }
-
- public void setValueKey(String valueKey) {
- this.valueKey = valueKey;
- }
-
- public Boolean getClearable() {
- return clearable;
- }
-
- public void setClearable(Boolean clearable) {
- this.clearable = clearable;
- }
-
- public Boolean getCollapseTags() {
- return collapseTags;
- }
-
- public void setCollapseTags(Boolean collapseTags) {
- this.collapseTags = collapseTags;
- }
-
- public Integer getMultipleLimit() {
- return multipleLimit;
- }
-
- public void setMultipleLimit(Integer multipleLimit) {
- this.multipleLimit = multipleLimit;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getAutocomplete() {
- return autocomplete;
- }
-
- public void setAutocomplete(String autocomplete) {
- this.autocomplete = autocomplete;
- }
-
- public Boolean getFilterable() {
- return filterable;
- }
-
- public void setFilterable(Boolean filterable) {
- this.filterable = filterable;
- }
-
- public Boolean getAllowCreate() {
- return allowCreate;
- }
-
- public void setAllowCreate(Boolean allowCreate) {
- this.allowCreate = allowCreate;
- }
-
- public String getNoMatchText() {
- return noMatchText;
- }
-
- public void setNoMatchText(String noMatchText) {
- this.noMatchText = noMatchText;
- }
-
- public String getNoDataText() {
- return noDataText;
- }
-
- public void setNoDataText(String noDataText) {
- this.noDataText = noDataText;
- }
-
- public String getPopperClass() {
- return popperClass;
- }
-
- public void setPopperClass(String popperClass) {
- this.popperClass = popperClass;
- }
-
- public Boolean getReserveKeyword() {
- return reserveKeyword;
- }
-
- public void setReserveKeyword(Boolean reserveKeyword) {
- this.reserveKeyword = reserveKeyword;
- }
-
- public Boolean getDefaultFirstOption() {
- return defaultFirstOption;
- }
-
- public void setDefaultFirstOption(Boolean defaultFirstOption) {
- this.defaultFirstOption = defaultFirstOption;
- }
-
- public Boolean getPopperAppendToBody() {
- return popperAppendToBody;
- }
-
- public void setPopperAppendToBody(Boolean popperAppendToBody) {
- this.popperAppendToBody = popperAppendToBody;
- }
-
- public Boolean getAutomaticDropdown() {
- return automaticDropdown;
- }
-
- public void setAutomaticDropdown(Boolean automaticDropdown) {
- this.automaticDropdown = automaticDropdown;
- }
}
diff --git a/dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/constants/StorageConstants.java b/dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/constants/StorageConstants.java
index 576ebe057c..c6a314178b 100644
--- a/dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/constants/StorageConstants.java
+++ b/dolphinscheduler-storage-plugin/dolphinscheduler-storage-api/src/main/java/org/apache/dolphinscheduler/plugin/storage/api/constants/StorageConstants.java
@@ -44,9 +44,6 @@ public final class StorageConstants {
*/
public static final String RESOURCE_UPLOAD_PATH = "resource.storage.upload.base.path";
- /**
- * resource storage type
- */
public static final String RESOURCE_STORAGE_TYPE = "resource.storage.type";
public static final String AWS_S3_BUCKET_NAME = "aws.s3.bucket.name";
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java
index 86199c874e..7abd3a98c5 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java
@@ -49,9 +49,6 @@ import java.util.concurrent.TimeUnit;
import lombok.extern.slf4j.Slf4j;
import io.fabric8.kubernetes.client.dsl.LogWatch;
-/**
- * abstract command executor
- */
@Slf4j
public abstract class AbstractCommandExecutor {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/K8sTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/K8sTaskExecutionContext.java
index 3035752a8b..0c05e02e67 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/K8sTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/K8sTaskExecutionContext.java
@@ -27,9 +27,6 @@ import lombok.NoArgsConstructor;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
-/**
- * k8s Task ExecutionContext
- */
@Data
@Builder
@AllArgsConstructor
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/SQLTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/SQLTaskExecutionContext.java
index 40d9c5632e..e8d66cb258 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/SQLTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/SQLTaskExecutionContext.java
@@ -19,50 +19,17 @@ package org.apache.dolphinscheduler.plugin.task.api;
import java.io.Serializable;
-/**
- * SQL Task ExecutionContext
- */
+import lombok.Data;
+
+@Data
public class SQLTaskExecutionContext implements Serializable {
- /**
- * warningGroupId
- */
private int warningGroupId;
- /**
- * connectionParams
- */
private String connectionParams;
- /**
- * DefaultFS
- */
private String defaultFS;
- public int getWarningGroupId() {
- return warningGroupId;
- }
-
- public void setWarningGroupId(int warningGroupId) {
- this.warningGroupId = warningGroupId;
- }
-
- public String getConnectionParams() {
- return connectionParams;
- }
-
- public void setConnectionParams(String connectionParams) {
- this.connectionParams = connectionParams;
- }
-
- public String getDefaultFS() {
- return defaultFS;
- }
-
- public void setDefaultFS(String defaultFS) {
- this.defaultFS = defaultFS;
- }
-
@Override
public String toString() {
return "SQLTaskExecutionContext{"
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
index 48376e0179..ee917d24ac 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskConstants.java
@@ -38,75 +38,33 @@ public class TaskConstants {
public static final String DATASOURCE_PASSWORD_REGEX =
"(?<=((?i)password((\" : \")|(\":\")|(\\\\\":\\\\\")|(=')))).*?(?=((\")|(\\\\\")|(')))";
- /**
- * exit code kill
- */
public static final int EXIT_CODE_KILL = 137;
public static final int EXIT_CODE_HARD_KILL = 143;
public static final String PID = "pid";
- /**
- * QUESTION ?
- */
public static final String QUESTION = "?";
- /**
- * comma ,
- */
public static final String COMMA = ",";
- /**
- * hyphen
- */
public static final String HYPHEN = "-";
- /**
- * slash /
- */
public static final String SLASH = "/";
- /**
- * COLON :
- */
public static final String COLON = ":";
- /**
- * SPACE " "
- */
public static final String SPACE = " ";
- /**
- * SINGLE_SLASH /
- */
public static final String SINGLE_SLASH = "/";
- /**
- * DOUBLE_SLASH //
- */
public static final String DOUBLE_SLASH = "//";
- /**
- * SINGLE_QUOTES "'"
- */
public static final String SINGLE_QUOTES = "'";
- /**
- * DOUBLE_QUOTES "\""
- */
public static final String DOUBLE_QUOTES = "\"";
- /**
- * SEMICOLON ;
- */
public static final String SEMICOLON = ";";
- /**
- * EQUAL SIGN
- */
public static final String EQUAL_SIGN = "=";
- /**
- * UNDERLINE
- */
public static final String UNDERLINE = "_";
/**
@@ -114,18 +72,9 @@ public class TaskConstants {
*/
public static final int SLEEP_TIME_MILLIS = 1000;
- /**
- * exit code failure
- */
public static final int EXIT_CODE_FAILURE = -1;
- /**
- * exit code success
- */
public static final int EXIT_CODE_SUCCESS = 0;
- /**
- * running code
- */
public static final int RUNNING_CODE = 1;
public static final String SH = "sh";
@@ -212,62 +161,23 @@ public class TaskConstants {
* the name of the project to which current task belongs
*/
public static final String PARAMETER_PROJECT_NAME = "system.project.name";
- /**
- * month_begin
- */
public static final String MONTH_BEGIN = "month_begin";
- /**
- * add_months
- */
public static final String ADD_MONTHS = "add_months";
- /**
- * month_end
- */
public static final String MONTH_END = "month_end";
- /**
- * week_begin
- */
public static final String WEEK_BEGIN = "week_begin";
- /**
- * week_end
- */
public static final String WEEK_END = "week_end";
- /**
- * this_day
- */
public static final String THIS_DAY = "this_day";
- /**
- * last_day
- */
public static final String LAST_DAY = "last_day";
- /**
- * month_first_day
- */
public static final String MONTH_FIRST_DAY = "month_first_day";
- /**
- * month_last_day
- */
public static final String MONTH_LAST_DAY = "month_last_day";
- /**
- * week_first_day
- */
public static final String WEEK_FIRST_DAY = "week_first_day";
- /**
- * week_last_day
- */
public static final String WEEK_LAST_DAY = "week_last_day";
- /**
- * year_week
- */
public static final String YEAR_WEEK = "year_week";
- /**
- * timestamp
- */
public static final String TIMESTAMP = "timestamp";
public static final char SUBTRACT_CHAR = '-';
public static final char ADD_CHAR = '+';
@@ -285,19 +195,10 @@ public class TaskConstants {
public static final String LOCAL_PARAMS_LIST = "localParamsList";
public static final String TASK_TYPE = "taskType";
public static final String QUEUE = "queue";
- /**
- * default display rows
- */
public static final int DEFAULT_DISPLAY_ROWS = 10;
- /**
- * jar
- */
public static final String JAR = "jar";
- /**
- * hadoop
- */
public static final String HADOOP = "hadoop";
/**
@@ -305,14 +206,8 @@ public class TaskConstants {
*/
public static final String D = "-D";
- /**
- * java.security.krb5.conf
- */
public static final String JAVA_SECURITY_KRB5_CONF = "java.security.krb5.conf";
- /**
- * java.security.krb5.conf.path
- */
public static final String JAVA_SECURITY_KRB5_CONF_PATH = "java.security.krb5.conf.path";
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/YarnApplicationManagerContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/YarnApplicationManagerContext.java
index 6bd86f91c2..360df98475 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/YarnApplicationManagerContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/am/YarnApplicationManagerContext.java
@@ -28,14 +28,8 @@ import lombok.ToString;
@AllArgsConstructor
public class YarnApplicationManagerContext implements ApplicationManagerContext {
- /**
- * execute path
- */
private final String executePath;
- /**
- * tenant code
- */
private final String tenantCode;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/TaskTimeoutStrategy.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/TaskTimeoutStrategy.java
index 3d6c27a1aa..e3a1724112 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/TaskTimeoutStrategy.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/TaskTimeoutStrategy.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.plugin.task.api.enums;
import com.baomidou.mybatisplus.annotation.EnumValue;
-/**
- * task timeout strategy
- */
public enum TaskTimeoutStrategy {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ConnectorType.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ConnectorType.java
index 0e81d64f84..7bc1f132a5 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ConnectorType.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ConnectorType.java
@@ -22,9 +22,6 @@ import java.util.Map;
import com.fasterxml.jackson.annotation.JsonValue;
-/**
- * connector type
- */
public enum ConnectorType {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ExecuteSqlType.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ExecuteSqlType.java
index f47cd12478..cde1bda98c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ExecuteSqlType.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/ExecuteSqlType.java
@@ -22,9 +22,6 @@ import java.util.Map;
import com.fasterxml.jackson.annotation.JsonValue;
-/**
- * execute sql type
- */
public enum ExecuteSqlType {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/OperatorType.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/OperatorType.java
index 08e55f6e9d..2fd022e5c2 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/OperatorType.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/OperatorType.java
@@ -22,9 +22,6 @@ import java.util.Map;
import com.fasterxml.jackson.annotation.JsonValue;
-/**
- * operator type
- */
public enum OperatorType {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/RuleType.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/RuleType.java
index 46b42621f0..1987b6558b 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/RuleType.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/enums/dp/RuleType.java
@@ -22,9 +22,6 @@ import java.util.Map;
import com.fasterxml.jackson.annotation.JsonValue;
-/**
- * rule type
- */
public enum RuleType {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/log/TaskLogDiscriminator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/log/TaskLogDiscriminator.java
index 89a11e14fe..005cabb82f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/log/TaskLogDiscriminator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/log/TaskLogDiscriminator.java
@@ -28,9 +28,6 @@ import org.slf4j.MDC;
import ch.qos.logback.classic.spi.ILoggingEvent;
import ch.qos.logback.core.sift.AbstractDiscriminator;
-/**
- * Task Log Discriminator
- */
@Slf4j
@Getter
@Setter
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/DateInterval.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/DateInterval.java
index ad5f34de12..42340c323a 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/DateInterval.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/DateInterval.java
@@ -18,11 +18,10 @@
package org.apache.dolphinscheduler.plugin.task.api.model;
import java.util.Date;
-import java.util.Objects;
-/**
- * date interval class
- */
+import lombok.Data;
+
+@Data
public class DateInterval {
private Date startTime;
@@ -32,38 +31,4 @@ public class DateInterval {
this.startTime = beginTime;
this.endTime = endTime;
}
-
- @Override
- public boolean equals(Object obj) {
- if (obj == null || getClass() != obj.getClass()) {
- return false;
- } else if (this == obj) {
- return true;
- } else {
- DateInterval that = (DateInterval) obj;
- return startTime.equals(that.startTime)
- && endTime.equals(that.endTime);
- }
- }
-
- public Date getStartTime() {
- return startTime;
- }
-
- public void setStartTime(Date startTime) {
- this.startTime = startTime;
- }
-
- public Date getEndTime() {
- return endTime;
- }
-
- public void setEndTime(Date endTime) {
- this.endTime = endTime;
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(startTime, endTime);
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Property.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Property.java
index c7ec6c8599..e96f4020d3 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Property.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Property.java
@@ -49,9 +49,6 @@ public class Property implements Serializable {
*/
private DataType type;
- /**
- * value
- */
private String value;
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskAlertInfo.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskAlertInfo.java
index dc83af2761..e72242e934 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskAlertInfo.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskAlertInfo.java
@@ -17,6 +17,9 @@
package org.apache.dolphinscheduler.plugin.task.api.model;
+import lombok.Data;
+
+@Data
public class TaskAlertInfo {
private String title;
@@ -24,28 +27,4 @@ public class TaskAlertInfo {
private String content;
private Integer alertGroupId;
-
- public String getTitle() {
- return title;
- }
-
- public void setTitle(String title) {
- this.title = title;
- }
-
- public String getContent() {
- return content;
- }
-
- public void setContent(String content) {
- this.content = content;
- }
-
- public Integer getAlertGroupId() {
- return alertGroupId;
- }
-
- public void setAlertGroupId(Integer alertGroupId) {
- this.alertGroupId = alertGroupId;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskResponse.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskResponse.java
index 241f308dea..1bad8bf7e7 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskResponse.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/TaskResponse.java
@@ -44,14 +44,8 @@ public class TaskResponse {
*/
private String appIds;
- /**
- * process
- */
private Process process;
- /**
- * cancel
- */
private volatile boolean cancel = false;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java
index c614bfc15e..32b110255c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/SqlParameters.java
@@ -37,11 +37,14 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
+import lombok.Data;
+
import com.google.common.collect.Lists;
/**
* Sql/Hql parameter
*/
+@Data
public class SqlParameters extends AbstractParameters {
/**
@@ -54,14 +57,8 @@ public class SqlParameters extends AbstractParameters {
*/
private int datasource;
- /**
- * sql
- */
private String sql;
- /**
- * sql source
- */
private SqlSourceType sqlSource;
/**
@@ -76,14 +73,8 @@ public class SqlParameters extends AbstractParameters {
*/
private int sqlType;
- /**
- * send email
- */
private Boolean sendEmail;
- /**
- * display rows
- */
private int displayRows;
/**
@@ -98,146 +89,14 @@ public class SqlParameters extends AbstractParameters {
* SQL connection parameters
*/
private String connParams;
- /**
- * Pre Statements
- */
private List<String> preStatements;
- /**
- * Post Statements
- */
private List<String> postStatements;
- /**
- * groupId
- */
private int groupId;
- /**
- * title
- */
private String title;
private int limit;
- public int getLimit() {
- return limit;
- }
-
- public void setLimit(int limit) {
- this.limit = limit;
- }
-
- public String getType() {
- return type;
- }
-
- public void setType(String type) {
- this.type = type;
- }
-
- public int getDatasource() {
- return datasource;
- }
-
- public void setDatasource(int datasource) {
- this.datasource = datasource;
- }
-
- public String getSql() {
- return sql;
- }
-
- public void setSql(String sql) {
- this.sql = sql;
- }
-
- public SqlSourceType getSqlSource() {
- return sqlSource;
- }
-
- public void setSqlSource(SqlSourceType sqlSource) {
- this.sqlSource = sqlSource;
- }
-
- public String getSqlResource() {
- return sqlResource;
- }
-
- public void setSqlResource(String sqlResource) {
- this.sqlResource = sqlResource;
- }
-
- public int getSqlType() {
- return sqlType;
- }
-
- public void setSqlType(int sqlType) {
- this.sqlType = sqlType;
- }
-
- public Boolean getSendEmail() {
- return sendEmail;
- }
-
- public void setSendEmail(Boolean sendEmail) {
- this.sendEmail = sendEmail;
- }
-
- public int getDisplayRows() {
- return displayRows;
- }
-
- public void setDisplayRows(int displayRows) {
- this.displayRows = displayRows;
- }
-
- public String getShowType() {
- return showType;
- }
-
- public void setShowType(String showType) {
- this.showType = showType;
- }
-
- public String getConnParams() {
- return connParams;
- }
-
- public void setConnParams(String connParams) {
- this.connParams = connParams;
- }
-
- public String getTitle() {
- return title;
- }
-
- public void setTitle(String title) {
- this.title = title;
- }
-
- public List<String> getPreStatements() {
- return preStatements;
- }
-
- public void setPreStatements(List<String> preStatements) {
- this.preStatements = preStatements;
- }
-
- public List<String> getPostStatements() {
- return postStatements;
- }
-
- public void setPostStatements(List<String> postStatements) {
- this.postStatements = postStatements;
- }
-
- public int getGroupId() {
- return groupId;
- }
-
- public void setGroupId(int groupId) {
- this.groupId = groupId;
- }
-
@Override
public boolean checkParameters() {
if (datasource == 0 || StringUtils.isEmpty(type)) {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/TaskTimeoutParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/TaskTimeoutParameter.java
index 94aa7a3279..2644c39264 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/TaskTimeoutParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/TaskTimeoutParameter.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.plugin.task.api.parameters;
import org.apache.dolphinscheduler.plugin.task.api.enums.TaskTimeoutStrategy;
-/**
- * task timeout parameter
- */
public class TaskTimeoutParameter {
private boolean enable;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/PlaceholderUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/PlaceholderUtils.java
index c19b7ea456..3d49ed7344 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/PlaceholderUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/PlaceholderUtils.java
@@ -21,9 +21,6 @@ import java.util.Map;
import lombok.extern.slf4j.Slf4j;
-/**
- * placeholder utils
- */
@Slf4j
public class PlaceholderUtils {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/TimePlaceholderUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/TimePlaceholderUtils.java
index 24bb791870..fc72120b48 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/TimePlaceholderUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parser/TimePlaceholderUtils.java
@@ -65,9 +65,6 @@ import java.util.Stack;
import lombok.extern.slf4j.Slf4j;
-/**
- * time place holder utils
- */
@Slf4j
public class TimePlaceholderUtils {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/PropertyUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/PropertyUtils.java
index 6883a444d4..6270fd6a1c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/PropertyUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/PropertyUtils.java
@@ -26,9 +26,6 @@ import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
-/**
- * property utils
- */
public class PropertyUtils {
private PropertyUtils() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunConstants.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunConstants.java
index c16f0b4e7b..74296f3d80 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunConstants.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunConstants.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.plugin.task.chunjun;
-/**
- * ChunJun constants
- */
public class ChunJunConstants {
public static final String FLINK_CONF_DIR = "${FLINK_HOME}/conf";
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunParameters.java
index 4bbcd28771..7550a8a6fa 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunParameters.java
@@ -28,15 +28,10 @@ import org.apache.commons.lang3.StringUtils;
import java.util.ArrayList;
import java.util.List;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.ToString;
-/**
- * chunjun parameters
- */
-@Setter
-@Getter
+@Data
@ToString
public class ChunJunParameters extends AbstractParameters {
@@ -90,14 +85,8 @@ public class ChunJunParameters extends AbstractParameters {
*/
private String targetTable;
- /**
- * pre statements
- */
private List<String> preStatements;
- /**
- * post statements
- */
private List<String> postStatements;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTask.java
index 28c4585372..a41549f8c9 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTask.java
@@ -50,9 +50,6 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j
public class ChunJunTask extends AbstractTask {
- /**
- * chunjun path
- */
private static final String CHUNJUN_PATH = "${CHUNJUN_HOME}/bin/start-chunjun";
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTaskChannelFactory.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTaskChannelFactory.java
index b1465d723a..1bea680bd2 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTaskChannelFactory.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-chunjun/src/main/java/org/apache/dolphinscheduler/plugin/task/chunjun/ChunJunTaskChannelFactory.java
@@ -22,9 +22,6 @@ import org.apache.dolphinscheduler.plugin.task.api.TaskChannelFactory;
import com.google.auto.service.AutoService;
-/**
- * chunjun task channelFactory
- */
@AutoService(TaskChannelFactory.class)
public class ChunJunTaskChannelFactory implements TaskChannelFactory {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-datafactory/src/main/java/org/apache/dolphinscheduler/plugin/task/datafactory/DatafactoryParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-datafactory/src/main/java/org/apache/dolphinscheduler/plugin/task/datafactory/DatafactoryParameters.java
index b0bbb75e8d..81ee8a2141 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-datafactory/src/main/java/org/apache/dolphinscheduler/plugin/task/datafactory/DatafactoryParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-datafactory/src/main/java/org/apache/dolphinscheduler/plugin/task/datafactory/DatafactoryParameters.java
@@ -21,13 +21,11 @@ import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters
import org.apache.commons.lang3.StringUtils;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
import lombok.ToString;
-@Setter
-@Getter
+@Data
@NoArgsConstructor
@ToString
public class DatafactoryParameters extends AbstractParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-datasync/src/main/java/org/apache/dolphinscheduler/plugin/task/datasync/DatasyncParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-datasync/src/main/java/org/apache/dolphinscheduler/plugin/task/datasync/DatasyncParameters.java
index 5570311223..0019d9ca3e 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-datasync/src/main/java/org/apache/dolphinscheduler/plugin/task/datasync/DatasyncParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-datasync/src/main/java/org/apache/dolphinscheduler/plugin/task/datasync/DatasyncParameters.java
@@ -23,15 +23,13 @@ import org.apache.commons.lang3.StringUtils;
import java.util.List;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
import lombok.ToString;
import com.fasterxml.jackson.annotation.JsonProperty;
-@Setter
-@Getter
+@Data
@NoArgsConstructor
@ToString
public class DatasyncParameters extends AbstractParameters {
@@ -64,8 +62,7 @@ public class DatasyncParameters extends AbstractParameters {
}
}
- @Setter
- @Getter
+ @Data
@NoArgsConstructor
@ToString
public class Options {
@@ -86,16 +83,14 @@ public class DatasyncParameters extends AbstractParameters {
private String securityDescriptorCopyFlags;
private String objectTags;
}
- @Setter
- @Getter
+ @Data
@NoArgsConstructor
@ToString
public static class TaskSchedule {
private String scheduleExpression;
}
- @Setter
- @Getter
+ @Data
@NoArgsConstructor
@ToString
public static class FilterRule {
@@ -103,8 +98,7 @@ public class DatasyncParameters extends AbstractParameters {
private String filterType;
private String value;
}
- @Setter
- @Getter
+ @Data
@NoArgsConstructor
@ToString
public static class TagListEntry {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxParameters.java
index 0609bb4bcd..9d9722bc6f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxParameters.java
@@ -30,9 +30,12 @@ import org.apache.commons.lang3.StringUtils;
import java.util.List;
import java.util.Objects;
+import lombok.Data;
+
/**
* DataX parameter
*/
+@Data
public class DataxParameters extends AbstractParameters {
/**
@@ -65,24 +68,12 @@ public class DataxParameters extends AbstractParameters {
*/
private int dataTarget;
- /**
- * sql
- */
private String sql;
- /**
- * target table
- */
private String targetTable;
- /**
- * Pre Statements
- */
private List<String> preStatements;
- /**
- * Post Statements
- */
private List<String> postStatements;
/**
@@ -110,139 +101,8 @@ public class DataxParameters extends AbstractParameters {
*/
private int xmx;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList;
- public int getCustomConfig() {
- return customConfig;
- }
-
- public void setCustomConfig(int customConfig) {
- this.customConfig = customConfig;
- }
-
- public String getJson() {
- return json;
- }
-
- public void setJson(String json) {
- this.json = json;
- }
-
- public String getDsType() {
- return dsType;
- }
-
- public void setDsType(String dsType) {
- this.dsType = dsType;
- }
-
- public int getDataSource() {
- return dataSource;
- }
-
- public void setDataSource(int dataSource) {
- this.dataSource = dataSource;
- }
-
- public String getDtType() {
- return dtType;
- }
-
- public void setDtType(String dtType) {
- this.dtType = dtType;
- }
-
- public int getDataTarget() {
- return dataTarget;
- }
-
- public void setDataTarget(int dataTarget) {
- this.dataTarget = dataTarget;
- }
-
- public String getSql() {
- return sql;
- }
-
- public void setSql(String sql) {
- this.sql = sql;
- }
-
- public String getTargetTable() {
- return targetTable;
- }
-
- public void setTargetTable(String targetTable) {
- this.targetTable = targetTable;
- }
-
- public List<String> getPreStatements() {
- return preStatements;
- }
-
- public void setPreStatements(List<String> preStatements) {
- this.preStatements = preStatements;
- }
-
- public List<String> getPostStatements() {
- return postStatements;
- }
-
- public void setPostStatements(List<String> postStatements) {
- this.postStatements = postStatements;
- }
-
- public int getJobSpeedByte() {
- return jobSpeedByte;
- }
-
- public void setJobSpeedByte(int jobSpeedByte) {
- this.jobSpeedByte = jobSpeedByte;
- }
-
- public int getJobSpeedRecord() {
- return jobSpeedRecord;
- }
-
- public void setJobSpeedRecord(int jobSpeedRecord) {
- this.jobSpeedRecord = jobSpeedRecord;
- }
-
- public int getJobChannel() {
- return jobChannel;
- }
-
- public void setJobChannel(int jobChannel) {
- this.jobChannel = jobChannel;
- }
-
- public int getXms() {
- return xms;
- }
-
- public void setXms(int xms) {
- this.xms = xms;
- }
-
- public int getXmx() {
- return xmx;
- }
-
- public void setXmx(int xmx) {
- this.xmx = xmx;
- }
-
- public List<ResourceInfo> getResourceList() {
- return resourceList;
- }
-
- public void setResourceList(List<ResourceInfo> resourceList) {
- this.resourceList = resourceList;
- }
-
@Override
public boolean checkParameters() {
if (customConfig == Flag.NO.ordinal()) {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java
index d9e0bd27fe..a8c39a3a50 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java
@@ -91,17 +91,11 @@ public class DataxTask extends AbstractTask {
*/
private static final String SELECT_ALL_CHARACTER = "*";
- /**
- * post jdbc info regex
- */
private static final String POST_JDBC_INFO_REGEX = "(?<=(post jdbc info:)).*(?=)";
/**
* datax path
*/
private static final String DATAX_LAUNCHER = "${DATAX_LAUNCHER}";
- /**
- * datax channel count
- */
private static final int DATAX_CHANNEL_COUNT = 1;
private DataxParameters dataXParameters;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTaskExecutionContext.java
index fae66c8fd6..247e7264ef 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTaskExecutionContext.java
@@ -21,89 +21,26 @@ import org.apache.dolphinscheduler.spi.enums.DbType;
import java.io.Serializable;
+import lombok.Data;
+
/**
* master/worker task transport
*/
+@Data
public class DataxTaskExecutionContext implements Serializable {
- /**
- * dataSourceId
- */
private int dataSourceId;
- /**
- * sourcetype
- */
private DbType sourcetype;
- /**
- * sourceConnectionParams
- */
private String sourceConnectionParams;
- /**
- * dataTargetId
- */
private int dataTargetId;
- /**
- * targetType
- */
private DbType targetType;
- /**
- * targetConnectionParams
- */
private String targetConnectionParams;
- public int getDataSourceId() {
- return dataSourceId;
- }
-
- public void setDataSourceId(int dataSourceId) {
- this.dataSourceId = dataSourceId;
- }
-
- public DbType getSourcetype() {
- return sourcetype;
- }
-
- public void setSourcetype(DbType sourcetype) {
- this.sourcetype = sourcetype;
- }
-
- public String getSourceConnectionParams() {
- return sourceConnectionParams;
- }
-
- public void setSourceConnectionParams(String sourceConnectionParams) {
- this.sourceConnectionParams = sourceConnectionParams;
- }
-
- public int getDataTargetId() {
- return dataTargetId;
- }
-
- public void setDataTargetId(int dataTargetId) {
- this.dataTargetId = dataTargetId;
- }
-
- public DbType getTargetType() {
- return targetType;
- }
-
- public void setTargetType(DbType targetType) {
- this.targetType = targetType;
- }
-
- public String getTargetConnectionParams() {
- return targetConnectionParams;
- }
-
- public void setTargetConnectionParams(String targetConnectionParams) {
- this.targetConnectionParams = targetConnectionParams;
- }
-
@Override
public String toString() {
return "DataxTaskExecutionContext{"
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyParameters.java
index 88d83e4bbf..7bdec22736 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-dinky/src/main/java/org/apache/dolphinscheduler/plugin/task/dinky/DinkyParameters.java
@@ -25,6 +25,9 @@ import org.apache.commons.lang3.StringUtils;
import java.util.Collections;
import java.util.List;
+import lombok.Data;
+
+@Data
public class DinkyParameters extends AbstractParameters {
/**
@@ -46,30 +49,6 @@ public class DinkyParameters extends AbstractParameters {
return Collections.emptyList();
}
- public String getAddress() {
- return address;
- }
-
- public void setAddress(String address) {
- this.address = address;
- }
-
- public String getTaskId() {
- return taskId;
- }
-
- public void setTaskId(String taskId) {
- this.taskId = taskId;
- }
-
- public boolean isOnline() {
- return online;
- }
-
- public void setOnline(boolean online) {
- this.online = online;
- }
-
@Override
public String toString() {
return "DinkyParameters{" +
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-dms/src/main/java/org/apache/dolphinscheduler/plugin/task/dms/DmsTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-dms/src/main/java/org/apache/dolphinscheduler/plugin/task/dms/DmsTask.java
index 29424a5b76..d8568703d3 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-dms/src/main/java/org/apache/dolphinscheduler/plugin/task/dms/DmsTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-dms/src/main/java/org/apache/dolphinscheduler/plugin/task/dms/DmsTask.java
@@ -54,9 +54,6 @@ public class DmsTask extends AbstractRemoteTask {
.configure(REQUIRE_SETTERS_FOR_GETTERS, true)
.propertyNamingStrategy(new PropertyNamingStrategy.UpperCamelCaseStrategy())
.build();
- /**
- * taskExecutionContext
- */
private final TaskExecutionContext taskExecutionContext;
public DmsHook dmsHook;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkStreamParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkStreamParameters.java
index 54bac1ba95..86954b403d 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkStreamParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkStreamParameters.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.plugin.task.flink;
-/**
- * flink stream parameters
- */
public class FlinkStreamParameters extends FlinkParameters {
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java
index 0e8bc95812..5f705779cf 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtils.java
@@ -31,9 +31,6 @@ import java.util.List;
import java.util.Map;
import java.util.Optional;
-/**
- * flink args utils
- */
public class FlinkArgsUtils {
private FlinkArgsUtils() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkDeployMode.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkDeployMode.java
index b622fde2aa..067598dddb 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkDeployMode.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkDeployMode.java
@@ -19,9 +19,6 @@ package org.apache.dolphinscheduler.plugin.task.flink;
import com.fasterxml.jackson.annotation.JsonProperty;
-/**
- * Flink deploy mode
- */
public enum FlinkDeployMode {
@JsonProperty("local")
LOCAL,
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java
index 61ad5d4772..fe808fcb9a 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java
@@ -23,9 +23,9 @@ import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters
import java.util.ArrayList;
import java.util.List;
-/**
- * flink parameters
- */
+import lombok.Data;
+
+@Data
public class FlinkParameters extends AbstractParameters {
/**
@@ -53,9 +53,6 @@ public class FlinkParameters extends AbstractParameters {
*/
private int slot;
- /**
- * parallelism
- */
private int parallelism;
/**
@@ -68,19 +65,10 @@ public class FlinkParameters extends AbstractParameters {
*/
private int taskManager;
- /**
- * job manager memory
- */
private String jobManagerMemory;
- /**
- * task manager memory
- */
private String taskManagerMemory;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList = new ArrayList<>();
/**
@@ -93,9 +81,6 @@ public class FlinkParameters extends AbstractParameters {
*/
private String others;
- /**
- * flink version
- */
private String flinkVersion;
/**
@@ -114,142 +99,6 @@ public class FlinkParameters extends AbstractParameters {
*/
private String rawScript;
- public ResourceInfo getMainJar() {
- return mainJar;
- }
-
- public void setMainJar(ResourceInfo mainJar) {
- this.mainJar = mainJar;
- }
-
- public String getMainClass() {
- return mainClass;
- }
-
- public void setMainClass(String mainClass) {
- this.mainClass = mainClass;
- }
-
- public FlinkDeployMode getDeployMode() {
- return deployMode;
- }
-
- public void setDeployMode(FlinkDeployMode deployMode) {
- this.deployMode = deployMode;
- }
-
- public String getMainArgs() {
- return mainArgs;
- }
-
- public void setMainArgs(String mainArgs) {
- this.mainArgs = mainArgs;
- }
-
- public int getSlot() {
- return slot;
- }
-
- public void setSlot(int slot) {
- this.slot = slot;
- }
-
- public int getParallelism() {
- return parallelism;
- }
-
- public void setParallelism(int parallelism) {
- this.parallelism = parallelism;
- }
-
- public String getAppName() {
- return appName;
- }
-
- public void setAppName(String appName) {
- this.appName = appName;
- }
-
- public int getTaskManager() {
- return taskManager;
- }
-
- public void setTaskManager(int taskManager) {
- this.taskManager = taskManager;
- }
-
- public String getJobManagerMemory() {
- return jobManagerMemory;
- }
-
- public void setJobManagerMemory(String jobManagerMemory) {
- this.jobManagerMemory = jobManagerMemory;
- }
-
- public String getTaskManagerMemory() {
- return taskManagerMemory;
- }
-
- public void setTaskManagerMemory(String taskManagerMemory) {
- this.taskManagerMemory = taskManagerMemory;
- }
-
- public String getYarnQueue() {
- return yarnQueue;
- }
-
- public void setYarnQueue(String yarnQueue) {
- this.yarnQueue = yarnQueue;
- }
-
- public List<ResourceInfo> getResourceList() {
- return resourceList;
- }
-
- public void setResourceList(List<ResourceInfo> resourceList) {
- this.resourceList = resourceList;
- }
-
- public String getOthers() {
- return others;
- }
-
- public void setOthers(String others) {
- this.others = others;
- }
-
- public ProgramType getProgramType() {
- return programType;
- }
-
- public void setProgramType(ProgramType programType) {
- this.programType = programType;
- }
-
- public String getFlinkVersion() {
- return flinkVersion;
- }
-
- public void setFlinkVersion(String flinkVersion) {
- this.flinkVersion = flinkVersion;
- }
-
- public String getInitScript() {
- return initScript;
- }
-
- public void setInitScript(String initScript) {
- this.initScript = initScript;
- }
-
- public String getRawScript() {
- return rawScript;
- }
-
- public void setRawScript(String rawScript) {
- this.rawScript = rawScript;
- }
-
@Override
public boolean checkParameters() {
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkTask.java
index 6f49ea75c5..baa9e5fd63 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkTask.java
@@ -38,14 +38,8 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j
public class FlinkTask extends AbstractYarnTask {
- /**
- * flink parameters
- */
private FlinkParameters flinkParameters;
- /**
- * taskExecutionContext
- */
private TaskExecutionContext taskExecutionContext;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protobufjs/mapping/Field.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protobufjs/mapping/Field.java
index e1aebd2b84..e0515805ea 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protobufjs/mapping/Field.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-grpc/src/main/java/org/apache/dolphinscheduler/plugin/task/grpc/protobufjs/mapping/Field.java
@@ -18,8 +18,6 @@
package org.apache.dolphinscheduler.plugin.task.grpc.protobufjs.mapping;
import lombok.Data;
-import lombok.Getter;
-import lombok.Setter;
import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
@@ -32,8 +30,6 @@ import com.fasterxml.jackson.databind.JsonNode;
})
public class Field extends ReflectionObject {
- @Getter
- @Setter
private JsonNode rule;
private String type;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpCheckCondition.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpCheckCondition.java
index 479540a1f5..197a93b30f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpCheckCondition.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpCheckCondition.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.plugin.task.http;
-/**
- * http check condition
- */
public enum HttpCheckCondition {
/**
* 0 status_code_default:200
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParametersType.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParametersType.java
index 37817aebef..af6643365f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParametersType.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-http/src/main/java/org/apache/dolphinscheduler/plugin/task/http/HttpParametersType.java
@@ -17,9 +17,6 @@
package org.apache.dolphinscheduler.plugin.task.http;
-/**
- * http parameters type
- */
public enum HttpParametersType {
PARAMETER, HEADERS
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
index 4137eb733e..4b456cd463 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
@@ -59,9 +59,6 @@ public class JavaParameters extends AbstractParameters {
**/
private String mainClass;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java
index 7585311eb3..06e14fe998 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterConstants.java
@@ -28,19 +28,10 @@ public class JupyterConstants {
*/
public static final String EXECUTION_FLAG = "set +e";
- /**
- * new line symbol
- */
public static final String NEW_LINE_SYMBOL = "\n";
- /**
- * conda init
- */
public static final String CONDA_INIT = "source";
- /**
- * conda activate
- */
public static final String CONDA_ACTIVATE = "conda activate";
/**
@@ -77,9 +68,6 @@ public class JupyterConstants {
*/
public static final String JOINTER = "&&";
- /**
- * papermill
- */
public static final String PAPERMILL = "papermill";
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-linkis/src/main/java/org/apache/dolphinscheduler/plugin/task/linkis/LinkisParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-linkis/src/main/java/org/apache/dolphinscheduler/plugin/task/linkis/LinkisParameters.java
index f602d5d7c2..82c577e99f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-linkis/src/main/java/org/apache/dolphinscheduler/plugin/task/linkis/LinkisParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-linkis/src/main/java/org/apache/dolphinscheduler/plugin/task/linkis/LinkisParameters.java
@@ -25,8 +25,6 @@ import org.apache.commons.lang3.StringUtils;
import java.util.List;
import lombok.Data;
-import lombok.Getter;
-import lombok.Setter;
@Data
public class LinkisParameters extends AbstractParameters {
@@ -37,8 +35,7 @@ public class LinkisParameters extends AbstractParameters {
private String rawScript;
- @Getter
- @Setter
+ @Data
public static class Param {
private String props;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceArgsUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceArgsUtils.java
index dfa08db1e5..30244a0642 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceArgsUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceArgsUtils.java
@@ -32,9 +32,6 @@ import org.apache.commons.lang3.StringUtils;
import java.util.ArrayList;
import java.util.List;
-/**
- * mapreduce args utils
- */
public class MapReduceArgsUtils {
private MapReduceArgsUtils() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceParameters.java
index 8d63b6c9fb..9154428028 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-mr/src/main/java/org/apache/dolphinscheduler/plugin/task/mr/MapReduceParameters.java
@@ -23,9 +23,9 @@ import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters
import java.util.ArrayList;
import java.util.List;
-/**
- * mapreduce parameters
- */
+import lombok.Data;
+
+@Data
public class MapReduceParameters extends AbstractParameters {
/**
@@ -48,9 +48,6 @@ public class MapReduceParameters extends AbstractParameters {
*/
private String others;
- /**
- * app name
- */
private String appName;
/**
@@ -58,9 +55,6 @@ public class MapReduceParameters extends AbstractParameters {
*/
private String yarnQueue;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList = new ArrayList<>();
/**
@@ -69,70 +63,6 @@ public class MapReduceParameters extends AbstractParameters {
*/
private ProgramType programType;
- public String getMainClass() {
- return mainClass;
- }
-
- public void setMainClass(String mainClass) {
- this.mainClass = mainClass;
- }
-
- public String getMainArgs() {
- return mainArgs;
- }
-
- public void setMainArgs(String mainArgs) {
- this.mainArgs = mainArgs;
- }
-
- public String getOthers() {
- return others;
- }
-
- public void setOthers(String others) {
- this.others = others;
- }
-
- public String getAppName() {
- return appName;
- }
-
- public void setAppName(String appName) {
- this.appName = appName;
- }
-
- public String getYarnQueue() {
- return yarnQueue;
- }
-
- public void setYarnQueue(String yarnQueue) {
- this.yarnQueue = yarnQueue;
- }
-
- public List<ResourceInfo> getResourceList() {
- return this.resourceList;
- }
-
- public void setResourceList(List<ResourceInfo> resourceList) {
- this.resourceList = resourceList;
- }
-
- public void setMainJar(ResourceInfo mainJar) {
- this.mainJar = mainJar;
- }
-
- public ResourceInfo getMainJar() {
- return mainJar;
- }
-
- public ProgramType getProgramType() {
- return programType;
- }
-
- public void setProgramType(ProgramType programType) {
- this.programType = programType;
- }
-
@Override
public boolean checkParameters() {
return this.mainJar != null && this.programType != null;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-openmldb/src/main/java/org/apache/dolphinscheduler/plugin/task/openmldb/OpenmldbParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-openmldb/src/main/java/org/apache/dolphinscheduler/plugin/task/openmldb/OpenmldbParameters.java
index a8685e45c8..b94d9d8c4e 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-openmldb/src/main/java/org/apache/dolphinscheduler/plugin/task/openmldb/OpenmldbParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-openmldb/src/main/java/org/apache/dolphinscheduler/plugin/task/openmldb/OpenmldbParameters.java
@@ -21,6 +21,9 @@ import org.apache.dolphinscheduler.plugin.task.python.PythonParameters;
import org.apache.commons.lang3.StringUtils;
+import lombok.Data;
+
+@Data
public class OpenmldbParameters extends PythonParameters {
private String zk;
@@ -31,38 +34,6 @@ public class OpenmldbParameters extends PythonParameters {
*/
private String sql;
- public String getZk() {
- return zk;
- }
-
- public void setZk(String zk) {
- this.zk = zk;
- }
-
- public String getZkPath() {
- return zkPath;
- }
-
- public void setZkPath(String zkPath) {
- this.zkPath = zkPath;
- }
-
- public String getExecuteMode() {
- return executeMode;
- }
-
- public void setExecuteMode(String executeMode) {
- this.executeMode = executeMode;
- }
-
- public String getSql() {
- return sql;
- }
-
- public void setSql(String sql) {
- this.sql = sql;
- }
-
@Override
public boolean checkParameters() {
return StringUtils.isNotEmpty(zk) && StringUtils.isNotEmpty(zkPath) && StringUtils.isNotEmpty(sql);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureTaskExecutionContext.java
index 08620df412..2ce9bac63f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-procedure/src/main/java/org/apache/dolphinscheduler/plugin/task/procedure/ProcedureTaskExecutionContext.java
@@ -19,24 +19,16 @@ package org.apache.dolphinscheduler.plugin.task.procedure;
import java.io.Serializable;
+import lombok.Data;
+
/**
* master/worker task transport
*/
+@Data
public class ProcedureTaskExecutionContext implements Serializable {
- /**
- * connectionParams
- */
private String connectionParams;
- public String getConnectionParams() {
- return connectionParams;
- }
-
- public void setConnectionParams(String connectionParams) {
- this.connectionParams = connectionParams;
- }
-
@Override
public String toString() {
return "ProcedureTaskExecutionContext{"
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonParameters.java
index d9fb27870d..e05bac34fd 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonParameters.java
@@ -22,6 +22,9 @@ import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters
import java.util.List;
+import lombok.Data;
+
+@Data
public class PythonParameters extends AbstractParameters {
/**
@@ -29,27 +32,8 @@ public class PythonParameters extends AbstractParameters {
*/
private String rawScript;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList;
- public String getRawScript() {
- return rawScript;
- }
-
- public void setRawScript(String rawScript) {
- this.rawScript = rawScript;
- }
-
- public List<ResourceInfo> getResourceList() {
- return resourceList;
- }
-
- public void setResourceList(List<ResourceInfo> resourceList) {
- this.resourceList = resourceList;
- }
-
@Override
public boolean checkParameters() {
return rawScript != null && !rawScript.isEmpty();
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteShellTask.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteShellTask.java
index 6c55f069e1..6dc82d7d15 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteShellTask.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-remoteshell/src/main/java/org/apache/dolphinscheduler/plugin/task/remoteshell/RemoteShellTask.java
@@ -54,9 +54,6 @@ public class RemoteShellTask extends AbstractTask {
*/
private RemoteShellParameters remoteShellParameters;
- /**
- * taskExecutionContext
- */
private TaskExecutionContext taskExecutionContext;
private RemoteExecutor remoteExecutor;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerParameters.java
index 4d2c1cace4..c14502d64a 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerParameters.java
@@ -26,13 +26,11 @@ import org.apache.commons.lang3.StringUtils;
import java.util.Objects;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
-@Getter
-@Setter
+@Data
@ToString
@Slf4j
public class SagemakerParameters extends AbstractParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskExecutionContext.java
index 68b3590663..f75bd5c827 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sagemaker/src/main/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskExecutionContext.java
@@ -19,25 +19,17 @@ package org.apache.dolphinscheduler.plugin.task.sagemaker;
import java.io.Serializable;
+import lombok.Data;
+
/**
* master/worker task transport
*/
+@Data
public class SagemakerTaskExecutionContext implements Serializable {
- /**
- * connectionParams
- */
private String connectionParams;
- public String getConnectionParams() {
- return connectionParams;
- }
-
- public void setConnectionParams(String connectionParams) {
- this.connectionParams = connectionParams;
- }
-
@Override
public String toString() {
return "SagemakerTaskExecutionContext{" + "connectionParams='" + connectionParams + '\'' + '}';
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelParameters.java
index 6f7223fc60..11af6d5082 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/SeatunnelParameters.java
@@ -27,12 +27,10 @@ import org.apache.commons.lang3.StringUtils;
import java.util.List;
import java.util.regex.Pattern;
-import lombok.Getter;
+import lombok.Data;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@Data
@NoArgsConstructor
public class SeatunnelParameters extends AbstractParameters {
@@ -44,9 +42,6 @@ public class SeatunnelParameters extends AbstractParameters {
private String rawScript;
- /**
- * resource list
- */
private List<ResourceInfo> resourceList;
@Override
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
index e546f0f5ee..51a01b335e 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/flink/SeatunnelFlinkParameters.java
@@ -19,12 +19,11 @@ package org.apache.dolphinscheduler.plugin.task.seatunnel.flink;
import org.apache.dolphinscheduler.plugin.task.seatunnel.SeatunnelParameters;
+import lombok.Data;
import lombok.Getter;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@Data
@NoArgsConstructor
public class SeatunnelFlinkParameters extends SeatunnelParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineParameters.java
index c93743a266..e7a30f3c2a 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/self/SeatunnelEngineParameters.java
@@ -21,12 +21,12 @@ import org.apache.dolphinscheduler.plugin.task.seatunnel.DeployModeEnum;
import org.apache.dolphinscheduler.plugin.task.seatunnel.SeatunnelParameters;
import lombok.AllArgsConstructor;
-import lombok.Getter;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@EqualsAndHashCode(callSuper = true)
+@Data
@NoArgsConstructor
@AllArgsConstructor
public class SeatunnelEngineParameters extends SeatunnelParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkParameters.java
index 1567fe6a09..160c49724c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-seatunnel/src/main/java/org/apache/dolphinscheduler/plugin/task/seatunnel/spark/SeatunnelSparkParameters.java
@@ -24,12 +24,13 @@ import org.apache.commons.lang3.StringUtils;
import java.util.Objects;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
import lombok.Getter;
import lombok.NoArgsConstructor;
-import lombok.Setter;
-@Getter
-@Setter
+@EqualsAndHashCode(callSuper = true)
+@Data
@NoArgsConstructor
public class SeatunnelSparkParameters extends SeatunnelParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java
index 42ad537f95..dee73d10ea 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-shell/src/main/java/org/apache/dolphinscheduler/plugin/task/shell/ShellParameters.java
@@ -22,11 +22,9 @@ import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters
import java.util.List;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
-@Getter
-@Setter
+@Data
public class ShellParameters extends AbstractParameters {
private String rawScript;
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkConstants.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkConstants.java
index c76436766e..ad6dba8c90 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkConstants.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkConstants.java
@@ -52,9 +52,6 @@ public class SparkConstants {
*/
public static final String DRIVER_MEMORY = "--conf spark.driver.memory=%s";
- /**
- * master
- */
public static final String MASTER = "--master";
public static final String SPARK_ON_YARN = "yarn";
@@ -66,9 +63,6 @@ public class SparkConstants {
*/
public static final String DRIVER_LABEL_CONF = "--conf spark.kubernetes.driver.label.%s=%s";
- /**
- * spark kubernetes namespace
- */
public static final String SPARK_KUBERNETES_NAMESPACE = "--conf spark.kubernetes.namespace=%s";
/**
@@ -96,9 +90,6 @@ public class SparkConstants {
*/
public static final String SPARK_SQL_COMMAND = "${SPARK_HOME}/bin/spark-sql";
- /**
- * spark submit command
- */
public static final String SPARK_SUBMIT_COMMAND = "${SPARK_HOME}/bin/spark-submit";
public static final String TYPE_SCRIPT = "SCRIPT";
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkParameters.java
index 873ba22c71..93b1455b41 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-spark/src/main/java/org/apache/dolphinscheduler/plugin/task/spark/SparkParameters.java
@@ -28,14 +28,8 @@ import lombok.Data;
@Data
public class SparkParameters extends AbstractParameters {
- /**
- * main jar
- */
private ResourceInfo mainJar;
- /**
- * main class
- */
private String mainClass;
/**
@@ -79,9 +73,6 @@ public class SparkParameters extends AbstractParameters {
*/
private String executorMemory;
- /**
- * app name
- */
private String appName;
/**
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopTaskExecutionContext.java
index d999932356..8c58aa5dcf 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopTaskExecutionContext.java
@@ -21,7 +21,10 @@ import org.apache.dolphinscheduler.spi.enums.DbType;
import java.io.Serializable;
+import lombok.Data;
+
/** master/worker task transport */
+@Data
public class SqoopTaskExecutionContext implements Serializable {
/** dataSourceId */
@@ -42,54 +45,6 @@ public class SqoopTaskExecutionContext implements Serializable {
/** targetConnectionParams */
private String targetConnectionParams;
- public int getDataSourceId() {
- return dataSourceId;
- }
-
- public void setDataSourceId(int dataSourceId) {
- this.dataSourceId = dataSourceId;
- }
-
- public DbType getSourcetype() {
- return sourcetype;
- }
-
- public void setSourcetype(DbType sourcetype) {
- this.sourcetype = sourcetype;
- }
-
- public String getSourceConnectionParams() {
- return sourceConnectionParams;
- }
-
- public void setSourceConnectionParams(String sourceConnectionParams) {
- this.sourceConnectionParams = sourceConnectionParams;
- }
-
- public int getDataTargetId() {
- return dataTargetId;
- }
-
- public void setDataTargetId(int dataTargetId) {
- this.dataTargetId = dataTargetId;
- }
-
- public DbType getTargetType() {
- return targetType;
- }
-
- public void setTargetType(DbType targetType) {
- this.targetType = targetType;
- }
-
- public String getTargetConnectionParams() {
- return targetConnectionParams;
- }
-
- public void setTargetConnectionParams(String targetConnectionParams) {
- this.targetConnectionParams = targetConnectionParams;
- }
-
@Override
public String toString() {
return "SqoopTaskExecutionContext{"
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/HanaSourceGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/HanaSourceGenerator.java
index 4b5f140037..79edb0a018 100755
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/HanaSourceGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/HanaSourceGenerator.java
@@ -53,9 +53,6 @@ import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * hana source generator
- */
public class HanaSourceGenerator implements ISourceGenerator {
private static final Logger logger = LoggerFactory.getLogger(HanaSourceGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/MySQLSourceGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/MySQLSourceGenerator.java
index 5a1e306f09..0da21ec4db 100755
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/MySQLSourceGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/MySQLSourceGenerator.java
@@ -52,9 +52,6 @@ import java.util.List;
import lombok.extern.slf4j.Slf4j;
-/**
- * mysql source generator
- */
@Slf4j
public class MySQLSourceGenerator implements ISourceGenerator {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/OracleSourceGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/OracleSourceGenerator.java
index 8694544180..8fb25b8c66 100755
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/OracleSourceGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/OracleSourceGenerator.java
@@ -52,9 +52,6 @@ import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * oracle source generator
- */
public class OracleSourceGenerator implements ISourceGenerator {
private static final Logger logger = LoggerFactory.getLogger(OracleSourceGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/SqlServerSourceGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/SqlServerSourceGenerator.java
index bb59a4c098..79e7d1c279 100755
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/SqlServerSourceGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/sources/SqlServerSourceGenerator.java
@@ -53,9 +53,6 @@ import java.util.List;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * sqlServer source generator
- */
public class SqlServerSourceGenerator implements ISourceGenerator {
private static final Logger logger = LoggerFactory.getLogger(SqlServerSourceGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HanaTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HanaTargetGenerator.java
index fca1d7eb09..30cddd6673 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HanaTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HanaTargetGenerator.java
@@ -46,9 +46,6 @@ import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * hana target generator
- */
public class HanaTargetGenerator implements ITargetGenerator {
private static final Logger logger = LoggerFactory.getLogger(HanaTargetGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HdfsTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HdfsTargetGenerator.java
index 14afb2305a..5cd6d176f3 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HdfsTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HdfsTargetGenerator.java
@@ -36,9 +36,6 @@ import org.apache.commons.lang3.StringUtils;
import lombok.extern.slf4j.Slf4j;
-/**
- * hdfs target generator
- */
@Slf4j
public class HdfsTargetGenerator implements ITargetGenerator {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HiveTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HiveTargetGenerator.java
index 55b664b6cd..5d5d9f4f1a 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HiveTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/HiveTargetGenerator.java
@@ -40,9 +40,6 @@ import org.apache.commons.lang3.StringUtils;
import lombok.extern.slf4j.Slf4j;
-/**
- * hive target generator
- */
@Slf4j
public class HiveTargetGenerator implements ITargetGenerator {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/MySQLTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/MySQLTargetGenerator.java
index 5de25d3d5b..46881d9198 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/MySQLTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/MySQLTargetGenerator.java
@@ -44,9 +44,6 @@ import org.apache.commons.lang3.StringUtils;
import lombok.extern.slf4j.Slf4j;
-/**
- * mysql target generator
- */
@Slf4j
public class MySQLTargetGenerator implements ITargetGenerator {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/OracleTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/OracleTargetGenerator.java
index 2e1b655ca5..fb394c4822 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/OracleTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/OracleTargetGenerator.java
@@ -45,9 +45,6 @@ import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * oracle target generator
- */
public class OracleTargetGenerator implements ITargetGenerator {
private static final Logger logger = LoggerFactory.getLogger(OracleTargetGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/SqlServerTargetGenerator.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/SqlServerTargetGenerator.java
index dd2ab34269..3c5742a492 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/SqlServerTargetGenerator.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/generator/targets/SqlServerTargetGenerator.java
@@ -45,9 +45,6 @@ import org.apache.commons.lang3.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-/**
- * sqlServer target generator
- */
public class SqlServerTargetGenerator implements ITargetGenerator {
private static final Logger logger = LoggerFactory.getLogger(SqlServerTargetGenerator.class);
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SourceCommonParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SourceCommonParameter.java
index 72116e1207..237710b83f 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SourceCommonParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SourceCommonParameter.java
@@ -17,22 +17,11 @@
package org.apache.dolphinscheduler.plugin.task.sqoop.parameter;
-/**
- * source common parameter
- */
+import lombok.Data;
+
+@Data
public class SourceCommonParameter {
- /**
- * src datasource
- */
protected int srcDatasource;
- public int getSrcDatasource() {
- return srcDatasource;
- }
-
- public void setSrcDatasource(int srcDatasource) {
- this.srcDatasource = srcDatasource;
- }
-
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java
index d2e8bd16d9..33f14686ad 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java
@@ -50,9 +50,9 @@ import org.apache.commons.lang3.StringUtils;
import java.util.List;
import java.util.Objects;
-/**
- * sqoop parameters
- */
+import lombok.Data;
+
+@Data
public class SqoopParameters extends AbstractParameters {
/**
@@ -72,33 +72,12 @@ public class SqoopParameters extends AbstractParameters {
*/
private String jobName;
- /**
- * model type
- */
private String modelType;
- /**
- * concurrency
- */
private int concurrency;
- /**
- * split by
- */
private String splitBy;
- /**
- * source type
- */
private String sourceType;
- /**
- * target type
- */
private String targetType;
- /**
- * source params
- */
private String sourceParams;
- /**
- * target params
- */
private String targetParams;
/**
@@ -111,102 +90,6 @@ public class SqoopParameters extends AbstractParameters {
*/
private List<Property> sqoopAdvancedParams;
- public String getModelType() {
- return modelType;
- }
-
- public void setModelType(String modelType) {
- this.modelType = modelType;
- }
-
- public int getConcurrency() {
- return concurrency;
- }
-
- public void setConcurrency(int concurrency) {
- this.concurrency = concurrency;
- }
-
- public String getSplitBy() {
- return splitBy;
- }
-
- public void setSplitBy(String splitBy) {
- this.splitBy = splitBy;
- }
-
- public String getSourceType() {
- return sourceType;
- }
-
- public void setSourceType(String sourceType) {
- this.sourceType = sourceType;
- }
-
- public String getTargetType() {
- return targetType;
- }
-
- public void setTargetType(String targetType) {
- this.targetType = targetType;
- }
-
- public String getSourceParams() {
- return sourceParams;
- }
-
- public void setSourceParams(String sourceParams) {
- this.sourceParams = sourceParams;
- }
-
- public String getTargetParams() {
- return targetParams;
- }
-
- public void setTargetParams(String targetParams) {
- this.targetParams = targetParams;
- }
-
- public String getJobType() {
- return jobType;
- }
-
- public void setJobType(String jobType) {
- this.jobType = jobType;
- }
-
- public String getJobName() {
- return jobName;
- }
-
- public void setJobName(String jobName) {
- this.jobName = jobName;
- }
-
- public String getCustomShell() {
- return customShell;
- }
-
- public void setCustomShell(String customShell) {
- this.customShell = customShell;
- }
-
- public List<Property> getHadoopCustomParams() {
- return hadoopCustomParams;
- }
-
- public void setHadoopCustomParams(List<Property> hadoopCustomParams) {
- this.hadoopCustomParams = hadoopCustomParams;
- }
-
- public List<Property> getSqoopAdvancedParams() {
- return sqoopAdvancedParams;
- }
-
- public void setSqoopAdvancedParams(List<Property> sqoopAdvancedParams) {
- this.sqoopAdvancedParams = sqoopAdvancedParams;
- }
-
@Override
public boolean checkParameters() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/TargetCommonParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/TargetCommonParameter.java
index 30390626ff..389488223d 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/TargetCommonParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/TargetCommonParameter.java
@@ -17,22 +17,11 @@
package org.apache.dolphinscheduler.plugin.task.sqoop.parameter;
-/**
- * target common parameter
- */
+import lombok.Data;
+
+@Data
public class TargetCommonParameter {
- /**
- * target datasource
- */
protected int targetDatasource;
- public int getTargetDatasource() {
- return targetDatasource;
- }
-
- public void setTargetDatasource(int targetDatasource) {
- this.targetDatasource = targetDatasource;
- }
-
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHanaParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHanaParameter.java
index 50a5da51df..a2fc23f2a4 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHanaParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHanaParameter.java
@@ -22,105 +22,20 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParam
import java.util.List;
-/**
- * source hana parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceHanaParameter extends SourceCommonParameter {
- /**
- * src table
- */
private String srcTable;
- /**
- * src query type
- */
private int srcQueryType;
- /**
- * src query sql
- */
private String srcQuerySql;
- /**
- * src column type
- */
private int srcColumnType;
- /**
- * src columns
- */
private String srcColumns;
- /**
- * src condition list
- */
private List<Property> srcConditionList;
- /**
- * map column hive
- */
private List<Property> mapColumnHive;
- /**
- * map column java
- */
private List<Property> mapColumnJava;
- public String getSrcTable() {
- return srcTable;
- }
-
- public void setSrcTable(String srcTable) {
- this.srcTable = srcTable;
- }
-
- public int getSrcQueryType() {
- return srcQueryType;
- }
-
- public void setSrcQueryType(int srcQueryType) {
- this.srcQueryType = srcQueryType;
- }
-
- public String getSrcQuerySql() {
- return srcQuerySql;
- }
-
- public void setSrcQuerySql(String srcQuerySql) {
- this.srcQuerySql = srcQuerySql;
- }
-
- public int getSrcColumnType() {
- return srcColumnType;
- }
-
- public void setSrcColumnType(int srcColumnType) {
- this.srcColumnType = srcColumnType;
- }
-
- public String getSrcColumns() {
- return srcColumns;
- }
-
- public void setSrcColumns(String srcColumns) {
- this.srcColumns = srcColumns;
- }
-
- public List<Property> getSrcConditionList() {
- return srcConditionList;
- }
-
- public void setSrcConditionList(List<Property> srcConditionList) {
- this.srcConditionList = srcConditionList;
- }
-
- public List<Property> getMapColumnHive() {
- return mapColumnHive;
- }
-
- public void setMapColumnHive(List<Property> mapColumnHive) {
- this.mapColumnHive = mapColumnHive;
- }
-
- public List<Property> getMapColumnJava() {
- return mapColumnJava;
- }
-
- public void setMapColumnJava(List<Property> mapColumnJava) {
- this.mapColumnJava = mapColumnJava;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHdfsParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHdfsParameter.java
index 056bac3c32..df087a10ab 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHdfsParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHdfsParameter.java
@@ -19,21 +19,13 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.sources;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParameter;
-/**
- * source hdfs parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceHdfsParameter extends SourceCommonParameter {
- /**
- * export dir
- */
private String exportDir;
- public String getExportDir() {
- return exportDir;
- }
-
- public void setExportDir(String exportDir) {
- this.exportDir = exportDir;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHiveParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHiveParameter.java
index 693a2964de..2c2a6b4833 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHiveParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceHiveParameter.java
@@ -19,57 +19,16 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.sources;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParameter;
-/**
- * source hive parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceHiveParameter extends SourceCommonParameter {
- /**
- * hive database
- */
private String hiveDatabase;
- /**
- * hive table
- */
private String hiveTable;
- /**
- * hive partition key
- */
private String hivePartitionKey;
- /**
- * hive partition value
- */
private String hivePartitionValue;
- public String getHiveDatabase() {
- return hiveDatabase;
- }
-
- public void setHiveDatabase(String hiveDatabase) {
- this.hiveDatabase = hiveDatabase;
- }
-
- public String getHiveTable() {
- return hiveTable;
- }
-
- public void setHiveTable(String hiveTable) {
- this.hiveTable = hiveTable;
- }
-
- public String getHivePartitionKey() {
- return hivePartitionKey;
- }
-
- public void setHivePartitionKey(String hivePartitionKey) {
- this.hivePartitionKey = hivePartitionKey;
- }
-
- public String getHivePartitionValue() {
- return hivePartitionValue;
- }
-
- public void setHivePartitionValue(String hivePartitionValue) {
- this.hivePartitionValue = hivePartitionValue;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceMysqlParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceMysqlParameter.java
index 72618c38a7..ab23898968 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceMysqlParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceMysqlParameter.java
@@ -22,105 +22,20 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParam
import java.util.List;
-/**
- * source mysql parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceMysqlParameter extends SourceCommonParameter {
- /**
- * src table
- */
private String srcTable;
- /**
- * src query type
- */
private int srcQueryType;
- /**
- * src query sql
- */
private String srcQuerySql;
- /**
- * src column type
- */
private int srcColumnType;
- /**
- * src columns
- */
private String srcColumns;
- /**
- * src condition list
- */
private List<Property> srcConditionList;
- /**
- * map column hive
- */
private List<Property> mapColumnHive;
- /**
- * map column java
- */
private List<Property> mapColumnJava;
- public String getSrcTable() {
- return srcTable;
- }
-
- public void setSrcTable(String srcTable) {
- this.srcTable = srcTable;
- }
-
- public int getSrcQueryType() {
- return srcQueryType;
- }
-
- public void setSrcQueryType(int srcQueryType) {
- this.srcQueryType = srcQueryType;
- }
-
- public String getSrcQuerySql() {
- return srcQuerySql;
- }
-
- public void setSrcQuerySql(String srcQuerySql) {
- this.srcQuerySql = srcQuerySql;
- }
-
- public int getSrcColumnType() {
- return srcColumnType;
- }
-
- public void setSrcColumnType(int srcColumnType) {
- this.srcColumnType = srcColumnType;
- }
-
- public String getSrcColumns() {
- return srcColumns;
- }
-
- public void setSrcColumns(String srcColumns) {
- this.srcColumns = srcColumns;
- }
-
- public List<Property> getSrcConditionList() {
- return srcConditionList;
- }
-
- public void setSrcConditionList(List<Property> srcConditionList) {
- this.srcConditionList = srcConditionList;
- }
-
- public List<Property> getMapColumnHive() {
- return mapColumnHive;
- }
-
- public void setMapColumnHive(List<Property> mapColumnHive) {
- this.mapColumnHive = mapColumnHive;
- }
-
- public List<Property> getMapColumnJava() {
- return mapColumnJava;
- }
-
- public void setMapColumnJava(List<Property> mapColumnJava) {
- this.mapColumnJava = mapColumnJava;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceOracleParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceOracleParameter.java
index 2ee087591d..967f3a2532 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceOracleParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceOracleParameter.java
@@ -22,105 +22,20 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParam
import java.util.List;
-/**
- * source oracle parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceOracleParameter extends SourceCommonParameter {
- /**
- * src table
- */
private String srcTable;
- /**
- * src query type
- */
private int srcQueryType;
- /**
- * src query sql
- */
private String srcQuerySql;
- /**
- * src column type
- */
private int srcColumnType;
- /**
- * src columns
- */
private String srcColumns;
- /**
- * src condition list
- */
private List<Property> srcConditionList;
- /**
- * map column hive
- */
private List<Property> mapColumnHive;
- /**
- * map column java
- */
private List<Property> mapColumnJava;
- public String getSrcTable() {
- return srcTable;
- }
-
- public void setSrcTable(String srcTable) {
- this.srcTable = srcTable;
- }
-
- public int getSrcQueryType() {
- return srcQueryType;
- }
-
- public void setSrcQueryType(int srcQueryType) {
- this.srcQueryType = srcQueryType;
- }
-
- public String getSrcQuerySql() {
- return srcQuerySql;
- }
-
- public void setSrcQuerySql(String srcQuerySql) {
- this.srcQuerySql = srcQuerySql;
- }
-
- public int getSrcColumnType() {
- return srcColumnType;
- }
-
- public void setSrcColumnType(int srcColumnType) {
- this.srcColumnType = srcColumnType;
- }
-
- public String getSrcColumns() {
- return srcColumns;
- }
-
- public void setSrcColumns(String srcColumns) {
- this.srcColumns = srcColumns;
- }
-
- public List<Property> getSrcConditionList() {
- return srcConditionList;
- }
-
- public void setSrcConditionList(List<Property> srcConditionList) {
- this.srcConditionList = srcConditionList;
- }
-
- public List<Property> getMapColumnHive() {
- return mapColumnHive;
- }
-
- public void setMapColumnHive(List<Property> mapColumnHive) {
- this.mapColumnHive = mapColumnHive;
- }
-
- public List<Property> getMapColumnJava() {
- return mapColumnJava;
- }
-
- public void setMapColumnJava(List<Property> mapColumnJava) {
- this.mapColumnJava = mapColumnJava;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceSqlServerParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceSqlServerParameter.java
index 7e94086d2b..5926d9c2a1 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceSqlServerParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/sources/SourceSqlServerParameter.java
@@ -22,105 +22,20 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.SourceCommonParam
import java.util.List;
-/**
- * source sqlServer parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class SourceSqlServerParameter extends SourceCommonParameter {
- /**
- * src table
- */
private String srcTable;
- /**
- * src query type
- */
private int srcQueryType;
- /**
- * src query sql
- */
private String srcQuerySql;
- /**
- * src column type
- */
private int srcColumnType;
- /**
- * src columns
- */
private String srcColumns;
- /**
- * src condition list
- */
private List<Property> srcConditionList;
- /**
- * map column hive
- */
private List<Property> mapColumnHive;
- /**
- * map column java
- */
private List<Property> mapColumnJava;
- public String getSrcTable() {
- return srcTable;
- }
-
- public void setSrcTable(String srcTable) {
- this.srcTable = srcTable;
- }
-
- public int getSrcQueryType() {
- return srcQueryType;
- }
-
- public void setSrcQueryType(int srcQueryType) {
- this.srcQueryType = srcQueryType;
- }
-
- public String getSrcQuerySql() {
- return srcQuerySql;
- }
-
- public void setSrcQuerySql(String srcQuerySql) {
- this.srcQuerySql = srcQuerySql;
- }
-
- public int getSrcColumnType() {
- return srcColumnType;
- }
-
- public void setSrcColumnType(int srcColumnType) {
- this.srcColumnType = srcColumnType;
- }
-
- public String getSrcColumns() {
- return srcColumns;
- }
-
- public void setSrcColumns(String srcColumns) {
- this.srcColumns = srcColumns;
- }
-
- public List<Property> getSrcConditionList() {
- return srcConditionList;
- }
-
- public void setSrcConditionList(List<Property> srcConditionList) {
- this.srcConditionList = srcConditionList;
- }
-
- public List<Property> getMapColumnHive() {
- return mapColumnHive;
- }
-
- public void setMapColumnHive(List<Property> mapColumnHive) {
- this.mapColumnHive = mapColumnHive;
- }
-
- public List<Property> getMapColumnJava() {
- return mapColumnJava;
- }
-
- public void setMapColumnJava(List<Property> mapColumnJava) {
- this.mapColumnJava = mapColumnJava;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHanaParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHanaParameter.java
index 2ba6c97275..58131b1d6d 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHanaParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHanaParameter.java
@@ -19,42 +19,15 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target hana parameter
- */
public class TargetHanaParameter extends TargetCommonParameter {
- /**
- * target table
- */
private String targetTable;
- /**
- * target columns
- */
private String targetColumns;
- /**
- * fields terminated
- */
private String fieldsTerminated;
- /**
- * lines terminated
- */
private String linesTerminated;
- /**
- * pre query
- */
private String preQuery;
- /**
- * is update
- */
private boolean isUpdate;
- /**
- * target update key
- */
private String targetUpdateKey;
- /**
- * target update mode
- */
private String targetUpdateMode;
public String getTargetTable() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHdfsParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHdfsParameter.java
index 11edd24ea0..06d5ec21de 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHdfsParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHdfsParameter.java
@@ -19,82 +19,21 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target hdfs parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class TargetHdfsParameter extends TargetCommonParameter {
/**
* target dir
*/
private String targetPath;
- /**
- * delete target dir
- */
private boolean deleteTargetDir;
- /**
- * file type
- */
private String fileType;
- /**
- * compression codec
- */
private String compressionCodec;
- /**
- * fields terminated
- */
private String fieldsTerminated;
- /**
- * lines terminated
- */
private String linesTerminated;
- public String getTargetPath() {
- return targetPath;
- }
-
- public void setTargetPath(String targetPath) {
- this.targetPath = targetPath;
- }
-
- public boolean isDeleteTargetDir() {
- return deleteTargetDir;
- }
-
- public void setDeleteTargetDir(boolean deleteTargetDir) {
- this.deleteTargetDir = deleteTargetDir;
- }
-
- public String getFileType() {
- return fileType;
- }
-
- public void setFileType(String fileType) {
- this.fileType = fileType;
- }
-
- public String getCompressionCodec() {
- return compressionCodec;
- }
-
- public void setCompressionCodec(String compressionCodec) {
- this.compressionCodec = compressionCodec;
- }
-
- public String getFieldsTerminated() {
- return fieldsTerminated;
- }
-
- public void setFieldsTerminated(String fieldsTerminated) {
- this.fieldsTerminated = fieldsTerminated;
- }
-
- public String getLinesTerminated() {
- return linesTerminated;
- }
-
- public void setLinesTerminated(String linesTerminated) {
- this.linesTerminated = linesTerminated;
- }
-
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHiveParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHiveParameter.java
index 6be49dab95..d7582bdb05 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHiveParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHiveParameter.java
@@ -19,117 +19,21 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target hive parameter
- */
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+
+@EqualsAndHashCode(callSuper = true)
+@Data
public class TargetHiveParameter extends TargetCommonParameter {
- /**
- * hive database
- */
private String hiveDatabase;
- /**
- * hive table
- */
private String hiveTable;
- /**
- * create hive table
- */
private boolean createHiveTable;
- /**
- * drop delimiter
- */
private boolean dropDelimiter;
- /**
- * hive overwrite
- */
private boolean hiveOverWrite;
- /**
- * replace delimiter
- */
private String replaceDelimiter;
- /**
- * hive partition key
- */
private String hivePartitionKey;
- /**
- * hive partition value
- */
private String hivePartitionValue;
- /**
- * hive target dir
- */
private String hiveTargetDir;
- public String getHiveDatabase() {
- return hiveDatabase;
- }
-
- public void setHiveDatabase(String hiveDatabase) {
- this.hiveDatabase = hiveDatabase;
- }
-
- public String getHiveTable() {
- return hiveTable;
- }
-
- public void setHiveTable(String hiveTable) {
- this.hiveTable = hiveTable;
- }
-
- public boolean isCreateHiveTable() {
- return createHiveTable;
- }
-
- public void setCreateHiveTable(boolean createHiveTable) {
- this.createHiveTable = createHiveTable;
- }
-
- public boolean isDropDelimiter() {
- return dropDelimiter;
- }
-
- public void setDropDelimiter(boolean dropDelimiter) {
- this.dropDelimiter = dropDelimiter;
- }
-
- public boolean isHiveOverWrite() {
- return hiveOverWrite;
- }
-
- public void setHiveOverWrite(boolean hiveOverWrite) {
- this.hiveOverWrite = hiveOverWrite;
- }
-
- public String getReplaceDelimiter() {
- return replaceDelimiter;
- }
-
- public void setReplaceDelimiter(String replaceDelimiter) {
- this.replaceDelimiter = replaceDelimiter;
- }
-
- public String getHivePartitionKey() {
- return hivePartitionKey;
- }
-
- public void setHivePartitionKey(String hivePartitionKey) {
- this.hivePartitionKey = hivePartitionKey;
- }
-
- public String getHivePartitionValue() {
- return hivePartitionValue;
- }
-
- public void setHivePartitionValue(String hivePartitionValue) {
- this.hivePartitionValue = hivePartitionValue;
- }
-
- public String getHiveTargetDir() {
- return hiveTargetDir;
- }
-
- public void setHiveTargetDir(String hiveTargetDir) {
- this.hiveTargetDir = hiveTargetDir;
- }
}
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetMysqlParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetMysqlParameter.java
index 8f7c611545..59a5cb1526 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetMysqlParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetMysqlParameter.java
@@ -19,42 +19,15 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target mysql parameter
- */
public class TargetMysqlParameter extends TargetCommonParameter {
- /**
- * target table
- */
private String targetTable;
- /**
- * target columns
- */
private String targetColumns;
- /**
- * fields terminated
- */
private String fieldsTerminated;
- /**
- * lines terminated
- */
private String linesTerminated;
- /**
- * pre query
- */
private String preQuery;
- /**
- * is update
- */
private boolean isUpdate;
- /**
- * target update key
- */
private String targetUpdateKey;
- /**
- * target update mode
- */
private String targetUpdateMode;
public String getTargetTable() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetOracleParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetOracleParameter.java
index 2c70594428..9155e69490 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetOracleParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetOracleParameter.java
@@ -19,42 +19,15 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target oracle parameter
- */
public class TargetOracleParameter extends TargetCommonParameter {
- /**
- * target table
- */
private String targetTable;
- /**
- * target columns
- */
private String targetColumns;
- /**
- * fields terminated
- */
private String fieldsTerminated;
- /**
- * lines terminated
- */
private String linesTerminated;
- /**
- * pre query
- */
private String preQuery;
- /**
- * is update
- */
private boolean isUpdate;
- /**
- * target update key
- */
private String targetUpdateKey;
- /**
- * target update mode
- */
private String targetUpdateMode;
public String getTargetTable() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetSqlServerParameter.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetSqlServerParameter.java
index 6cefda4827..c789789ded 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetSqlServerParameter.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetSqlServerParameter.java
@@ -19,42 +19,15 @@ package org.apache.dolphinscheduler.plugin.task.sqoop.parameter.targets;
import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter;
-/**
- * target sqlServer parameter
- */
public class TargetSqlServerParameter extends TargetCommonParameter {
- /**
- * target table
- */
private String targetTable;
- /**
- * target columns
- */
private String targetColumns;
- /**
- * fields terminated
- */
private String fieldsTerminated;
- /**
- * lines terminated
- */
private String linesTerminated;
- /**
- * pre query
- */
private String preQuery;
- /**
- * is update
- */
private boolean isUpdate;
- /**
- * target update key
- */
private String targetUpdateKey;
- /**
- * target update mode
- */
private String targetUpdateMode;
public String getTargetTable() {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/EntityTestUtils.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/EntityTestUtils.java
index ff8c73062f..470d8293c2 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/EntityTestUtils.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/EntityTestUtils.java
@@ -27,9 +27,6 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
-/**
- * entity test utils
- */
public class EntityTestUtils {
private static final Map<String, Object> OBJECT_MAP = new HashMap<>();
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopParameterEntityTest.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopParameterEntityTest.java
index 1695edaada..06e2b3362c 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopParameterEntityTest.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/test/java/org/apache/dolphinscheduler/plugin/task/sqoop/SqoopParameterEntityTest.java
@@ -31,9 +31,6 @@ import java.util.List;
import org.junit.jupiter.api.Test;
-/**
- * sqoop parameter entity test
- */
public class SqoopParameterEntityTest {
@Test
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java
index c073627c91..6e509806fb 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinParameters.java
@@ -29,13 +29,11 @@ import java.util.Collections;
import java.util.List;
import java.util.Objects;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
-@Getter
-@Setter
+@Data
@ToString
@Slf4j
public class ZeppelinParameters extends AbstractParameters {
diff --git a/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTaskExecutionContext.java b/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTaskExecutionContext.java
index 4cc09e5f4f..7c29fb502e 100644
--- a/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTaskExecutionContext.java
+++ b/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTaskExecutionContext.java
@@ -19,24 +19,16 @@ package org.apache.dolphinscheduler.plugin.task.zeppelin;
import java.io.Serializable;
+import lombok.Data;
+
/**
* master/worker task transport
*/
+@Data
public class ZeppelinTaskExecutionContext implements Serializable {
- /**
- * connectionParams
- */
private String connectionParams;
- public String getConnectionParams() {
- return connectionParams;
- }
-
- public void setConnectionParams(String connectionParams) {
- this.connectionParams = connectionParams;
- }
-
@Override
public String toString() {
return "ZeppelinTaskExecutionContext{"