You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/06/18 22:01:33 UTC
Review Request 35617: Provide meaningful error message for
URLStreamProvider
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35617/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-12006
https://issues.apache.org/jira/browse/AMBARI-12006
Repository: ambari
Description
-------
Seeing this exception ...
Caused by: java.lang.NullPointerException
at java.io.File.<init>(File.java:277)
at org.apache.ambari.server.controller.internal.URLStreamProvider.getSSLConnection(URLStreamProvider.java:280)
The NPE is due to the fact that ssl.trustStore.path is not set in ambari.properites. It is expected that the ssl.truststore configuration properties be set for https requests through the URLStreamProvider.
The Ambari code should be cleaned up to verify not null and log a meaningful error (instead of NPE).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 1a8b085
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 4e18c7f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/URLStreamProviderTest.java 7268ff2
Diff: https://reviews.apache.org/r/35617/diff/
Testing
-------
new unit test added
mvn clean test
all pass
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46:04 min
[INFO] Finished at: 2015-06-18T15:07:52-04:00
[INFO] Final Memory: 54M/1297M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 35617: Provide meaningful error message for
URLStreamProvider
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35617/#review88467
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 18, 2015, 4:01 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35617/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 4:01 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-12006
> https://issues.apache.org/jira/browse/AMBARI-12006
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Seeing this exception ...
>
> Caused by: java.lang.NullPointerException
> at java.io.File.<init>(File.java:277)
> at org.apache.ambari.server.controller.internal.URLStreamProvider.getSSLConnection(URLStreamProvider.java:280)
>
> The NPE is due to the fact that ssl.trustStore.path is not set in ambari.properites. It is expected that the ssl.truststore configuration properties be set for https requests through the URLStreamProvider.
>
>
> The Ambari code should be cleaned up to verify not null and log a meaningful error (instead of NPE).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 1a8b085
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 4e18c7f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/URLStreamProviderTest.java 7268ff2
>
> Diff: https://reviews.apache.org/r/35617/diff/
>
>
> Testing
> -------
>
> new unit test added
>
> mvn clean test
>
> all pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:04 min
> [INFO] Finished at: 2015-06-18T15:07:52-04:00
> [INFO] Final Memory: 54M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 35617: Provide meaningful error message for
URLStreamProvider
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35617/#review88430
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On June 18, 2015, 4:01 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35617/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 4:01 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-12006
> https://issues.apache.org/jira/browse/AMBARI-12006
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Seeing this exception ...
>
> Caused by: java.lang.NullPointerException
> at java.io.File.<init>(File.java:277)
> at org.apache.ambari.server.controller.internal.URLStreamProvider.getSSLConnection(URLStreamProvider.java:280)
>
> The NPE is due to the fact that ssl.trustStore.path is not set in ambari.properites. It is expected that the ssl.truststore configuration properties be set for https requests through the URLStreamProvider.
>
>
> The Ambari code should be cleaned up to verify not null and log a meaningful error (instead of NPE).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java 1a8b085
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 4e18c7f
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/URLStreamProviderTest.java 7268ff2
>
> Diff: https://reviews.apache.org/r/35617/diff/
>
>
> Testing
> -------
>
> new unit test added
>
> mvn clean test
>
> all pass
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46:04 min
> [INFO] Finished at: 2015-06-18T15:07:52-04:00
> [INFO] Final Memory: 54M/1297M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>