You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrey Trubitsyn <no...@github.com> on 2013/07/09 11:55:36 UTC

[jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

1. Quantum v1.0 was removed beacause it can not be used in Folsom, Grizzly, ...
   OpenStack releases.
2. Entity schema was changed. We have Network, Subnet, Port entities now.
3. *Api classes were updated to v2.0 as well

JIRA issue link:
https://issues.apache.org/jira/browse/JCLOUDS-176
You can merge this Pull Request by running:

  git pull https://github.com/andtrub/jclouds-labs-openstack master

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/15

-- Commit Summary --

  * Add Neutron v2.0 client implementation

-- File Changes --

    M openstack-quantum/pom.xml (2)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/QuantumApi.java (72)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/QuantumApiMetadata.java (91)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/config/QuantumHttpApiModule.java (85)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/config/QuantumProperties.java (26)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/Attachment.java (63)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/Network.java (102)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/NetworkDetails.java (108)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/Port.java (108)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/PortDetails.java (103)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/domain/Reference.java (108)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/features/NetworkApi.java (122)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/features/PortApi.java (147)
    D openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v1_0/handlers/QuantumErrorHandler.java (63)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/QuantumApi.java (74)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/QuantumApiMetadata.java (92)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/config/QuantumHttpApiModule.java (85)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/config/QuantumProperties.java (26)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/FixedIP.java (100)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/IPRange.java (101)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/Network.java (180)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/Port.java (271)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/Reference.java (109)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/domain/Subnet.java (226)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/features/NetworkApi.java (68)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/features/PortApi.java (66)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/features/SubnetApi.java (59)
    A openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/handlers/QuantumErrorHandler.java (61)
    M openstack-quantum/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata (2)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/QuantumApiMetadataTest.java (35)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/features/NetworkApiExpectTest.java (235)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/features/NetworkApiLiveTest.java (91)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/features/PortApiExpectTest.java (245)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/features/PortApiLiveTest.java (137)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/internal/BaseQuantumApiLiveTest.java (44)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/internal/BaseQuantumExpectTest.java (57)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/parse/ParseAttachmentTest.java (45)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/parse/ParseNetworkDetailsTest.java (49)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/parse/ParsePortDetailsTest.java (47)
    D openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v1_0/parse/ParsePortTest.java (45)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/QuantumApiMetadataTest.java (34)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/NetworkApiExpectTest.java (113)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/NetworkApiLiveTest.java (47)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/PortApiExpectTest.java (92)
    R openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/PortApiLiveTest.java (42)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/SubnetApiExpectTest.java (95)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/features/SubnetApiLiveTest.java (44)
    R openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/internal/BaseQuantumApiExpectTest.java (6)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/internal/BaseQuantumApiLiveTest.java (44)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/internal/BaseQuantumExpectTest.java (55)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/parse/ParseNetworkTest.java (48)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/parse/ParsePortTest.java (59)
    A openstack-quantum/src/test/java/org/jclouds/openstack/quantum/v2_0/parse/ParseSubnetTest.java (55)
    D openstack-quantum/src/test/resources/attachment.json (1)
    D openstack-quantum/src/test/resources/list_network_refs.json (14)
    M openstack-quantum/src/test/resources/list_networks.json (110)
    A openstack-quantum/src/test/resources/list_ports.json (21)
    A openstack-quantum/src/test/resources/list_subnets.json (17)
    M openstack-quantum/src/test/resources/network.json (9)
    D openstack-quantum/src/test/resources/network_details.json (1)
    M openstack-quantum/src/test/resources/port.json (23)
    D openstack-quantum/src/test/resources/port_details.json (1)
    A openstack-quantum/src/test/resources/subnet.json (18)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/15.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/15.diff


Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
Reopened #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #25](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/25/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-22000302

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrey Trubitsyn <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
Cf. https://github.com/jclouds/jclouds/pull/118, which was submitted later.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-23131085

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
> Test should pass successfully the next time

Looks like you right on that one ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21672109

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #264](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/264/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-22000059

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #177](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/177/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-20664203

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Zack Shoylev <no...@github.com>.
Perhaps a good idea to rename everything to neutron?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21642467

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrey Trubitsyn <no...@github.com>.
I think the patch for Neutron v2.0 is ready, please, review it

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-22000221

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
Closed #15.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #24](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/24/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-22000120

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
> Please, tell me, how can I start tests one more time?

The pull request builder should trigger automatically if you change the contents by pushing anything to your branch. Otherwise, you can "trick" it by closing and re-opening the request. Let me do that now...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21670812

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrew Phillips <no...@github.com>.
> but the package says "quantum" - which I thought was removed?

Still some [org.jclouds.openstack.quantum](https://github.com/andtrub/jclouds-labs-openstack/blob/master/openstack-quantum/src/main/java/org/jclouds/openstack/quantum/v2_0/QuantumApi.java) there, it seems..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21642095

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrey Trubitsyn <no...@github.com>.
I am working on sending ICLA right now, please, make remarks about my commit

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-20664058

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #234](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/234/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21670911

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrey Trubitsyn <no...@github.com>.
Please, tell me, how can I start tests one more time? Test should pass successfully the next time because according changes were made in  https://issues.apache.org/jira/browse/JCLOUDS-175.

Also I will rename quantum into neutron soon. Now I am working on ICLA for Sentilla Inc. As soon as it is ready I will commit renamed version.

Thanks

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21670373

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #10](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/10/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-20664258

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Andrey Trubitsyn <no...@github.com>.
Sure, I am reviewing it

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-23397644

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Everett Toews <no...@github.com>.
@andtrub Clearly you're very familiar with Neutron. Would you be willing to help review https://github.com/jclouds/jclouds-labs-openstack/pull/23 and we can all get behind one implementation?



---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-23333684

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #265](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/265/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-22000301

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by Zack Shoylev <no...@github.com>.
There seem to be failing tests https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/177/console but the package says "quantum" - which I thought was removed?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21640762

Re: [jclouds-labs-openstack] Add Neutron v2.0 client implementation (#15)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #23](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/23/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/15#issuecomment-21670944