You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Megha Sharma <ms...@apple.com> on 2017/06/14 23:28:45 UTC
Review Request 60103: Changed variable name _ack to statusUpdateAck.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/
-----------------------------------------------------------
Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
Changed variable name _ack to statusUpdateAck which
correctly identifies with the purpose of this variable.
Diffs
-----
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
Diff: https://reviews.apache.org/r/60103/diff/1/
Testing
-------
Thanks,
Megha Sharma
Re: Review Request 60103: Changed variable name _ack to
statusUpdateAck.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/#review178509
-----------------------------------------------------------
Ship it!
In the future please always keep the review title up to date and fill out the testing done section, even if it's (e.g.,) "make check together with /r/56895/".
- Jiang Yan Xu
On June 20, 2017, 8:41 a.m., Megha Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60103/
> -----------------------------------------------------------
>
> (Updated June 20, 2017, 8:41 a.m.)
>
>
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6223
> https://issues.apache.org/jira/browse/MESOS-6223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed variable name _ack to statusUpdateAck which
> correctly identifies with the purpose of this variable.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
>
>
> Diff: https://reviews.apache.org/r/60103/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Megha Sharma
>
>
Re: Review Request 60103: Changed variable name _ack to
statusUpdateAck.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/
-----------------------------------------------------------
(Updated June 20, 2017, 3:41 p.m.)
Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
Changed variable name _ack to statusUpdateAck which
correctly identifies with the purpose of this variable.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
Diff: https://reviews.apache.org/r/60103/diff/4/
Changes: https://reviews.apache.org/r/60103/diff/3-4/
Testing
-------
Thanks,
Megha Sharma
Re: Review Request 60103: Changed variable name _ack to
statusUpdateAck.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/#review178319
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/slave_recovery_tests.cpp
Line 237 (original), 237 (patched)
<https://reviews.apache.org/r/60103/#comment252203>
`s/statusUpdateAck/_statusUpdateAcknowledgement/`
Generally for this sitautions ("a future capturing the dispatch of a method") we just simply copy the name of the method as a the name of the variable.
If you search `Future<Nothing> _statusUpdateAcknowledgement =` in the same file you can actually see plenty of examples. :)
- Jiang Yan Xu
On June 15, 2017, 12:30 p.m., Megha Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60103/
> -----------------------------------------------------------
>
> (Updated June 15, 2017, 12:30 p.m.)
>
>
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-6223
> https://issues.apache.org/jira/browse/MESOS-6223
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed variable name _ack to statusUpdateAck which
> correctly identifies with the purpose of this variable.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
>
>
> Diff: https://reviews.apache.org/r/60103/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Megha Sharma
>
>
Re: Review Request 60103: Changed variable name _ack to
statusUpdateAck.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/
-----------------------------------------------------------
(Updated June 15, 2017, 7:30 p.m.)
Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
Changed variable name _ack to statusUpdateAck which
correctly identifies with the purpose of this variable.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
Diff: https://reviews.apache.org/r/60103/diff/3/
Changes: https://reviews.apache.org/r/60103/diff/2-3/
Testing
-------
Thanks,
Megha Sharma
Re: Review Request 60103: Changed variable name _ack to
statusUpdateAck.
Posted by Megha Sharma <ms...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60103/
-----------------------------------------------------------
(Updated June 15, 2017, 5:54 p.m.)
Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-6223
https://issues.apache.org/jira/browse/MESOS-6223
Repository: mesos
Description
-------
Changed variable name _ack to statusUpdateAck which
correctly identifies with the purpose of this variable.
Diffs (updated)
-----
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
Diff: https://reviews.apache.org/r/60103/diff/2/
Changes: https://reviews.apache.org/r/60103/diff/1-2/
Testing
-------
Thanks,
Megha Sharma