You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/16 01:56:58 UTC
[GitHub] [incubator-hudi] bvaradar opened a new pull request #1634: [WIP] [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
bvaradar opened a new pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634
This is to enable timeline-server and incremental cleaning by default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1634: [WIP] [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634#discussion_r426503762
##########
File path: hudi-utilities/pom.xml
##########
@@ -82,6 +82,8 @@
<!-- Needs to be at the top to ensure we get the correct dependency versions for jetty-server -->
<groupId>org.eclipse.jetty.aggregate</groupId>
<artifactId>jetty-all</artifactId>
+ <version>9.4.15.v20190215</version>
Review comment:
pull the version to a property?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] vinothchandar merged pull request #1634: [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1634: [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634#issuecomment-630393889
@vinothchandar : Addressed review comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bhasudha commented on pull request #1634: [WIP] [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
Posted by GitBox <gi...@apache.org>.
bhasudha commented on pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634#issuecomment-629611515
> @bhasudha : This is another important config change for 0.5.3. I am marking the PR as WIP till I get the tests to succeed. After that, I will make the PR active.
ack. Thanks @bvaradar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hudi] bvaradar commented on pull request #1634: [WIP] [HUDI-846][HUDI-848] Enable Incremental cleaning and embedded timeline-server by default
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1634:
URL: https://github.com/apache/incubator-hudi/pull/1634#issuecomment-629572248
@bhasudha : This is another important config change for 0.5.3. I am marking the PR as WIP till I get the tests to succeed. After that, I will make the PR active.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org