You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ashr123 (via GitHub)" <gi...@apache.org> on 2025/10/10 18:05:30 UTC
[PR] Adding initial support [logging-log4j2]
ashr123 opened a new pull request, #3952:
URL: https://github.com/apache/logging-log4j2/pull/3952
About 1 week ago, FasterXML released Jackson 3.0, so I want to add support for it (i.e. being able to read `log4j2.json` ext. files.
See https://github.com/FasterXML/jackson/wiki/Jackson-Release-3.0
Closes #3950
> [!IMPORTANT]
> Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise.
## Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
### ✅ Required checks
- [x] **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0).
- [x] **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)).
- [ ] **Code formatting**: The code is formatted according to the project’s style guide.
Need some help with `log4j-core/pom.xml`
<details>
<summary>How to check and fix formatting</summary>
- To **check** formatting: `./mvnw spotless:check`
- To **fix** formatting: `./mvnw spotless:apply`
See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
</details>
- [ ] **Build & Test**: I verified that the project builds and all unit tests pass.
Need some help with `log4j-core/pom.xml`
<details>
<summary>How to build the project</summary>
Run: `./mvnw verify`
See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details.
</details>
### 🧪 Tests (select one)
- [ ] I have added or updated tests to cover my changes.
- [ ] No additional tests are needed for this change.
### 📝 Changelog (select one)
- [x] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)).
- [ ] This is a trivial change and does not require a changelog entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding initial support [logging-log4j2]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #3952:
URL: https://github.com/apache/logging-log4j2/pull/3952#issuecomment-3393011955
Hi @ashr123, thanks a lot for the PR!
We can’t merge this into the `2.x` branch because `2.x` targets Java 8, while Jackson 3 requires Java 17. That version mismatch would break our compatibility guarantees for the 2.x line.
As for the `main` branch (with a Java 17 baseline) we migrated to Jackson 3 on shortly after the 3.0.0 release (see #3701) and we’re actively working toward our own `3.0.0` release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding initial support [logging-log4j2]
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz closed pull request #3952: Adding initial support
URL: https://github.com/apache/logging-log4j2/pull/3952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org