You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/06 15:52:49 UTC

[GitHub] [incubator-seatunnel] Sachin-2206 opened a new pull request, #3888: Changed seatunnel-engine to seatunnel-zeta

Sachin-2206 opened a new pull request, #3888:
URL: https://github.com/apache/incubator-seatunnel/pull/3888

   @hailin0 
   Good evening sir,
   
   ## Contribution In #3857
   I fix issue https://github.com/apache/incubator-seatunnel/issues/3857
   
   ## Purpose of this pull request
   
   I rename the seatunnel-engine to seatunnel-zeta as per your request and issue.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3888:
URL: https://github.com/apache/incubator-seatunnel/pull/3888#issuecomment-1374368329

   waiting #3798 merged cc @hailin0 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Sachin-2206 commented on pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
Sachin-2206 commented on PR #3888:
URL: https://github.com/apache/incubator-seatunnel/pull/3888#issuecomment-1374450071

   @TyrantLucifer I think sir whn I changed package name seatunnel-engine to seatunnel-zeta . The java will unable to get old name as its package name same till now . If we change its package name , it will be alright


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Sachin-2206 commented on pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
Sachin-2206 commented on PR #3888:
URL: https://github.com/apache/incubator-seatunnel/pull/3888#issuecomment-1374450657

   @TyrantLucifer Sir I will again try but now I will not change the import classes name, may be after that it will not return any issue. Give me some more time , I will done it by Monday. Thank you.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Sachin-2206 closed pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
Sachin-2206 closed pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta
URL: https://github.com/apache/incubator-seatunnel/pull/3888


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] Sachin-2206 closed pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
Sachin-2206 closed pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta
URL: https://github.com/apache/incubator-seatunnel/pull/3888


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3888: [Rename]Changed seatunnel-engine to seatunnel-zeta

Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #3888:
URL: https://github.com/apache/incubator-seatunnel/pull/3888#issuecomment-1374405910

   > Please revert any changes that are not related to PR requirements
   
   +1
   
   @Sachin-2206 check files change
   https://github.com/apache/incubator-seatunnel/pull/3888/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org