You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/14 13:58:55 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7570: [AIRFLOW-6946] Switch to MySQL 5.7 in 2.0 as base

nuclearpinguin commented on a change in pull request #7570: [AIRFLOW-6946] Switch to MySQL 5.7 in 2.0 as base
URL: https://github.com/apache/airflow/pull/7570#discussion_r392590462
 
 

 ##########
 File path: airflow/models/base.py
 ##########
 @@ -38,3 +38,11 @@
 # used for typing
 class Operator:
     pass
+
+
+def get_id_collation_args():
+    collation = conf.get('core', 'sql_engine_collation_for_ids', fallback=None)
+    if collation:
+        return {'collation': collation}
+    else:
+        return {}
 
 Review comment:
   ```suggestion
      return {'collation': collation} if collation else {}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services