[jira] [Closed] (GEODE-6146) Cleanup PortfolioPdx object in benchmarks

["Owen Nichols (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols closed GEODE-6146.
-------------------------------

> Cleanup PortfolioPdx object in benchmarks
> -----------------------------------------
>
>                 Key: GEODE-6146
>                 URL: https://issues.apache.org/jira/browse/GEODE-6146
>             Project: Geode
>          Issue Type: Task
>          Components: benchmarks
>            Reporter: Dan Smith
>            Assignee: nabarun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The PortfolioPdx object has a number of issues that need cleaning up. We should aim for this to be a good example of what a domain object would look like it a real deployment. Here are some of the things that need fixing:
> * The object extends PdxSerializable and contains other objects that are DataSerializable and Serializable. We should just be using auto serialization
> * Missing generics
> * Separate out generation logic from the constructors and don't rely on a bunch of static fields. Perhaps a separate PortfolioPdx supplier class?
> * Make the object used in the benchmarks configurable. PutTask currently hardcodes Portfolio PDX. Perhaps it should take a function that returns an object, so we can create benchmarks with different data types using the same task.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)