You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2017/12/19 07:24:08 UTC
[GitHub] carbondata pull request #1676: [CARBONDATA-1906] Update registerTempTable me...
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/1676
[CARBONDATA-1906] Update registerTempTable method because it was marked deprecated
Update registerTempTable method to createOrReplaceTempView, because registerTempTable was marked deprecated
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata registerTempTable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1676.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1676
----
commit 8a903d4f724de4cd06c331e88964e60ec9698042
Author: xubo245 <60...@qq.com>
Date: 2017-12-19T07:20:51Z
[CARBONDATA-1906] Update registerTempTable method because it was marked deprecated
Update registerTempTable method to createOrReplaceTempView, because registerTempTable was marked deprecated
----
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1676
retest sdv please
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/908/
---
[GitHub] carbondata pull request #1676: [CARBONDATA-1906] Update registerTempTable me...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1676
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/904/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1676
LGTM
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1676
retest this please
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1676
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2406/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/935/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2164/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2122/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1676
@xubo245 ..actual modification of code is in 2-3 files, remaining files have been modified for import changes..kindly revert unwanted file changes
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/923/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2152/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1676
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2454/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2128/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1676
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2426/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2141/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1676
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/897/
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1676
retest this please
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1676
@manishgupta88 OK, I reset the unused import.
---
[GitHub] carbondata issue #1676: [CARBONDATA-1906] Update registerTempTable method be...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/1676
retest this please
---