[GitHub] [flink] dianfu opened a new pull request, #19386: [FLINK-27108][python] Fix the state cache clean up logic

[GitBox <gi...@apache.org>]

dianfu opened a new pull request, #19386:
URL: https://github.com/apache/flink/pull/19386

   
   ## What is the purpose of the change
   
   *This pull request fixes the the state cache clean up logic. The test case test_session_window_late_merge failed when working on PR #19333. After digging into this problem, I found that the reason should be that the logic to determine [whether a key & namespace exists in state cache is wrong](https://github.com/apache/flink/blob/master/flink-python/pyflink/fn_execution/state_impl.py#L1183). It causes the state cache isn't clean up when it becomes invalidate. *
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *test_session_window_late_merge*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #19386: [FLINK-27108][python] Fix the state cache clean up logic

[GitBox <gi...@apache.org>]

dianfu closed pull request #19386: [FLINK-27108][python] Fix the state cache clean up logic
URL: https://github.com/apache/flink/pull/19386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19386: [FLINK-27108][python] Fix the state cache clean up logic

[GitBox <gi...@apache.org>]

flinkbot commented on PR #19386:
URL: https://github.com/apache/flink/pull/19386#issuecomment-1091204176

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1e987748e0ee0ac4e14b5e1bf334b30f73b00230",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1e987748e0ee0ac4e14b5e1bf334b30f73b00230",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1e987748e0ee0ac4e14b5e1bf334b30f73b00230 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org