[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6960: GEODE-9562: add system property for redis region name

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #6960:
URL: https://github.com/apache/geode/pull/6960#discussion_r725204921



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -102,6 +105,13 @@ public NettyRedisServer(Supplier<DistributionConfig> configSupplier,
     this.member = member;
     this.securityService = securityService;
 
+    String regionName = System.getProperty(ConfigurationProperties.REDIS_REGION_NAME);

Review comment:
       NettyRedisServer should not be changed by this PR.
   Instead you should change RegionProvider. It has a static final String that is the name of the region:   public static final String REDIS_DATA_REGION = "REDIS_DATA";
   Change this line to consult the system property. If having it be a static makes testing hard then you could change REDIS_DATA_REGION to not be static. If you still want to be able to ask a GeodeRedisServer for the region name then it should ask the RegionProvider it has for the name,




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org