You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "nstefeko (via GitHub)" <gi...@apache.org> on 2023/07/25 13:14:30 UTC
[GitHub] [camel] nstefeko opened a new pull request, #10822: CAMEL-19539: Replace Thread.sleep in tests
nstefeko opened a new pull request, #10822:
URL: https://github.com/apache/camel/pull/10822
# Description
Replacing Thread.sleep in tests using Awaitility in camel-netty component. Using Threads.sleep is bug prone and can introduce flakiness when running on environments with different capacities.
# Tracking
https://issues.apache.org/jira/browse/CAMEL-19539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10822: CAMEL-19539: Replace Thread.sleep in tests
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10822:
URL: https://github.com/apache/camel/pull/10822#issuecomment-1649826035
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10822: CAMEL-19539: Replace Thread.sleep in tests
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10822:
URL: https://github.com/apache/camel/pull/10822#issuecomment-1650292209
Thanks, this pattern with awailability can be used in many other components that have hardcoded thread sleeps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10822: CAMEL-19539: Replace Thread.sleep in tests
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10822:
URL: https://github.com/apache/camel/pull/10822#issuecomment-1650164832
This is OK to merge. The build failure is unrelated (just some GH flakiness building docs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10822: CAMEL-19539: Replace Thread.sleep in tests
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10822:
URL: https://github.com/apache/camel/pull/10822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org