You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cl...@apache.org on 2016/07/28 16:32:57 UTC
[2/9] activemq-artemis git commit: Remove unnecessary casts
Remove unnecessary casts
Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/429e1e84
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/429e1e84
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/429e1e84
Branch: refs/heads/master
Commit: 429e1e84d4bde4b877246b5972f7f0a0c910e0cf
Parents: b0815c6
Author: Ville Skytt� <vi...@iki.fi>
Authored: Thu Jul 28 18:12:59 2016 +0300
Committer: Ville Skytt� <vi...@iki.fi>
Committed: Thu Jul 28 18:12:59 2016 +0300
----------------------------------------------------------------------
.../activemq/artemis/core/client/impl/ClientProducerImpl.java | 2 +-
.../artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java | 2 +-
.../org/apache/activemq/artemis/core/io/mapped/MappedFile.java | 4 ++--
.../activemq/transport/fanout/FanoutTransportBrokerTest.java | 2 +-
.../activemq/artemis/tests/extras/byteman/FailureXATest.java | 2 +-
.../tests/integration/amqp/jms/SendingAndReceivingTest.java | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
----------------------------------------------------------------------
diff --git a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
index b0998b8..9ee120f 100644
--- a/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
+++ b/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java
@@ -374,7 +374,7 @@ public class ClientProducerImpl implements ClientProducerInternal {
for (long pos = 0; pos < bodySize; ) {
final boolean lastChunk;
- final int chunkLength = (int) Math.min((bodySize - pos), (long) minLargeMessageSize);
+ final int chunkLength = (int) Math.min((bodySize - pos), minLargeMessageSize);
final ActiveMQBuffer bodyBuffer = ActiveMQBuffers.fixedBuffer(chunkLength);
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java
----------------------------------------------------------------------
diff --git a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java
index 4a2c991..0ce65db 100644
--- a/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java
+++ b/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/JDBCSequentialFileFactoryDriver.java
@@ -254,7 +254,7 @@ public class JDBCSequentialFileFactoryDriver extends AbstractJDBCDriver {
if (rs.next()) {
Blob blob = rs.getBlob(1);
readLength = (int) calculateReadLength(blob.length(), bytes.remaining(), file.position());
- byte[] data = blob.getBytes(file.position() + 1, (int) readLength);
+ byte[] data = blob.getBytes(file.position() + 1, readLength);
bytes.put(data);
}
connection.commit();
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
----------------------------------------------------------------------
diff --git a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
index 72221f4..6dca716 100644
--- a/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
+++ b/artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
@@ -146,7 +146,7 @@ final class MappedFile implements AutoCloseable {
* then the position is updated with the number of bytes actually read.
*/
public int read(ByteBuf dst, int dstStart, int dstLength) throws IOException {
- final int remaining = (int) Math.min(this.length - this.position, (long) Integer.MAX_VALUE);
+ final int remaining = (int) Math.min(this.length - this.position, Integer.MAX_VALUE);
final int read = Math.min(remaining, dstLength);
final int bufferPosition = checkOffset(position, read);
final long srcAddress = PlatformDependent.directBufferAddress(lastMapped) + bufferPosition;
@@ -172,7 +172,7 @@ final class MappedFile implements AutoCloseable {
* then the position is updated with the number of bytes actually read.
*/
public int read(ByteBuffer dst, int dstStart, int dstLength) throws IOException {
- final int remaining = (int) Math.min(this.length - this.position, (long) Integer.MAX_VALUE);
+ final int remaining = (int) Math.min(this.length - this.position, Integer.MAX_VALUE);
final int read = Math.min(remaining, dstLength);
final int bufferPosition = checkOffset(position, read);
final long srcAddress = PlatformDependent.directBufferAddress(lastMapped) + bufferPosition;
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java
----------------------------------------------------------------------
diff --git a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java
index 38ada79..49a67c8 100644
--- a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java
+++ b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java
@@ -217,7 +217,7 @@ public class FanoutTransportBrokerTest extends OpenwireArtemisBaseTest {
// The MockTransport is on the remote connection.
// Slip in a new transport filter after the MockTransport
- MockTransport mt = (MockTransport) connection3.getTransport().narrow(MockTransport.class);
+ MockTransport mt = connection3.getTransport().narrow(MockTransport.class);
mt.install(new TransportFilter(mt.getNext()) {
@Override
public void oneway(Object command) throws IOException {
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/FailureXATest.java
----------------------------------------------------------------------
diff --git a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/FailureXATest.java b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/FailureXATest.java
index e279309..63ca340 100644
--- a/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/FailureXATest.java
+++ b/tests/extra-tests/src/test/java/org/apache/activemq/artemis/tests/extras/byteman/FailureXATest.java
@@ -88,7 +88,7 @@ public class FailureXATest extends ActiveMQTestBase {
private void doTestCrashServerAfterXACommit(boolean onePhase) throws Exception {
ActiveMQConnectionFactory connectionFactory = new ActiveMQConnectionFactory();
- XAConnection connection = (XAConnection) connectionFactory.createXAConnection();
+ XAConnection connection = connectionFactory.createXAConnection();
try {
Session session = connection.createSession(true, Session.SESSION_TRANSACTED);
http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/429e1e84/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/jms/SendingAndReceivingTest.java
----------------------------------------------------------------------
diff --git a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/jms/SendingAndReceivingTest.java b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/jms/SendingAndReceivingTest.java
index e0b1899..d298267 100644
--- a/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/jms/SendingAndReceivingTest.java
+++ b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/jms/SendingAndReceivingTest.java
@@ -89,7 +89,7 @@ public class SendingAndReceivingTest extends ActiveMQTestBase {
private static String createMessage(int messageSize) {
final String AB = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ";
Random rnd = new Random();
- StringBuilder sb = new StringBuilder((int) messageSize);
+ StringBuilder sb = new StringBuilder(messageSize);
for (int j = 0; j < messageSize; j++ ) {
sb.append(AB.charAt(rnd.nextInt(AB.length())));
}