[GitHub] [airflow] dnskr commented on pull request #29941: Reformat chart templates part 2

["dnskr (via GitHub)" <gi...@apache.org>]

dnskr commented on PR #29941:
URL: https://github.com/apache/airflow/pull/29941#issuecomment-1460741005

   Hi @jedcunningham!
   
   > Overall LGTM. Spotted some indents that might need to be nindents, but it may not matter?
   
   They should not be nindented because it will add one extra new line, i.e. the following
   ```yaml
             envFrom: {{- include "custom_airflow_environment_from" . | default "\n  []" | nindent 10 }}
             env: {{- include "custom_airflow_environment" . | nindent 10 }}
   ```
   produces
   ```yaml
             envFrom:
   
               - secretRef:
                   name: 'test-airflow-connections'
               - configMapRef:
                   name: 'test-airflow-variables'
   
             env:
   
               # Dynamically created environment variables
               - name: qwe
                 value: "rty"
               # Dynamically created secret envs
               # Extra env
               - name: AIRFLOW__CORE__LOAD_EXAMPLES
                 value: 'True'
   ```
   while current implementation
   ```yaml
             envFrom: {{- include "custom_airflow_environment_from" . | default "\n  []" | indent 10 }}
             env: {{- include "custom_airflow_environment" . | indent 10 }}
   ```
   produces
   ```yaml
             envFrom:
               - secretRef:
                   name: 'test-airflow-connections'
               - configMapRef:
                   name: 'test-airflow-variables'
   
             env:
               # Dynamically created environment variables
               - name: qwe
                 value: "rty"
               # Dynamically created secret envs
               # Extra env
               - name: AIRFLOW__CORE__LOAD_EXAMPLES
                 value: 'True'
   ```
   
   ---
   > Did you intentionally skip the [pod_template_file template](https://github.com/apache/airflow/blob/main/chart/files/pod-template-file.kubernetes-helm-yaml)?
   
   I skipped `pod-template-file.kubernetes-helm-yaml` accidently and most of `_helpers.yaml` intentionally for now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org