[GitHub] [ozone] prashantpogde commented on a diff in pull request #4991: HDDS-8939. [Snapshot] isBlockLocationSame check should be skipped if object is not OmKeyInfo.

["prashantpogde (via GitHub)" <gi...@apache.org>]

prashantpogde commented on code in PR #4991:
URL: https://github.com/apache/ozone/pull/4991#discussion_r1244248561


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1145,20 +1148,22 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
   }
 
   private SnapshotDiffObject createDiffObjectWithOldName(
-      long objectId, String oldName, SnapshotDiffObject diffObject) {
+      long objectId, String oldName, SnapshotDiffObject diffObject,
+      boolean isDirectory) {
     SnapshotDiffObjectBuilder builder = new SnapshotDiffObjectBuilder(objectId)
-        .withOldKeyName(oldName);
+        .withOldKeyName(oldName).isDirectory(isDirectory);

Review Comment:
   .setDirectory() ??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org