You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2012/07/10 14:26:34 UTC
[jira] [Created] (HIVE-3248) lack of semi-colon in .q file leads to
missing the next statement
Namit Jain created HIVE-3248:
--------------------------------
Summary: lack of semi-colon in .q file leads to missing the next statement
Key: HIVE-3248
URL: https://issues.apache.org/jira/browse/HIVE-3248
Project: Hive
Issue Type: Bug
Reporter: Namit Jain
set hive.check.par=1
select count(1) from src;
select count(1) from src;
If the above .q file is executed, the first statement is lost.
Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416064#comment-13416064 ]
Hudson commented on HIVE-3248:
------------------------------
Integrated in Hive-trunk-h0.21 #1547 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1547/])
HIVE-3248 lack of semi-colon in .q file leads to missing the next statement
(Edward Capriolo via namit) (Revision 1362364)
Result = SUCCESS
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1362364
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Namit Jain
> Assignee: Edward Capriolo
> Fix For: 0.10.0
>
> Attachments: hive-3248.1.patch.txt
>
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3248) lack of semi-colon in .q file leads to
missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo updated HIVE-3248:
----------------------------------
Fix Version/s: 0.10.0
Affects Version/s: 0.9.0
Status: Patch Available (was: Open)
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Namit Jain
> Assignee: Edward Capriolo
> Fix For: 0.10.0
>
> Attachments: hive-3248.1.patch.txt
>
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3248) lack of semi-colon in .q file leads to
missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo updated HIVE-3248:
----------------------------------
Attachment: hive-3248.1.patch.txt
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Namit Jain
> Assignee: Edward Capriolo
> Fix For: 0.10.0
>
> Attachments: hive-3248.1.patch.txt
>
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415894#comment-13415894 ]
Namit Jain commented on HIVE-3248:
----------------------------------
+1
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Namit Jain
> Assignee: Edward Capriolo
> Fix For: 0.10.0
>
> Attachments: hive-3248.1.patch.txt
>
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412518#comment-13412518 ]
Namit Jain commented on HIVE-3248:
----------------------------------
If the parameter hive.check.par in the above example is an integer, HIVE-2848 should catch this.
Isn't that right ?
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412809#comment-13412809 ]
Edward Capriolo commented on HIVE-3248:
---------------------------------------
I took this issue over. Even thought multi-line sets will rarely be used we probably do not want to remove it just to add it back later. I am suggesting we have SetProcessor warn on multi-line comments.
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Edward Capriolo
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412521#comment-13412521 ]
Navis commented on HIVE-3248:
-----------------------------
Yes, so I've noticed it while testing HIVE-2848. But what if the type is string or the key is not registered conf?
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412811#comment-13412811 ]
Edward Capriolo commented on HIVE-3248:
---------------------------------------
* warn on multi-line set statements.
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Edward Capriolo
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3248) lack of semi-colon in .q file leads to
missing the next statement
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3248:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Edward
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Namit Jain
> Assignee: Edward Capriolo
> Fix For: 0.10.0
>
> Attachments: hive-3248.1.patch.txt
>
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412517#comment-13412517 ]
Navis commented on HIVE-3248:
-----------------------------
In above case, hive sets 'hive.check.par' as '1\n\nselect count(1) from src', which is a totally valid command.
HIVE-2848 can help detecting some of these cases but generally, seemed not to be resolved, IMHO.
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Capriolo reassigned HIVE-3248:
-------------------------------------
Assignee: Edward Capriolo
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Edward Capriolo
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3248) lack of semi-colon in .q file leads
to missing the next statement
Posted by "Edward Capriolo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414396#comment-13414396 ]
Edward Capriolo commented on HIVE-3248:
---------------------------------------
{noformat}
[edward@tablitha dist]$ bin/hive
Logging initialized using configuration in jar:file:/home/edward/hive/trunk/build/dist/lib/hive-common-0.10.0-SNAPSHOT.jar!/hive-log4j.properties
Hive history file=/tmp/edward/hive_job_log_edward_201207140912_1644195707.txt
hive> set x=5;
hive> set x=dadkfjksfd
> dfkjsfd
> select * fromtable;
Warning: Value had a \n character in it
hive>
{noformat}
> lack of semi-colon in .q file leads to missing the next statement
> -----------------------------------------------------------------
>
> Key: HIVE-3248
> URL: https://issues.apache.org/jira/browse/HIVE-3248
> Project: Hive
> Issue Type: Bug
> Reporter: Namit Jain
> Assignee: Edward Capriolo
>
> set hive.check.par=1
> select count(1) from src;
> select count(1) from src;
> If the above .q file is executed, the first statement is lost.
> Found this while reviewing https://issues.apache.org/jira/browse/HIVE-2848
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira