You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/03 10:45:58 UTC

[GitHub] [spark] zhengruifeng opened a new pull request #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors

zhengruifeng opened a new pull request #26745: [SPARK-30109][ML] PCA use BLAS.gemv for sparse vectors
URL: https://github.com/apache/spark/pull/26745
 
 
   ### What changes were proposed in this pull request?
   When PCA was first impled in [SPARK-5521|https://issues.apache.org/jira/browse/SPARK-5521], at that time Matrix.multiply(BLAS.gemv internally) did not support sparse vector. So it worked around it by applying a complex matrix multiplication.
   
   Since [SPARK-7681|https://issues.apache.org/jira/browse/SPARK-7681], BLAS.gemv supported sparse vector. So we can directly use Matrix.multiply now.
   
   
   ### Why are the changes needed?
   for simplity
   
   
   ### Does this PR introduce any user-facing change?
   No
   
   
   ### How was this patch tested?
   existing testsuites

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org