[whimsy] branch master updated: TODO

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 35c782f  TODO
35c782f is described below

commit 35c782f8ed2f5b5ebe38543bace504d72e39587c
Author: Sebb <se...@apache.org>
AuthorDate: Sat Feb 27 17:31:19 2021 +0000

    TODO
---
 lib/whimsy/asf/member-files.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/whimsy/asf/member-files.rb b/lib/whimsy/asf/member-files.rb
index d5b60ba..9786fb5 100644
--- a/lib/whimsy/asf/member-files.rb
+++ b/lib/whimsy/asf/member-files.rb
@@ -55,6 +55,9 @@ module ASF
       end
     end
 
+    # TODO: change to return arrays rather than hash.
+    # This would help detect duplicate entries
+
     # Return hash of member nominees
     def self.member_nominees
       nominees = {}
@@ -74,7 +77,7 @@ module ASF
         # for board, the header currentl looks like this:
         # <PUBLIC NAME>
         id = ASF::Person.find_by_name!(hdr) || hdr # default to full name
-        nominee['Public Name'] = hdr # the board file does not have ids, unfortunately
+        nominee['Public Name'] = hdr # the board file does not have ids
         nominees[id] = nominee
       end
       nominees