You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/09 05:38:04 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
KarmaGYZ opened a new pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804
## What is the purpose of the change
When using logback it is not possible to start the taskmanager using taskamanger.sh scripts. To fix this issue, we need to make a contract that the calculation result is always outputted in the last line and in specific format. Then, we can fetch and verify it even when the log is redirected to console.
## Brief change log
- Introduce a prefix to the calculation result of `BashJavaUtils` class
- Fetch the calculation result and ignore side output.
- Fail the script when error occurs during calculation.
## Verifying this change
1. Using logback, you could follow [this guide](https://issues.apache.org/jira/browse/FLINK-15488?focusedCommentId=17009653&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17009653)
2. Start a TaskExecutor by `${FLINK_DIR}/bin/taskmanager.sh`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365588580
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
After giving it another thought, I am also fine with the current approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365253539
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
Yes indeed. Currently, the test case here is more like an end-to-end test. However, I think it's necessary to test the bash function. What do you think is the best way to cover those code path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365249851
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
Sorry, I forgot that the prefix is removed using `sed` at that point. For a unit test, I think it would be easier to invoke main from BashJavaUtils directly, and redirect System.out using `System.setOut` but that's outside the scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143839668 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
* fbcc36fa812e7ebf6fe666b36efc0014327f507d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143839668) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365063659
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
I think the result we get here does not contain the prefix. Do you mean add another test case to test the result directly from `getTmResourceDynamicConfigs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364656826
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
True, that's what I mean that should be validated. Sorry for the confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
* fbcc36fa812e7ebf6fe666b36efc0014327f507d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364760660
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
We should assert that the output is prefixed with `BASH_JAVA_UTILS_EXEC_RESULT:`. E2E test feedback is slow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364710536
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} | tail -n 1`
if [[ $? -ne 0 ]]; then
- echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}."
+ echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}." 1>&2
+ # Print the output in case the user redirect the log to console.
+ echo $output 1>&2
exit 1
fi
- echo ${output}
+ if ! [[ $output =~ ^BASH_JAVA_UTILS_EXEC_RESULT:.* ]]; then
+ echo "[ERROR] The last line of the output does not start with the certain prefix." 1>&2
Review comment:
I would put it in the following way:
`[ERROR] Unexpected result: $output`
`[ERROR] The last line of the BashJavaUtils outputs is expected to be the execution result, following the prefix "BASH_JAVA_UTILS_EXEC_RESULTS: ".`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364614042
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
If so, I prefer to add a new function called `executeScriptAndFetchLastLine`. It's a bit confusing to only return the last line from `executeScript `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365063659
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
I think the result we get here does not contain the prefix. Do you mean add another test case to test the result from `getTmResourceDynamicConfigs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364783844
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -605,26 +605,36 @@ runBashJavaUtilsCmd() {
local cmd=$1
local class_path=$2
local conf_dir=$3
+ local EXECUTION_PREFIX="BASH_JAVA_UTILS_EXEC_RESULT:"
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} | tail -n 1`
if [[ $? -ne 0 ]]; then
- echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}."
+ echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}." 1>&2
+ # Print the output in case the user redirect the log to console.
+ echo $output 1>&2
exit 1
fi
- echo ${output}
+ if ! [[ $output =~ ^${EXECUTION_PREFIX}.* ]]; then
+ echo "[ERROR] Unexpected result: $output" 1>&2
+ echo "[ERROR] The last line of the BashJavaUtils outputs is expected to be the execution result, following the prefix '${EXECUTION_PREFIX}'" 1>&2
+ echo $output 1>&2
+ exit 1
+ fi
+
+ echo ${output} | sed "s/$EXECUTION_PREFIX//g"
Review comment:
`/g` is not needed (global replacement)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143839668 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
* fbcc36fa812e7ebf6fe666b36efc0014327f507d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143839668) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364612444
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
`JavaBashTest` is a common purpose util class. I would not ignore the error stream in it, because ignoring the error stream is not a common contract.
Maybe we can override `executeScript` in `BashJavaUtilsITCase` and fetch the last line of the outputs there, because putting the results in the last line is the contract of `BashJavaUtils`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10804: [FLINK-15488] Obtain
the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572396945
cc @tillrohrmann @azagrebin @xintongsong @wangyang0918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10804: [FLINK-15488] Obtain
the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572397333
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf (Thu Jan 09 05:40:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365063659
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
I think the result we get here does not contains the prefix. Do you mean add another test case to test the result from `getTmResourceDynamicConfigs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364584641
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
##########
@@ -33,6 +33,8 @@
*/
public class BashJavaUtils {
+ private static final String EXECUTION_PREFIX = "EXEC_PREFIX:";
Review comment:
I would use something like "BASH_JAVA_UTILS_EXEC_RESULT: ".
After all, the content following it is a result rather than a prefix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #10804: [FLINK-15488] Obtain the
JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364642025
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
> In addition, I think we should add another test case to validate the `BashJavaUtils` works well when there are other noises in the outputs.
I don't think `BashJavaUtils` need to tolerant the noises in the output. The noises are filter by `runBashJavaUtilsCmd`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365063659
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
I think the result we get here does not contain the prefix. Do you mean adding another test case to test the result directly from `getTmResourceDynamicConfigs`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365509114
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
Sorry, I fear I did not get your point. First, we could directly check the correctness of `BashJavaUtils#main` here. I mean we also need to test `config.sh#runBashJavaUtilsCmd`, verify whether it filters the prefix and matches the regex correctly. After all, current approach looks good to me at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364782558
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -605,26 +605,36 @@ runBashJavaUtilsCmd() {
local cmd=$1
local class_path=$2
local conf_dir=$3
+ local EXECUTION_PREFIX="BASH_JAVA_UTILS_EXEC_RESULT:"
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} | tail -n 1`
if [[ $? -ne 0 ]]; then
- echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}."
+ echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}." 1>&2
+ # Print the output in case the user redirect the log to console.
+ echo $output 1>&2
exit 1
fi
- echo ${output}
+ if ! [[ $output =~ ^${EXECUTION_PREFIX}.* ]]; then
+ echo "[ERROR] Unexpected result: $output" 1>&2
+ echo "[ERROR] The last line of the BashJavaUtils outputs is expected to be the execution result, following the prefix '${EXECUTION_PREFIX}'" 1>&2
Review comment:
Maybe a bit shorter:
```
Expected last line in BashJavaUtils output to be the execution result, following the prefix '${EXECUTION_PREFIX}'
```
Also note the singular _output_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364610607
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
I think we could ignore the error stream in `JavaBashTestBase#executeScript`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365322482
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
Would it be possible to invoke `BashJavaUtils#main` directly, and use `System.setOut` to redirect the output to stdout to a different stream?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10804: [FLINK-15488] Obtain
the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on issue #10804: [FLINK-15488] Obtain
the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572516573
Thanks for the review @xintongsong . PR updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364613032
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
In addition, I think we should add another test case to validate the `BashJavaUtils` works well when there are other noises in the outputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143723257 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222 TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143727652 TriggerType:PUSH TriggerID:a3a5ebe9a127c7e959fb65cd5d517335bfc97071
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143839668 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
Hash:fbcc36fa812e7ebf6fe666b36efc0014327f507d Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243 TriggerType:PUSH TriggerID:fbcc36fa812e7ebf6fe666b36efc0014327f507d
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143723257) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4222)
* a3a5ebe9a127c7e959fb65cd5d517335bfc97071 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143727652) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4225)
* fbcc36fa812e7ebf6fe666b36efc0014327f507d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143839668) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4243)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10804: [FLINK-15488] Obtain the JVM
and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-573049886
LGTM. Merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364601882
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
If we remove `2> /dev/null`, log will pollute the output in the `testGetTmResourceDynamicConfigs` test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364605483
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
Shouldn't we also take the last line of the outputs out in `BashJavaUtilsITCase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364615430
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
Sounds good.
We can also specify `RUN_BASH_JAVA_UTILS_CMD_SCRIPT` in `executeScriptAndFetchLastLine`, leaving `GET_TM_RESOURCE_DYNAMIC_CONFIGS/GET_TM_RESOURCE_JVM_PARAMS` the only argument of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364784352
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/JavaBashTestBase.java
##########
@@ -49,12 +48,6 @@ protected String executeScript(final String[] command) throws IOException {
ProcessBuilder pb = new ProcessBuilder(command);
pb.redirectErrorStream(true);
Process process = pb.start();
- BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()));
- StringBuilder sb = new StringBuilder();
- String s;
- while ((s = reader.readLine()) != null) {
- sb.append(s);
- }
- return sb.toString();
+ return IOUtils.toString(process.getInputStream());
Review comment:
Should have been a separate commit but you don't need to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364582906
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
Review comment:
I think `2> /dev/null` is no longer necessary and can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r365249851
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -34,21 +36,30 @@
private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
+ /**
+ * Executes the given shell script wrapper and returns the last line.
+ */
+ private String executeScriptAndFetchLastLine(final String command) throws IOException {
+ String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
+ String[] lines = executeScript(commands).split(System.lineSeparator());
+ if (lines.length == 0) {
+ return "";
+ } else {
+ return lines[lines.length - 1];
+ }
+ }
+
@Test
public void testGetTmResourceDynamicConfigs() throws Exception {
- String[] command = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT,
- BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString()};
- String result = executeScript(command);
+ String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
assertNotNull(result);
Review comment:
Sorry, I forgot that the prefix is removed using `sed` at that point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KarmaGYZ edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
KarmaGYZ edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572396945
cc @tillrohrmann @azagrebin @xintongsong @wangyang0918 @dawidwys
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #10804:
[FLINK-15488] Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#discussion_r364583805
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -606,25 +606,33 @@ runBashJavaUtilsCmd() {
local class_path=$2
local conf_dir=$3
- local output="`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null`"
+ local output=`${JAVA_RUN} -classpath ${class_path} org.apache.flink.runtime.util.BashJavaUtils ${cmd} --configDir ${conf_dir} 2> /dev/null | tail -n 1`
if [[ $? -ne 0 ]]; then
- echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}."
+ echo "[ERROR] Cannot run BashJavaUtils to execute command ${cmd}." 1>&2
+ # Print the output in case the user redirect the log to console.
+ echo $output 1>&2
exit 1
fi
- echo ${output}
+ if ! [[ $output =~ ^EXEC_PREFIX:.* ]]; then
+ echo "[ERROR] The output format is incorrect." 1>&2
Review comment:
I would state clearly the last line of the output is excepted to be the BashJavaUtils execution result with the certain prefix. This will help people understand which contract is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10804: [FLINK-15488]
Obtain the JVM and TM param correctly
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10804: [FLINK-15488] Obtain the JVM and TM param correctly
URL: https://github.com/apache/flink/pull/10804#issuecomment-572399586
<!--
Meta data
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143675806 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206 TriggerType:PUSH TriggerID:1bdc001077b6c87a7b27598ed01d250d3d5c4fbf
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/143680509 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:bc2b1f3205f1925e050cfb6f913bde9659e1a563 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208 TriggerType:PUSH TriggerID:bc2b1f3205f1925e050cfb6f913bde9659e1a563
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143683037 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:3a660ec4a29ff9175b7c857857897345946ca669 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209 TriggerType:PUSH TriggerID:3a660ec4a29ff9175b7c857857897345946ca669
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143713998 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216 TriggerType:PUSH TriggerID:84651f75a6a5f87d427a906c2eb67e1e51fb63c6
Hash:7ba78be0b6801aed2032ee47dfe548379fa73238 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7ba78be0b6801aed2032ee47dfe548379fa73238
-->
## CI report:
* 1bdc001077b6c87a7b27598ed01d250d3d5c4fbf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143675806) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4206)
* bc2b1f3205f1925e050cfb6f913bde9659e1a563 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/143680509) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4208)
* 3a660ec4a29ff9175b7c857857897345946ca669 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143683037) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4209)
* 84651f75a6a5f87d427a906c2eb67e1e51fb63c6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143713998) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4216)
* 7ba78be0b6801aed2032ee47dfe548379fa73238 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services