[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1354: MINIFICPP-1860 Integrate readability clang-tidy checks in CI

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1354:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1354#discussion_r923548271


##########
libminifi/src/core/Connectable.cpp:
##########
@@ -76,11 +72,7 @@ bool Connectable::isSupportedRelationship(const core::Relationship &relationship
   const auto conditionalLock = isConnectableRunning ? std::unique_lock<std::mutex>() : std::unique_lock<std::mutex>(relationship_mutex_);
 
   const auto &it = relationships_.find(relationship.getName());
-  if (it != relationships_.end()) {
-    return true;
-  } else {
-    return false;
-  }
+  return it != relationships_.end();

Review Comment:
   Good idea, updated in 1e565fb3ed786137ba5410991273a85cf5102a6a



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org