You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2021/01/21 00:36:25 UTC

[GitHub] [wicket] solomax commented on a change in pull request #461: Add @Autowired annotation to SpringInjector

solomax commented on a change in pull request #461:
URL: https://github.com/apache/wicket/pull/461#discussion_r561433386



##########
File path: wicket-spring/src/main/java/org/apache/wicket/spring/injection/annot/AnnotProxyFieldValueFactory.java
##########
@@ -117,18 +118,26 @@ public Object getFieldValue(final Field field, final Object fieldOwner)
 		{
 			SpringBean annot = field.getAnnotation(SpringBean.class);
 
-			String name;
-			boolean required;
+			String name = null;
+			Boolean required = true;

Review comment:
       I would declare this one as `boolean` it seems to be not nullable :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org