[2/2] mesos git commit: Added a TODO about possible security issues due to misspelled ACLs.

[al...@apache.org]

Added a TODO about possible security issues due to misspelled ACLs.

Review: https://reviews.apache.org/r/48937/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e7bf541c
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e7bf541c
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e7bf541c

Branch: refs/heads/master
Commit: e7bf541c9d78c3ef04ec88b3f723a73aa4a7e1ff
Parents: 30d703f
Author: Alexander Rukletsov <ru...@gmail.com>
Authored: Mon Jun 20 15:35:51 2016 +0200
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Mon Jun 20 15:35:51 2016 +0200

----------------------------------------------------------------------
 src/authorizer/local/authorizer.cpp | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/e7bf541c/src/authorizer/local/authorizer.cpp
----------------------------------------------------------------------
diff --git a/src/authorizer/local/authorizer.cpp b/src/authorizer/local/authorizer.cpp
index 60dfe10..2c20a30 100644
--- a/src/authorizer/local/authorizer.cpp
+++ b/src/authorizer/local/authorizer.cpp
@@ -762,6 +762,11 @@ Option<Error> LocalAuthorizer::validate(const ACLs& acls)
     }
   }
 
+  // TODO(alexr): Consider validating not only protobuf, but also the original
+  // JSON in order to spot misspelled names. A misspelled action may affect
+  // authorization result and hence lead to a security issue (e.g. when there
+  // are entries with same action but different subjects or objects).
+
   return None();
 }