You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "moonming (via GitHub)" <gi...@apache.org> on 2023/11/14 03:00:51 UTC
Re: [PR] docs: remove name attribute from logging plugins [apisix]
moonming commented on PR #10476:
URL: https://github.com/apache/apisix/pull/10476#issuecomment-1809469188
> Just saw in `clickhouse-logger` and `sys-logger` the namea are indeed configurable:
>
> https://github.com/apache/apisix/blob/d8bd34414239ed36942c19f435ac10ad0d5e57c0/apisix/plugins/clickhouse-logger.lua#L28-L41
>
> 
>
> Are we going to:
>
> 1. make the other logger plugin names configurable as well;
> 2. update `clickhouse logger` and `sys logger` to be consistent with others, which hard code the name; or
> 3. Just update the docs for those that are not configurable (done)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org