You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/06/30 02:10:22 UTC

[GitHub] brooklyn-server issue #746: [WIP] Auto wrap YAML BOMs as catalog bundles

Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/746
  
    have done a big job to make things use the TypeRegistry instead of the old catalog, and to add to type registry in an `UNRESOLVED` state first.  this fixes the big problem by adding types from all bundles into an unresolved state, then resolving them.
    
    it has ended up much bigger than i meant BUT it has several main advantages:
    
    * we no longer persist catalog item XML for things where we persist the OSGi bundle
    * we're very close to being able to remove nearly all the clunky "catalog" code; apart from items that were persisted as XML everything uses the new type registry now
    
    the logic for guessing the supertypes is messy, hooking in to the old `Guessing` interpreter in a brittle way, but if we plan to remove old catalog code (and annotations scanning) we can rewrite it all to be much simpler and nicer.
    
    note this PR is still WIP, not working 100%; we don't support templates in the registry yet, locations need attention, and there are quite a few TODO items to look at.  but wanted to give people sight of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---