[GitHub] [lucene-solr] dweiss commented on a change in pull request #606: LUCENE-8671: Allow more fine-grained control over off-heap term dictionaries

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #606: LUCENE-8671: Allow more fine-grained control over off-heap term dictionaries
URL: https://github.com/apache/lucene-solr/pull/606#discussion_r264720893
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/store/ByteBuffersIndexInput.java
 ##########
 @@ -193,5 +193,10 @@ private void ensureOpen() {
     if (in == null) {
       throw new AlreadyClosedException("Already closed.");
     }
-  }  
+  }
+
+  @Override
+  public boolean isMMapped() {
+    return true;
 
 Review comment:
   Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org