[jira] [Created] (SLING-5490) servlet-helpers: Add locale support to MockSlingHttpServletRequest and MockSlingHttpServletResponse

["Stefan Seifert (JIRA)" <ji...@apache.org>]

Stefan Seifert created SLING-5490:
-------------------------------------

             Summary: servlet-helpers: Add locale support to MockSlingHttpServletRequest and MockSlingHttpServletResponse
                 Key: SLING-5490
                 URL: https://issues.apache.org/jira/browse/SLING-5490
             Project: Sling
          Issue Type: Improvement
          Components: Extensions
            Reporter: Stefan Seifert
            Assignee: Stefan Seifert
             Fix For: Servlet Helpers 1.0.0


{quote}
-----Original Message-----
From: Justin Edelson [mailto:justin@justinedelson.com] 
Sent: Friday, January 22, 2016 5:54 PM
To: dev@sling.apache.org
Subject: MockSlingHttpServletResponse doesn't support getLocale()

Hi,
I was looking at MockSlingHttpServletResponse (
https://github.com/apache/sling/blob/trunk/bundles/extensions/servlet-helpers/src/main/java/org/apache/sling/servlethelpers/MockSlingHttpServletResponse.java)
and was wondering if there was a specific reason why getLocale() isn't
supported. IIUC (and to be honest, I wasn't 100% following this
discussion), this class is now intended to be used in concert with the
SlingRequestProcessor interface (as opposed to just unit tests). If so, it
seems like supporting getLocale() would be important as servlets/scripts
might depend upon this.

I can make this change super-quick, but wanted to check first to see if
there was a reason not to implement it.

Thanks,
Justin
{quote}

additionally we should make the locale in MockSlingHttpServletRequest configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)