You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2026/04/01 14:45:39 UTC

(ofbiz-framework) 01/02: Fixed: Pressing sort button in any UI view will end with NPE (OFBIZ-13378)

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 0f0d344d83925f17a2230876eff5308ffecb5dc7
Author: Anahita Goljahani <an...@gmail.com>
AuthorDate: Tue Mar 31 16:27:59 2026 +0200

    Fixed: Pressing sort button in any UI view will end with NPE (OFBIZ-13378)
    
    Pressing sort button for field ends with error:
    java.lang.NullPointerException: Cannot invoke "Object.getClass()"
    because "object" is null ControlFilter.java:188
    
     if ( (object.getClass().equals(String.class) || object instanceof Collection))
     
    need to be:
     
    if ( object != null && (object.getClass().equals(String.class)
            || object instanceof Collection))
    
    Thanks: Vitaly Repetenko
---
 .../src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
index b604dbb59d..acc7d3a704 100644
--- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
+++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlFilter.java
@@ -180,8 +180,7 @@ public class ControlFilter extends HttpFilter {
             if (!parameters.isEmpty()) {
                 for (String key : parameters.keySet()) {
                     Object object = parameters.get(key);
-                    if (object.getClass().equals(String.class)
-                            || object instanceof Collection) {
+                    if (object != null && (object.getClass().equals(String.class) || object instanceof Collection)) {
                         try {
                             List<String> toCheck = object.getClass().equals(String.class)
                                     ? List.of((String) object)