You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/01 21:26:13 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #20115: [CD] Tag "release" to pip wheels in CD
Zha0q1 opened a new pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115
Now when we trigger a cd release build we get pip wheels with "REALEASE" attached to the file name. e.g. `mxnet-2.0.0RELEASE-py3-none-manylinux2014_x86_64.whl`
Refer to https://dist.mxnet.io/python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #20115: [CD] Tag "release" to pip wheels in CD
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115#discussion_r605986812
##########
File path: tools/pip/setup.py
##########
@@ -58,6 +58,10 @@
elif travis_tag.startswith('patch-'):
__version__ = os.environ['TRAVIS_TAG'].split('-')[1]
+# release tag
+elif is_release:
+ __version__ += 'RELEASE'
Review comment:
@leezu thanks for reviewing! I thought we would manually rename the file. In this case I can simply remove the "RELEASE" and then `mxnet-2.0.0-py3-none-manylinux2014_x86_64.whl` should be compliant I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #20115: [CD] Fix the name of the pip wheels in CD
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115#discussion_r606256799
##########
File path: ci/build.py
##########
@@ -270,7 +277,7 @@ def main() -> int:
command = list(chain.from_iterable(args.command))
environment = dict([(e.split('=')[:2] if '=' in e else (e, os.environ[e]))
for e in args.environment])
-
+ print(environment)
Review comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20115: [CD] Tag "release" to pip wheels in CD
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115#issuecomment-812181551
Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, unix-gpu, centos-cpu, website, centos-gpu, miscellaneous, sanity, edge, unix-cpu, windows-gpu, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20115: [CD] Tag "release" to pip wheels in CD
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115#discussion_r605979848
##########
File path: tools/pip/setup.py
##########
@@ -58,6 +58,10 @@
elif travis_tag.startswith('patch-'):
__version__ = os.environ['TRAVIS_TAG'].split('-')[1]
+# release tag
+elif is_release:
+ __version__ += 'RELEASE'
Review comment:
"mxnet-2.0.0RELEASE-py3-none-manylinux2014_x86_64.whl" may not be the correct naming scheme for uploading to Pypi. Also if we install mxnet from pypi and call `mxnet.__version__`, seeing `2.0.0.alphaRELEASE` may be unexpected. Do you think we should generate the wheels to be ready for upload?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #20115: [CD] Fix the name of the pip wheels in CD
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #20115:
URL: https://github.com/apache/incubator-mxnet/pull/20115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org