You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/25 17:37:19 UTC
[GitHub] [shardingsphere] TaoZhiMLND opened a new pull request #5312: move logic of isTableExist to TableMetaDataLoader#load.
TaoZhiMLND opened a new pull request #5312:
URL: https://github.com/apache/shardingsphere/pull/5312
Fixes #5309.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cherrylzhao commented on pull request #5312: move logic of isTableExist to TableMetaDataLoader#load.
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on pull request #5312:
URL: https://github.com/apache/shardingsphere/pull/5312#issuecomment-619482711
good job! LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TaoZhiMLND commented on pull request #5312: move logic of isTableExist to TableMetaDataLoader#load.
Posted by GitBox <gi...@apache.org>.
TaoZhiMLND commented on pull request #5312:
URL: https://github.com/apache/shardingsphere/pull/5312#issuecomment-619415889
Because of the following Exception, I removed two mockito stubbings.
```
Process finished with exit code -1
org.mockito.exceptions.misusing.UnnecessaryStubbingException:
Unnecessary stubbings detected in test class: ColumnMetaDataLoaderTest
Clean & maintainable test code requires zero unnecessary code.
Following stubbings are unnecessary (click to navigate to relevant line of code):
1. -> at org.apache.shardingsphere.sql.parser.binder.metadata.column.ColumnMetaDataLoaderTest.setUp(ColumnMetaDataLoaderTest.java:76)
2. -> at org.apache.shardingsphere.sql.parser.binder.metadata.column.ColumnMetaDataLoaderTest.setUp(ColumnMetaDataLoaderTest.java:77)
Please remove unnecessary stubbings or use 'silent' option. More info: javadoc for UnnecessaryStubbingException class.
at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:49)
at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:161)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #5312: move logic of isTableExist to TableMetaDataLoader#load.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5312:
URL: https://github.com/apache/shardingsphere/pull/5312#issuecomment-619417786
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=h1) Report
> Merging [#5312](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3c5f42972ab56a4d08b2c9407bd3e453d6b3914c&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `15.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5312 +/- ##
============================================
- Coverage 53.69% 53.67% -0.02%
Complexity 413 413
============================================
Files 1163 1163
Lines 20792 20795 +3
Branches 3766 3767 +1
============================================
- Hits 11164 11162 -2
- Misses 8904 8910 +6
+ Partials 724 723 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sphere/encrypt/metadata/EncryptMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdE1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `71.42% <ø> (+3.34%)` | `0.00 <0.00> (ø)` | |
| [...ser/binder/metadata/table/TableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvdGFibGUvVGFibGVNZXRhRGF0YUxvYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/preparer/splitter/InventoryDataTaskSplitter.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3ByZXBhcmVyL3NwbGl0dGVyL0ludmVudG9yeURhdGFUYXNrU3BsaXR0ZXIuamF2YQ==) | `89.23% <40.00%> (-4.32%)` | `1.00 <0.00> (ø)` | |
| [...shardingscaling/core/metadata/MetaDataManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5312/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL21ldGFkYXRhL01ldGFEYXRhTWFuYWdlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=footer). Last update [3c5f429...0b15aff](https://codecov.io/gh/apache/shardingsphere/pull/5312?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5312: move logic of isTableExist to TableMetaDataLoader#load.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5312:
URL: https://github.com/apache/shardingsphere/pull/5312#issuecomment-619418276
## Pull Request Test Coverage Report for [Build 11243](https://coveralls.io/builds/30339860)
* **4** of **20** **(20.0%)** changed or added relevant lines in **5** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.02%**) to **57.216%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [encrypt-core/encrypt-core-common/src/main/java/org/apache/shardingsphere/encrypt/metadata/EncryptMetaDataLoader.java](https://coveralls.io/builds/30339860/source?filename=encrypt-core%2Fencrypt-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmetadata%2FEncryptMetaDataLoader.java#L48) | 0 | 2 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/splitter/InventoryDataTaskSplitter.java](https://coveralls.io/builds/30339860/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2Fsplitter%2FInventoryDataTaskSplitter.java#L90) | 3 | 5 | 60.0%
| [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/30339860/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L84) | 0 | 6 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/30339860/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L48) | 0 | 6 | 0.0%
<!-- | **Total:** | **4** | **20** | **20.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/table/TableMetaDataLoader.java](https://coveralls.io/builds/30339860/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fmetadata%2Ftable%2FTableMetaDataLoader.java#L58) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/30339860) |
| :-- | --: |
| Change from base [Build 11241](https://coveralls.io/builds/30318418): | -0.02% |
| Covered Lines: | 11898 |
| Relevant Lines: | 20795 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org