[GitHub] spark pull request #13962: [SPARK-16095][YARN] Yarn cluster mode should repo...

[renozhang <gi...@git.apache.org>]

Github user renozhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13962#discussion_r69253305
  
    --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
    @@ -330,9 +373,6 @@ private object YarnClusterDriver extends Logging with Matchers {
     }
     
     private object YarnClasspathTest extends Logging {
    -
    -  var exitCode = 0
    --- End diff --
    
    Not removing this will break test, because System.exit(0) will cause app end with status 'FAILED' (after changed in v2.0 by https://github.com/apache/spark/commit/d89c71417c384e1a2820bd80b67c26e11405aebc)
    So I should remove this System.exit().



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org