You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/01 20:55:30 UTC
[PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Ma77Ball opened a new pull request, #5311:
URL: https://github.com/apache/texera/pull/5311
### What changes were proposed in this PR?
- Add an `attemptRegister` flag to `DashboardComponent.forumLogin` so a Flarum registration is attempted at most once, breaking the infinite `auth -> register -> auth` cycle that occurred when `auth()` kept failing with a non-404/500 status.
- After registering, the recursive call now passes `forumLogin(false)`; if auth still fails on that pass it falls through to `displayForum = false` instead of looping.
- Add an error handler to the `register()` subscription so a failed registration hides the forum rather than being silently dropped.
### Any related issues, documentation, or discussions?
Closes: #5310
### How was this PR tested?
- Ran `yarn format:fix` (clean, no files changed).
- Manually traced the control flow: auth fail (non-404/500) now does auth, register, auth, then stop, instead of recursing without bound.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #5311:
URL: https://github.com/apache/texera/pull/5311#issuecomment-4634136780
Hi @Ma77Ball, we'd like to include this fix in the v1.2 release. Since this PR was merged before the release/v1.2 label existed, the auto-backport didn't trigger. Could you open a manual backport PR targeting release/v1.2? Please note in the PR description that it is a backport and link the original PR (#5311). Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #5311:
URL: https://github.com/apache/texera/pull/5311#issuecomment-4596471258
@aglinxinyuan could you PTAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5311:
URL: https://github.com/apache/texera/pull/5311#issuecomment-4596490616
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5311?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `25.00000%` with `3 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.93%. Comparing base ([`eb287f3`](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`302e834`](https://app.codecov.io/gh/apache/texera/commit/302e834f5d8663f48eccdca53fe84ceb62498e52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/5311?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...src/app/dashboard/component/dashboard.component.ts](https://app.codecov.io/gh/apache/texera/pull/5311?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fdashboard%2Fcomponent%2Fdashboard.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9kYXNoYm9hcmQvY29tcG9uZW50L2Rhc2hib2FyZC5jb21wb25lbnQudHM=) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/5311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5311 +/- ##
============================================
- Coverage 49.97% 49.93% -0.04%
Complexity 2421 2421
============================================
Files 1052 1052
Lines 40780 40782 +2
Branches 4356 4356
============================================
- Hits 20378 20365 -13
- Misses 19193 19208 +15
Partials 1209 1209
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.89% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.01% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.38% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `54.68% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.42% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.37% <25.00%> (-0.07%)` | :arrow_down: | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.80% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.80% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.39% <ø> (ø)` | | Carriedforward from [eb287f3](https://app.codecov.io/gh/apache/texera/commit/eb287f3fc2cbba5416d851078affc10537123e68?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5311?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5311:
URL: https://github.com/apache/texera/pull/5311#issuecomment-4596459342
/request-review @Yicong-Huang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #5311:
URL: https://github.com/apache/texera/pull/5311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(frontend): stop forum login from looping when Flarum auth fails [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #5311:
URL: https://github.com/apache/texera/pull/5311#issuecomment-4596497645
General comment: can you use a test to guard this behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org