You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/02/12 03:59:02 UTC
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/466
TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-3917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit 7f7e16884c80b8e8ddfb4f8d56f4ac1bb9635512
Author: Bryan Call <bc...@apache.org>
Date: 2016-02-12T02:58:08Z
TS-3917: Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/466#discussion_r52704287
--- Diff: proxy/http2/HTTP2.cc ---
@@ -727,7 +727,7 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t *buf_start, const uint8_t
}
// Initialize this subsystem with librecords configs (for now)
-uint32_t Http2::max_concurrent_streams = 100;
+uint32_t Http2::max_concurrent_streams = 4294967295;
--- End diff --
This variable is override by `proxy.config.http2.max_concurrent_streams_in` in [Http2::init()](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.cc#L743).
IMO, where we should change is `HTTP2_MAX_CONCURRENT_STREAMS` in [HTTP2.h#L57](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.h#L57)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183178397
@bryancall OK :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183178115
@masaori335 You are right :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183174731
@masaori335 I am pretty sure the compare when setting the settings uses this value to compare with.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183162557
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3917: Sending only SETTINGS_INITIAL...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/466#issuecomment-183175215
@bryancall Oh really? I'll check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---