You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by shailendra14k <gi...@git.apache.org> on 2018/06/16 04:07:52 UTC
[GitHub] activemq-artemis pull request #2146: [ARTEMIS-1939]Remove space from paramet...
GitHub user shailendra14k opened a pull request:
https://github.com/apache/activemq-artemis/pull/2146
[ARTEMIS-1939]Remove space from parameter annotations name in ActiveMQServerControl
JIRA:- https://issues.apache.org/jira/browse/ARTEMIS-1939
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shailendra14k/activemq-artemis ARTEMIS-1939
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2146
----
commit a068f7aeed6e9be241e85cebd5a4072af48238fa
Author: Shailendra Kumar Singh <sh...@...>
Date: 2018-06-16T03:49:54Z
[ARTEMIS-1939]Remove space from parameter annotations name in ActiveMQServerControl
----
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
it's just changing the parameter name.. why is this an issue?
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
Does this change the current exposed JMX endpoints?
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
@clebertsuconic thanks.
---
[GitHub] activemq-artemis pull request #2146: [ARTEMIS-1939]Remove space from paramet...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2146
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
@clebertsuconic its a point that if its changing a public exposed api which jmx is then is the change back compatible. As existing users will/could have code hooked in for monitoring or other reasons
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
I already saw it...
will merge it and bring it into 2.6.x
---
[GitHub] activemq-artemis issue #2146: [ARTEMIS-1939]Remove space from parameter anno...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2146
@michaelandrepearce From my interpretation.. these are only used in querying arguments.. for the actual calls you just need to pass in arguments... so I did not see any issue with compatibility because of that.
We have a few tests within the testsuite and they are not affected.
SO think it's safe!
---