You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Nikita-Shupletsov (via GitHub)" <gi...@apache.org> on 2025/12/08 23:46:22 UTC
[PR] KAFKA-19096: Added checks for the number of dropped records to innerJoinShouldPropagateNothingWhenOldAndNewFKIsNull and innerJoinShouldNotPropagateDeletionOfPrimaryKeyWhenPreviousFKIsNull tests. [kafka]
Nikita-Shupletsov opened a new pull request, #21111:
URL: https://github.com/apache/kafka/pull/21111
The actual fix: https://github.com/apache/kafka/pull/20605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19096: Added checks for the number of dropped records to innerJoinShouldPropagateNothingWhenOldAndNewFKIsNull and innerJoinShouldNotPropagateDeletionOfPrimaryKeyWhenPreviousFKIsNull tests. [kafka]
Posted by "Nikita-Shupletsov (via GitHub)" <gi...@apache.org>.
Nikita-Shupletsov commented on code in PR #21111:
URL: https://github.com/apache/kafka/pull/21111#discussion_r2600541768
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java:
##########
@@ -295,6 +295,10 @@ public void innerJoinShouldPropagateNothingWhenOldAndNewFKIsNull() {
innerJoinProcessor.process(new Record<>(pk, new Change<>(leftRecordValue, leftRecordValue), 0));
assertThat(context.forwarded(), empty());
+
+ // test dropped-records sensors
+ assertEquals(1.0, getDroppedRecordsTotalMetric(context));
Review Comment:
according to the comment: https://github.com/mjsax/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java#L177
it's an invalid situation, so we report it as a dropped record.
Please correct me if I am wrong with my conclusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19096: Added checks for the number of dropped records to foreign key join tests. [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #21111:
URL: https://github.com/apache/kafka/pull/21111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org