You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "olamy (via GitHub)" <gi...@apache.org> on 2025/03/08 09:38:25 UTC
[PR] Restore Jenkins build for master [maven]
olamy opened a new pull request, #2151:
URL: https://github.com/apache/maven/pull/2151
- **Revert "Disable Jenkins temporarily"**
- **use maven3**
- **versionlessMavenDist profile is failing test**
- **fix ITs branch**
- **cannot run embedded ITs with maven4**
- **use mvnw**
- **use mvnw**
- **fix build of temporary distro**
- **fix build of temporary distro**
- **use -PversionlessMavenDist for its**
- **test if distro really here**
- **test if distro really here**
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore Jenkins build for master [maven]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #2151:
URL: https://github.com/apache/maven/pull/2151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore Jenkins build for master [maven]
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on code in PR #2151:
URL: https://github.com/apache/maven/pull/2151#discussion_r1996482114
##########
its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java:
##########
@@ -260,6 +261,17 @@ protected Verifier newVerifier(String basedir, boolean debug) throws Verificatio
protected Verifier newVerifier(String basedir, String settings, boolean debug) throws VerificationException {
Verifier verifier = new Verifier(basedir);
+ // try to get jacoco arg from command line if any then use it to start IT to populate jacoco data
Review Comment:
I just leave it but it's not activated in the build as it's definitely too slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore Jenkins build for master [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #2151:
URL: https://github.com/apache/maven/pull/2151#discussion_r1986123655
##########
Jenkinsfile:
##########
@@ -21,11 +21,11 @@ properties([buildDiscarder(logRotator(artifactNumToKeepStr: '5', numToKeepStr: e
def buildOs = 'linux'
def buildJdk = '17'
-def buildMvn = '3.8.x'
+def buildMvn = '4.0.0-rc-2'
Review Comment:
I think 3.9.9 should be better (as "latest stable")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore Jenkins build for master [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #2151:
URL: https://github.com/apache/maven/pull/2151#discussion_r1986123726
##########
Jenkinsfile:
##########
@@ -21,11 +21,11 @@ properties([buildDiscarder(logRotator(artifactNumToKeepStr: '5', numToKeepStr: e
def buildOs = 'linux'
def buildJdk = '17'
-def buildMvn = '3.8.x'
+def buildMvn = '4.0.0-rc-2'
def runITsOses = ['linux']
def runITsJdks = ['17', '21']
-def runITsMvn = '3.8.x'
-def runITscommand = "mvn clean install -Prun-its,embedded -B -U -V" // -DmavenDistro=... -Dmaven.test.failure.ignore=true
+def runITsMvn = '4.0.0-rc-2'
Review Comment:
I'd make this as GH CI does: run IT build _and_ run ITs with "just built" master maven instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org