[jira] [Updated] (PIG-1925) Parser error message doesn't show location of the error or show it as Line 0:0

["Xuefu Zhang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xuefu Zhang updated PIG-1925:
-----------------------------

    Attachment: PIG-1925.patch

With the patch, the error message is emitted as:

grunt> A = load 'x' as (u, v, u, w);
2011-03-21 10:10:27,067 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 0: Line 1:23 duplicated alias in schema: u

Unit test passed.
Test-patch run result (Additional JAVACC warnings due to generated code):

     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     -1 javac.  The applied patch generated 888 javac compiler warnings (more than the trunk's current 877 warnings).
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.


> Parser error message doesn't show location of the error or show it as Line 0:0
> ------------------------------------------------------------------------------
>
>                 Key: PIG-1925
>                 URL: https://issues.apache.org/jira/browse/PIG-1925
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>             Fix For: 0.9.0
>
>         Attachments: PIG-1925.patch
>
>
> When Parser emits an error from one of the tree parsers (like AST validation or plan generation), Line number is missing or printed as Line 0:0. Further investigation shows that Antlr 3.2 isn't able to report the correct line number and line offset. We need to address it in Pig code.
> The following is an example.
> grunt> A = load 'x' as (u, v, u, w);
> 2011-03-21 10:04:44,486 [main] ERROR org.apache.pig.tools.grunt.Grunt - ERROR 0: Duplicated alias in schema: u
> It's desirable to have line number/offset in such kind of error messages.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira