You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/17 14:26:20 UTC

[GitHub] [incubator-doris] jacktengg opened a new pull request, #9620: [Improvement] make BE can exit normally and ASAN memory leak checking work properly

jacktengg opened a new pull request, #9620:
URL: https://github.com/apache/incubator-doris/pull/9620

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   ASAN memory leak checking works only when process exit normally. Currently doris BE will coredump when receiving SIGINT or SIGTERM, caused by unproper use of Thread:
   ```
   terminate called without an active exception
   Minidump created at: /mnt/disk1/xxx/incubator-doris_master/output/be/minidump/c68b2f2d-5659-4c68-f03167b2-03a6c545.dmp
   *** Aborted at 1652797366 (unix time) try "date -d @1652797366" if you are using GNU date ***
   *** SIGABRT unkown detail explain (@0x3f50012844a) received by PID 1213514 (TID 0x7f43c07da4c0) from PID 1213514; stack trace: ***
    0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk1/xxx/incubator-doris_master/be/src/common/signal_handler.h:407
    1# 0x00007F43BFAB5AD0 in /lib64/libc.so.6
    2# __GI_raise in /lib64/libc.so.6
    3# abort in /lib64/libc.so.6
    4# __gnu_cxx::__verbose_terminate_handler() [clone .cold] in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
    5# __cxxabiv1::__terminate(void (*)()) in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
    6# 0x0000562CB2DA71D1 in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
    7# std::thread::~thread() at /mnt/disk1/xxx/local/ldb_toolchain/include/c++/11/bits/std_thread.h:153
    8# doris::ThreadGroup::~ThreadGroup() at /mnt/disk1/xxx/incubator-doris_master/be/src/util/thread_group.h:32
    9# doris::PriorityWorkStealingThreadPool::~PriorityWorkStealingThreadPool() in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
   10# doris::PriorityWorkStealingThreadPool::~PriorityWorkStealingThreadPool() in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
   11# doris::ExecEnv::_destroy() at /mnt/disk1/xxx/incubator-doris_master/be/src/runtime/exec_env_init.cpp:319
   12# doris::ExecEnv::destroy(doris::ExecEnv*) at /mnt/disk1/xxx/incubator-doris_master/be/src/runtime/exec_env_init.cpp:340
   13# main at /mnt/disk1/xxx/incubator-doris_master/be/src/service/doris_main.cpp:509
   14# __libc_start_main in /lib64/libc.so.6
   15# _start in /mnt/disk1/xxx/incubator-doris_master/output/be/lib/palo_be
   
   bin/start_be.sh: line 175: 1213514 Aborted                 (core dumped) $LIMIT ${DORIS_HOME}/lib/palo_be "$@" 2>&1 < /dev/null
   ```
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9620: [Improvement] make BE can exit normally and ASAN memory leak checking work properly

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9620:
URL: https://github.com/apache/incubator-doris/pull/9620#issuecomment-1129421685

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] yiguolei merged pull request #9620: [Improvement] make BE can exit normally and ASAN memory leak checking work properly

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9620:
URL: https://github.com/apache/incubator-doris/pull/9620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9620: [Improvement] make BE can exit normally and ASAN memory leak checking work properly

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9620:
URL: https://github.com/apache/incubator-doris/pull/9620#issuecomment-1129421697

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org