You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Ray Ingles (Jira)" <ji...@apache.org> on 2021/09/16 20:15:00 UTC

[jira] [Resolved] (GEODE-9495) remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup

     [ https://issues.apache.org/jira/browse/GEODE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ray Ingles resolved GEODE-9495.
-------------------------------
    Fix Version/s: 1.15.0
       Resolution: Fixed

Dynamically checks the TIME_WAIT value (which determines how long sockets are held after closing) for Linux and OSX to minimize sleep time.

> remove thread sleep from PubSubNativeRedisAcceptanceTest class cleanup
> ----------------------------------------------------------------------
>
>                 Key: GEODE-9495
>                 URL: https://issues.apache.org/jira/browse/GEODE-9495
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Hale Bales
>            Assignee: Ray Ingles
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> GEODE-9338 includes the addition of a Thread.sleep(240000) in the class cleanup. This wait is necessary to allow the sockets used in this class to exit the TIME_WAIT state. Out of Mac, Linux, and Windows, Windows has the longest default TIME_WAIT, which is 240 seconds. So currently at the end of the PubSubNativeRedisAcceptanceTest tests, we wait for 240 seconds.
> Another solution was proposed that involved parsing netstat outputs to find out when enough sockets have been freed, but the complexity didn't buy us much there.
> A potential other solution would be to reduce the TIME_WAIT period when running the tests in CI. 
> If we don't wait for the TIME_WAIT period to be up then other tests being run after it will get bind exceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)