[jira] [Commented] (KARAF-643) KarArtifactInstaller::init has incorrect warning logic

["Chris Dolan (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253312#comment-13253312 ] 

Chris Dolan commented on KARAF-643:
-----------------------------------

The patch should be "(!file.exists() && !file.mkdirs())" because mkdirs returns false if the folder already exists.

                
> KarArtifactInstaller::init has incorrect warning logic
> ------------------------------------------------------
>
>                 Key: KARAF-643
>                 URL: https://issues.apache.org/jira/browse/KARAF-643
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-kar
>    Affects Versions: 2.2.0, 2.2.1
>         Environment: Ubuntu Linux (though I believe the issue affects all platforms).
>            Reporter: Yaytay
>            Assignee: Jean-Baptiste Onofré
>            Priority: Trivial
>             Fix For: 3.1.0
>
>         Attachments: karaf-643.txt
>
>
> KarArtifactInstaller.java has the following block:
> if (new File(timestampPath).mkdirs()) {
>   logger.warn("Unable to create directory for Karaf Archive timestamps. Results may vary...");
> }
> which looks as though it's missing a !
> mkdirs returns true if and only if the directory was created, along with all necessary parent directories; false otherwise.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira