You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/26 13:53:53 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31341: [SPARK-34238][SQL] Unify output of SHOW PARTITIONS and pass output attributes properly

HyukjinKwon commented on a change in pull request #31341:
URL: https://github.com/apache/spark/pull/31341#discussion_r564525662



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowPartitionsSuite.scala
##########
@@ -126,4 +127,22 @@ class ShowPartitionsSuite extends ShowPartitionsSuiteBase with CommandSuiteBase
       checkAnswer(spark.table(t), Row(0, null) :: Row(1, null) :: Nil)
     }
   }
+
+  test("SPARK-34238 Unify output of SHOW PARTITIONS and pass output attributes properly") {

Review comment:
       Hm how does this test validate the change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org