You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/15 17:54:57 UTC

[GitHub] [airflow] eladkal opened a new issue #14243: upgrade checker fails for non python files

eladkal opened a new issue #14243:
URL: https://github.com/apache/airflow/issues/14243


   
   **What happened**:
   
   Running upgrade checker 1.2.0 on one of my repos produced the following errors:
   
   ChainBetweenDAGAndOperatorNotAllowedRule:
   ```
   Traceback (most recent call last):
    File "/home/airflow/.local/bin/airflow", line 37, in <module>
     args.func(args)
    File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/checker.py", line 118, in run
     all_problems = check_upgrade(formatter, rules)
    File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/checker.py", line 38, in check_upgrade
     rule_status = RuleStatus.from_rule(rule)
    File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/problem.py", line 44, in from_rule
     result = rule.check()
    File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/rules/chain_between_dag_and_operator_not_allowed_rule.py", line 72, in check
     problems.extend(self._check_file(file_path))
    File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/rules/chain_between_dag_and_operator_not_allowed_rule.py", line 40, in _check_file
     lines = file_pointer.readlines()
    File "/usr/local/lib/python3.6/codecs.py", line 321, in decode
     (result, consumed) = self._buffer_decode(data, self.errors, final)
   UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 14: invalid start byte
   ```
   
   ImportChangesRule:
   ```
   Traceback (most recent call last):
     File "/home/airflow/.local/bin/airflow", line 37, in <module>
       args.func(args)
     File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/checker.py", line 118, in run
       all_problems = check_upgrade(formatter, rules)
     File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/checker.py", line 38, in check_upgrade
       rule_status = RuleStatus.from_rule(rule)
     File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/problem.py", line 44, in from_rule
       result = rule.check()
     File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/rules/import_changes.py", line 145, in check
       new_problems, new_providers = self._check_file(file)
     File "/usr/local/lib/python3.6/site-packages/airflow/upgrade/rules/import_changes.py", line 114, in _check_file
       content = file.read()
     File "/usr/local/lib/python3.6/codecs.py", line 321, in decode
       (result, consumed) = self._buffer_decode(data, self.errors, final)
   UnicodeDecodeError: 'utf-8' codec can't decode byte 0xa3 in position 14: invalid start byte
   ```
   
   I traced it to a `.docx` file that caused these exceptions but it took work to figure it out as the traceback doesn't specify what file caused it.
   
   This is a similar to https://github.com/apache/airflow/issues/13349 which fixed it for `AirflowMacroPluginRemovedRule`
   
   
   **Anything else we need to know**:
   Since occupied with migration it will take a while before I can raise PR to address this. In case someone can handle sooner you can take this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-785310719


   Fixed by https://github.com/apache/airflow/pull/14344 and will be released in **upgrade check 1.3.0**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] digitalsimboja commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-779736516


   Hello I am new to Airflow and an Outreachy applicant. I would love to take on this issue as **good-first-issue**. In addition I appreciate guides as I work on it. I have setup Airflow on my local machine and successfully can run **./breeze**.  Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #14243:
URL: https://github.com/apache/airflow/issues/14243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] digitalsimboja commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-780063774


   Thanks I am working on it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] digitalsimboja commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
digitalsimboja commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-781055987


   Yes,
   
   I believe so.
   Taking care of both.
   Regards
   
   On Feb 17, 2021 19:18, "eladkal" <no...@github.com> wrote:
   
   > Assigned #14243 <https://github.com/apache/airflow/issues/14243> to
   > @digitalsimboja <https://github.com/digitalsimboja>.
   >
   > —
   > You are receiving this because you were assigned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/issues/14243#event-4342859816>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AHUTWR3IZORSRGELLPDDW6LS7QB77ANCNFSM4XVCYDHQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-779376703


   @madison-ookla since you handled the first issue. do you want to handle this as well? :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] madison-ookla commented on issue #14243: upgrade checker fails for non python files

Posted by GitBox <gi...@apache.org>.
madison-ookla commented on issue #14243:
URL: https://github.com/apache/airflow/issues/14243#issuecomment-780055519


   @digitalsimboja Hey Sunday, this is all yours! @eladkal has linked the related PR in this description, I believe that similar logic can probably be employed here to address this issue 🙂 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org